From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#30855: 25.3; temacs fails with bus error during garbage collection Date: Tue, 20 Mar 2018 16:26:19 +0100 Message-ID: References: <23215.54774.152043.418244@a1i15.kph.uni-mainz.de> <834llboouy.fsf@gnu.org> <23217.5116.912173.630464@a1i15.kph.uni-mainz.de> <83y3imls72.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1521559514 11609 195.159.176.226 (20 Mar 2018 15:25:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 20 Mar 2018 15:25:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) Cc: Ulrich Mueller , Paul Eggert , 30855@debbugs.gnu.org, gentoo-bug@opensource.sf-tec.de To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 20 16:25:10 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyJ8O-0002rQ-DJ for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Mar 2018 16:25:08 +0100 Original-Received: from localhost ([::1]:49986 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyJAP-0001II-Nk for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Mar 2018 11:27:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41802) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyJAI-0001I3-Vb for bug-gnu-emacs@gnu.org; Tue, 20 Mar 2018 11:27:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyJAF-0006nq-J1 for bug-gnu-emacs@gnu.org; Tue, 20 Mar 2018 11:27:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36090) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eyJAF-0006nj-FI for bug-gnu-emacs@gnu.org; Tue, 20 Mar 2018 11:27:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eyJAF-0004e2-6H for bug-gnu-emacs@gnu.org; Tue, 20 Mar 2018 11:27:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Mar 2018 15:27:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30855 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30855-submit@debbugs.gnu.org id=B30855.152155958817809 (code B ref 30855); Tue, 20 Mar 2018 15:27:03 +0000 Original-Received: (at 30855) by debbugs.gnu.org; 20 Mar 2018 15:26:28 +0000 Original-Received: from localhost ([127.0.0.1]:43987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyJ9f-0004dB-VX for submit@debbugs.gnu.org; Tue, 20 Mar 2018 11:26:28 -0400 Original-Received: from mx2.suse.de ([195.135.220.15]:44509) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyJ9e-0004cz-Du for 30855@debbugs.gnu.org; Tue, 20 Mar 2018 11:26:26 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Original-Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 24902AB36; Tue, 20 Mar 2018 15:26:20 +0000 (UTC) X-Yow: I want you to MEMORIZE the collected poems of EDNA ST VINCENT MILLAY.. BACKWARDS!! In-Reply-To: <83y3imls72.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 20 Mar 2018 16:47:29 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144452 Archived-At: On Mär 20 2018, Eli Zaretskii wrote: > So you are saying that we should be doing the below instead? > > diff --git a/src/alloc.c b/src/alloc.c > index 9d0e2d3..18546ca 100644 > --- a/src/alloc.c > +++ b/src/alloc.c > @@ -4983,7 +4983,8 @@ mark_memory (void *start, void *end) > for (pp = start; (void *) pp < end; pp += GC_POINTER_ALIGNMENT) > { > mark_maybe_pointer (*(void **) pp); > - mark_maybe_object (*(Lisp_Object *) pp); > + if ((intptr_t) pp % GCALIGNMENT == 0) That should be alignof(Lisp_Object). A Lisp_Object only needs Lisp_Object alignment. GCALIGNMENT is about the _value_ of a Lisp_Object (ie. the address of the Lisp object that this Lisp_Object points to). Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."