From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#58117: [PATCH] [SV 63111] Set osync handle to noinherit Date: Tue, 27 Sep 2022 16:23:04 +0200 Message-ID: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15404"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) To: 58117@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 27 17:10:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1odCE0-0003pT-9E for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Sep 2022 17:10:20 +0200 Original-Received: from localhost ([::1]:39942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odCDz-0007X7-8p for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Sep 2022 11:10:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38832) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odBVD-0005MU-3p for bug-gnu-emacs@gnu.org; Tue, 27 Sep 2022 10:24:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57432) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1odBVC-0007On-RY for bug-gnu-emacs@gnu.org; Tue, 27 Sep 2022 10:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1odBVC-00073z-8M for bug-gnu-emacs@gnu.org; Tue, 27 Sep 2022 10:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Sep 2022 14:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 58117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.166428859327079 (code B ref -1); Tue, 27 Sep 2022 14:24:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 27 Sep 2022 14:23:13 +0000 Original-Received: from localhost ([127.0.0.1]:56510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odBUP-00072h-0g for submit@debbugs.gnu.org; Tue, 27 Sep 2022 10:23:13 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:53868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odBUL-00072S-RR for submit@debbugs.gnu.org; Tue, 27 Sep 2022 10:23:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55748) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odBUL-0004gn-K6 for bug-gnu-emacs@gnu.org; Tue, 27 Sep 2022 10:23:09 -0400 Original-Received: from smtp-out2.suse.de ([195.135.220.29]:51764) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1odBUJ-0007CX-FS for bug-gnu-emacs@gnu.org; Tue, 27 Sep 2022 10:23:09 -0400 Original-Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id B53EE1FD2A for ; Tue, 27 Sep 2022 14:23:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1664288585; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=hr0Vi9vcDbpcIP6BwAOV5Y6XcvGBDrguNM7rCN6dxiQ=; b=zZ7Zsunsv/NNFSHb/KaB5wphH6AJ+iLp2e9gfEIIf/8lhQKjt0nstRQvhVCaYaL52ijTqR 5Znmz7zZP2BxzGMIeHt3hmbkcHXxO0I7v4YEHP0YSzcLP56Z9l83VyWDjqzNEQu7tWKcLm sNZ5Pe6g1xF1tH4kF+aWbKRDCcWt7FQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1664288585; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=hr0Vi9vcDbpcIP6BwAOV5Y6XcvGBDrguNM7rCN6dxiQ=; b=reTCkQRLnJyFt1mlim7QGBI6N/8roPumxPCE1oq23mlPuzK7nlG4WXsyEvPsaqTzgt4rfA sIGNJsUiE5U+SKAw== Original-Received: from hawking.suse.de (unknown [10.168.4.11]) by relay2.suse.de (Postfix) with ESMTP id AD4062C166 for ; Tue, 27 Sep 2022 14:23:05 +0000 (UTC) Original-Received: by hawking.suse.de (Postfix, from userid 17005) id B14D244017F; Tue, 27 Sep 2022 16:23:04 +0200 (CEST) X-Yow: Hold the MAYO & pass the COSMIC AWARENESS... Received-SPF: pass client-ip=195.135.220.29; envelope-from=schwab@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243733 Archived-At: * src/posixos.c (osync_setup, osync_parse_mutex): Set osync_handle to noinherit. --- src/posixos.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/posixos.c b/src/posixos.c index d587f9c8..4097ce15 100644 --- a/src/posixos.c +++ b/src/posixos.c @@ -628,7 +628,10 @@ osync_setup () { osync_handle = get_tmpfd (&osync_tmpfile); if (osync_handle >= 0) - sync_parent = 1; + { + fd_noinherit (osync_handle); + sync_parent = 1; + } } char * @@ -662,6 +665,8 @@ osync_parse_mutex (const char *mutex) OSS (fatal, NILF, _("cannot open output sync mutex %s: %s"), osync_tmpfile, strerror (errno)); + fd_noinherit (osync_handle); + return 1; } -- 2.37.3 -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."