From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon Date: Wed, 22 Feb 2023 10:45:22 +0100 Message-ID: References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> <875yc4q0ee.fsf@web.de> <87y1p0obe8.fsf@web.de> <87ttzoo6px.fsf@web.de> <87pma8q2w1.fsf@web.de> <87wn4g4v1y.fsf@web.de> <87y1ovecz2.fsf@web.de> <8735739vun.fsf@web.de> <87a61759t5.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1231"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Cc: Michael Heerdegen , Eli Zaretskii , 61460@debbugs.gnu.org To: Ulrich Mueller Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 22 10:46:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pUlhe-000AaP-Kr for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 22 Feb 2023 10:46:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pUlhL-0003Nt-Hh; Wed, 22 Feb 2023 04:46:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUlhK-0003Nl-Jo for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2023 04:46:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pUlhK-0002fG-B4 for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2023 04:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pUlhK-0008UM-6G for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2023 04:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Feb 2023 09:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61460 X-GNU-PR-Package: emacs Original-Received: via spool by 61460-submit@debbugs.gnu.org id=B61460.167705913332587 (code B ref 61460); Wed, 22 Feb 2023 09:46:02 +0000 Original-Received: (at 61460) by debbugs.gnu.org; 22 Feb 2023 09:45:33 +0000 Original-Received: from localhost ([127.0.0.1]:58021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUlgr-0008TX-DS for submit@debbugs.gnu.org; Wed, 22 Feb 2023 04:45:33 -0500 Original-Received: from smtp-out1.suse.de ([195.135.220.28]:58736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUlgo-0008TJ-Qc for 61460@debbugs.gnu.org; Wed, 22 Feb 2023 04:45:31 -0500 Original-Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id E8F9D336CE; Wed, 22 Feb 2023 09:45:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1677059123; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FtapNsoLME74N1Pvv5dVc8g6VFQthpZLyz9CYeQ03Ao=; b=T4jDf3Ad6r2C/5D/+dIMlvI2MfJ19BXST0/wGVnu8oBmzmoehBVC7BCFdqyPd/Ugg3pGJl 4Rkl68YPsWJ0ZdpOSEcQzHIhS9pIrhncC0x2lZ+XhMb+cOar1HY/rtkxEUZDrvMybaJYCd ax1USOUrT6Lw0HWDFrFVt+OF5UskPIE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1677059123; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FtapNsoLME74N1Pvv5dVc8g6VFQthpZLyz9CYeQ03Ao=; b=Y6J6meFB4kz/YFgciybaYMbOiJJyUOFJxXqNz7p0MdpYcCEcytOwx28BCfjEWtLSHy7MwU KWe4rl51fxD766Ag== Original-Received: from hawking.suse.de (unknown [10.168.4.11]) by relay2.suse.de (Postfix) with ESMTP id 953152C141; Wed, 22 Feb 2023 09:45:22 +0000 (UTC) Original-Received: by hawking.suse.de (Postfix, from userid 17005) id 508844406CE; Wed, 22 Feb 2023 10:45:22 +0100 (CET) X-Yow: I want EARS! I want two ROUND BLACK EARS to make me feel warm 'n secure!! In-Reply-To: (Ulrich Mueller's message of "Wed, 22 Feb 2023 10:00:38 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256327 Archived-At: On Feb 22 2023, Ulrich Mueller wrote: >>>>>> On Tue, 21 Feb 2023, Michael Heerdegen wrote: > >>> That remark made me think about whether we want a `diary-eclipses' - or >>> teach `diary-lunar-phases' to report eclipses (at the moment the latter >>> doesn't report eclipses, I just tried). > >> Seems getting the latter is quite simple: > >> - (cons mark (concat (lunar-phase-name (nth 2 phase)) " " >> - (cadr phase)))))) >> + (cons mark >> + (let ((eclipse (nth 3 phase))) >> + (concat (lunar-phase-name (nth 2 phase)) " " >> + (cadr phase) >> + (if (string-empty-p eclipse) >> + "" >> + (concat " " eclipse)))))))) > > It is probably a matter of personal taste, but I dislike the nested > concats. This seems simpler (not tested, though): > > - (cons mark (concat (lunar-phase-name (nth 2 phase)) " " > - (cadr phase)))))) > + (cons mark > + (let ((eclipse (nth 3 phase))) > + (concat (lunar-phase-name (nth 2 phase)) " " > + (cadr phase) > + (if (string-empty-p eclipse) "" " ") > + eclipse)))))) concat also accepts lists, so nil is pefectly fine as an argument. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."