From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#64344: [PATCH] Make calculator work with customized mode-line Date: Thu, 29 Jun 2023 11:31:06 +0200 Message-ID: References: <87jzvn4f4e.fsf@pub.pink> <83jzvmu2r1.fsf@gnu.org> <83fs6aty6b.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32681"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: jm@pub.pink, 64344@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 29 11:32:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qEo0l-0008Gr-JE for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Jun 2023 11:32:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qEo0S-0005mu-8c; Thu, 29 Jun 2023 05:32:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEo0Q-0005mj-CJ for bug-gnu-emacs@gnu.org; Thu, 29 Jun 2023 05:32:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qEo0Q-0008QK-3d for bug-gnu-emacs@gnu.org; Thu, 29 Jun 2023 05:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qEo0Q-0002D3-01 for bug-gnu-emacs@gnu.org; Thu, 29 Jun 2023 05:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Jun 2023 09:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64344 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64344-submit@debbugs.gnu.org id=B64344.16880310748399 (code B ref 64344); Thu, 29 Jun 2023 09:32:01 +0000 Original-Received: (at 64344) by debbugs.gnu.org; 29 Jun 2023 09:31:14 +0000 Original-Received: from localhost ([127.0.0.1]:52277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEnzd-0002BP-Qf for submit@debbugs.gnu.org; Thu, 29 Jun 2023 05:31:14 -0400 Original-Received: from smtp-out2.suse.de ([195.135.220.29]:48332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEnzb-0002B8-NI for 64344@debbugs.gnu.org; Thu, 29 Jun 2023 05:31:12 -0400 Original-Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 536DD1F8AF; Thu, 29 Jun 2023 09:31:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1688031066; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M90naH3anFkxO9Bqtrf4gswZL3eo0OcoR67iSqZwaRE=; b=mNnQzO2U52z/9Bm1heVTNBtqVCj0jI+tcJuaGiAHgnXi7aPbzclLT0j5+x/Us98z+aiikj TSvVr3l/IEe9LY16P5a7erC/hIAerY6Wo8vN/IumXGWjaHXZq4CkDqEvd8/gKAdbp+EjZi uVgX6Vuz0qZVNCIktI7ZYc8b/RoK7Bg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1688031066; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M90naH3anFkxO9Bqtrf4gswZL3eo0OcoR67iSqZwaRE=; b=gySTdDM5SQYst6JAJ12jsDeLXcl5sJSorFniwqe/TbsjOsq5XpDltuyqFlnIGsZryEQcgA BqWpUeYQR+z1xnCg== Original-Received: from hawking.nue2.suse.org (unknown [10.168.4.11]) by relay2.suse.de (Postfix) with ESMTP id 3E44F2C142; Thu, 29 Jun 2023 09:31:06 +0000 (UTC) Original-Received: by hawking.nue2.suse.org (Postfix, from userid 17005) id 2889A4A03B6; Thu, 29 Jun 2023 11:31:06 +0200 (CEST) In-Reply-To: <83fs6aty6b.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 29 Jun 2023 12:28:28 +0300") X-Yow: A can of ASPARAGUS, 73 pigeons, some LIVE ammo, and a FROZEN DAQUIRI!! X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264272 Archived-At: On Jun 29 2023, Eli Zaretskii wrote: >> From: Andreas Schwab >> Cc: john muhl , 64344@debbugs.gnu.org >> Date: Thu, 29 Jun 2023 10:22:02 +0200 >> >> On Jun 29 2023, Eli Zaretskii wrote: >> >> >> - (and bx (or (not lh) (> lh 0)))) >> >> + (and bx (or (not lh) (> (if (listp lh) (cdr lh) lh) 0)))) >> > ^^^^^ >> > Shouldn't that be 'consp' instead? 'listp' returns non-nil for nil >> > argument. >> >> lh cannot be nil here, but it wouldn't make a difference anyway, since >> (cdr nil) returns nil. > > I prefer not to have, nor force others, to analyze code in order to > ensure it's correct. Then you need to add a comment, not change correct code. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."