unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: jm@pub.pink, 64344@debbugs.gnu.org
Subject: bug#64344: [PATCH] Make calculator work with customized mode-line
Date: Thu, 29 Jun 2023 11:43:59 +0200	[thread overview]
Message-ID: <mvmjzvmvc0w.fsf@suse.de> (raw)
In-Reply-To: <83edlutxpf.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 29 Jun 2023 12:38:36 +0300")

On Jun 29 2023, Eli Zaretskii wrote:

>> From: Andreas Schwab <schwab@suse.de>
>> Cc: jm@pub.pink,  64344@debbugs.gnu.org
>> Date: Thu, 29 Jun 2023 11:31:06 +0200
>> 
>> On Jun 29 2023, Eli Zaretskii wrote:
>> 
>> >> From: Andreas Schwab <schwab@suse.de>
>> >> Cc: john muhl <jm@pub.pink>,  64344@debbugs.gnu.org
>> >> Date: Thu, 29 Jun 2023 10:22:02 +0200
>> >> 
>> >> On Jun 29 2023, Eli Zaretskii wrote:
>> >> 
>> >> >> -               (and bx (or (not lh) (> lh 0))))
>> >> >> +               (and bx (or (not lh) (> (if (listp lh) (cdr lh) lh) 0))))
>> >> >                                                ^^^^^
>> >> > Shouldn't that be 'consp' instead?  'listp' returns non-nil for nil
>> >> > argument.
>> >> 
>> >> lh cannot be nil here, but it wouldn't make a difference anyway, since
>> >> (cdr nil) returns nil.
>> >
>> > I prefer not to have, nor force others, to analyze code in order to
>> > ensure it's correct.
>> 
>> Then you need to add a comment, not change correct code.
>
> There's no reason whatsoever to comment correct code.

Ok, so nothing needs to change.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."





  reply	other threads:[~2023-06-29  9:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-28 18:23 bug#64344: [PATCH] Make calculator work with customized mode-line john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-29  7:49 ` Eli Zaretskii
2023-06-29  8:22   ` Andreas Schwab
2023-06-29  9:28     ` Eli Zaretskii
2023-06-29  9:31       ` Andreas Schwab
2023-06-29  9:38         ` Eli Zaretskii
2023-06-29  9:43           ` Andreas Schwab [this message]
2023-06-29  8:46   ` Stephen Berman
2023-06-29  9:26     ` Eli Zaretskii
2023-06-29 10:17       ` Stephen Berman
2023-06-29 15:12 ` john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-29 18:22   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mvmjzvmvc0w.fsf@suse.de \
    --to=schwab@suse.de \
    --cc=64344@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=jm@pub.pink \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).