From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#70260: [PATCH] Flymake support for rust-ts-mode (clippy-driver) Date: Tue, 09 Apr 2024 02:42:15 +0000 Message-ID: References: <28264769-159f-40b2-b798-bf0b3f5d7ee1@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="383"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70260@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 09 04:43:09 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ru1S1-000AU5-OS for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Apr 2024 04:43:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ru1Rp-000659-EQ; Mon, 08 Apr 2024 22:42:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ru1Rn-00064m-Em for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2024 22:42:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ru1Rn-0005IL-6V for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2024 22:42:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ru1Ru-0002zs-KR for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2024 22:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Apr 2024 02:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70260 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70260-submit@debbugs.gnu.org id=B70260.171263056411355 (code B ref 70260); Tue, 09 Apr 2024 02:43:02 +0000 Original-Received: (at 70260) by debbugs.gnu.org; 9 Apr 2024 02:42:44 +0000 Original-Received: from localhost ([127.0.0.1]:47947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ru1RY-0002wi-5M for submit@debbugs.gnu.org; Mon, 08 Apr 2024 22:42:43 -0400 Original-Received: from mail-40136.proton.ch ([185.70.40.136]:23481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ru1RS-0002vl-Iw for 70260@debbugs.gnu.org; Mon, 08 Apr 2024 22:42:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1712630539; x=1712889739; bh=gz+MqoU4NOeDG+lGdPEKS/E09nBYtrlWC/KiC9mHt2k=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=lFpHlGXHkfRVE7G2EGeOIiSVok/70QghMq/VPzYxDdFfNkcmx1kLSu1fhjfaU+c/L 0+ufHIgK1+nZOzVx1vGlwHPvHrAo0pF4jlhEWUykDoa3trdjY3fDb635bEW96tXWC0 1fo0bnzJSzEjXL252PxG+3TQjX1dXFXQ+MUbIFsMtezgovPhfTMgonlCisBBEmoGJi 0BlP527TRLiHWjEbJyq/1MMoqDo55O3OoPkSlZFEUouasNRWyf16YSysHjqQdJi/vA SPKUac0V+pYkzF+lEzoHyQV2MY6QdckTBAyDKJb9cP6/uwDWH/SQkUg0QIQ8mKBoeO 71M0r+kRL+MSg== In-Reply-To: <28264769-159f-40b2-b798-bf0b3f5d7ee1@gutov.dev> Feedback-ID: 44397038:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282959 Archived-At: On Sunday, April 7th, 2024 at 20:26, Dmitry Gutov wrote: >=20 >=20 > Minor fix and a TODO comment for the "cargo clippy" case. >=20 > On 07/04/2024 19:42, Dmitry Gutov wrote: >=20 > > X-Debbugs-Cc: Randy Taylor dev@rjt.dev > >=20 > > Hi Randy and others, > >=20 > > Here's a patch adding rust-ts-mode <-> flymake-mode integration using > > clippy. > >=20 > > Feedback welcome. Thanks for working on this. I'm not really familiar with flymake integration, but this looks good to me. I have a few nits below. +(defcustom rust-ts-flymake-command '("clippy-driver" "-") + "The external tool that will be used to perform the syntax check. ^^^^^^^^^^^^^^^^ maybe just "the check"? Or something similar, since more is being done than just syntax checking. +This is a non empty list of strings, the checker tool possibly followed ^^^^^^^^^ ^ non-empty? A colon would work well here. +(defvar rust-ts--flymake-proc nil) Should this be defvar-local? + ;; Flymake ^ A period at the end would make me happy :).