From: Jan Synacek <jsynacek@redhat.com>
To: Pip Cet <pipcet@gmail.com>
Cc: 41640@debbugs.gnu.org
Subject: bug#41640: 28.0.50; shell startup very slow when init file is used
Date: Fri, 05 Jun 2020 11:07:49 +0200 [thread overview]
Message-ID: <m6fmu5hg9sq.fsf@jsynacek-ntb.brq.redhat.com> (raw)
In-Reply-To: <83h7vqar34.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Pip Cet <pipcet@gmail.com>
>> Date: Thu, 04 Jun 2020 21:21:00 +0000
>> Cc: 41640@debbugs.gnu.org
>>
>> diff --git a/lisp/comint.el b/lisp/comint.el
>> index ea06f8af87..4354a155c3 100644
>> --- a/lisp/comint.el
>> +++ b/lisp/comint.el
>> @@ -809,18 +809,10 @@ comint-exec
>> (goto-char (point-max))
>> (set-marker (process-mark proc) (point))
>> ;; Feed it the startfile.
>> - (cond (startfile
>> - ;;This is guaranteed to wait long enough
>> - ;;but has bad results if the comint does not prompt at all
>> - ;; (while (= size (buffer-size))
>> - ;; (sleep-for 1))
>> - ;;I hope 1 second is enough!
>> - (sleep-for 1)
>> - (goto-char (point-max))
>> - (insert-file-contents startfile)
>> - (setq startfile (buffer-substring (point) (point-max)))
>> - (delete-region (point) (point-max))
>> - (comint-send-string proc startfile)))
>> + (when startfile
>> + (comint-send-string proc (with-temp-buffer
>> + (insert-file-contents startfile)
>> + (buffer-string))))
This patch removes the slowness.
prev parent reply other threads:[~2020-06-05 9:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 8:52 bug#41640: 28.0.50; shell startup very slow when init file is used Jan Synacek
2020-06-04 21:21 ` Pip Cet
2020-06-05 7:50 ` Eli Zaretskii
2020-06-05 8:30 ` Pip Cet
2020-06-05 11:51 ` Eli Zaretskii
2020-06-05 12:13 ` Pip Cet
2020-09-27 13:10 ` Lars Ingebrigtsen
2020-06-05 9:07 ` Jan Synacek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m6fmu5hg9sq.fsf@jsynacek-ntb.brq.redhat.com \
--to=jsynacek@redhat.com \
--cc=41640@debbugs.gnu.org \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).