From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daiki Ueno Newsgroups: gmane.emacs.bugs Subject: bug#20193: 25.0.50; declarative type specification for D-Bus args Date: Thu, 03 Sep 2015 18:29:40 +0900 Message-ID: References: <87bnjgat6z.fsf@gmx.de> <874mp628is.fsf@gmx.de> <87613wkhkm.fsf@gmx.de> <87d1y0apav.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1441272624 4954 80.91.229.3 (3 Sep 2015 09:30:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 3 Sep 2015 09:30:24 +0000 (UTC) Cc: 20193@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 03 11:30:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZXQqT-0002P9-9Q for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Sep 2015 11:30:13 +0200 Original-Received: from localhost ([::1]:46237 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXQqT-0000Qy-E4 for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Sep 2015 05:30:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56342) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXQqP-0000QA-7Y for bug-gnu-emacs@gnu.org; Thu, 03 Sep 2015 05:30:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXQqM-0004O8-1s for bug-gnu-emacs@gnu.org; Thu, 03 Sep 2015 05:30:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55058) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXQqL-0004NA-UJ for bug-gnu-emacs@gnu.org; Thu, 03 Sep 2015 05:30:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZXQqL-0002aI-FW for bug-gnu-emacs@gnu.org; Thu, 03 Sep 2015 05:30:05 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daiki Ueno Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Sep 2015 09:30:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20193 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20193-submit@debbugs.gnu.org id=B20193.14412725959894 (code B ref 20193); Thu, 03 Sep 2015 09:30:04 +0000 Original-Received: (at 20193) by debbugs.gnu.org; 3 Sep 2015 09:29:55 +0000 Original-Received: from localhost ([127.0.0.1]:47268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZXQqA-0002ZV-Vn for submit@debbugs.gnu.org; Thu, 03 Sep 2015 05:29:55 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46268) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZXQq8-0002ZN-8A for 20193@debbugs.gnu.org; Thu, 03 Sep 2015 05:29:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXQq4-000446-Im for 20193@debbugs.gnu.org; Thu, 03 Sep 2015 05:29:51 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51064) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXQq4-00043v-GQ; Thu, 03 Sep 2015 05:29:48 -0400 Original-Received: from du-a.org ([219.94.251.20]:33511 helo=dhcp-217-92.nrt.redhat.com) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1ZXQq3-00033w-QU; Thu, 03 Sep 2015 05:29:48 -0400 In-Reply-To: <87d1y0apav.fsf@gmx.de> (Michael Albinus's message of "Wed, 02 Sep 2015 16:06:32 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106103 Archived-At: Michael Albinus writes: >> I was actually not sure about the standard usage of subfeatures, and >> copied the logic from process.c, where they are defined as a plist, so >> they can be tested as: >> >> (featurep 'make-network-process '(:server t)) > > featurep has the restriction, that you can test only one subfeature per > call. That's why they have created just one "subfeature", being a list. Thanks for the explanation. >> I am working on this, but it is turning to be non-trivial. So, I have >> pushed it to a separate branch scratch/dbusbind-type-tests, branched off >> from scratch/dbusbind-type. > > Fortunately, I had some time to look on this today. I've committed some > changes to dbusbind.c, all of them rather cosmetical. Nice fixes, thanks! > And I'm asking myself, whether we shall rename `dbus-message-internal' > and `dbus-message-internal-to-lisp' to `dbus--message-*', in order to > emphasize their internal nature. That sounds like a good idea. > I have added two tests to `dbus-test04-create-message-parameters', both > fail. The first one must pass; this feature works in the master > branch. This was caused by a double registration of `:signature' symbol. Fixed as: http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=scratch/dbusbind-type-tests&id=777848833cc9ff40411b78ad107e755172a881b8 > For the second new test I'm not sure whether this is possible (the > documentation doesn't speak about), but it looks natural to me. Yes, this was actually a bug because of missing checks on the number of required arguments after `:type'. Fixed as: http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=scratch/dbusbind-type-tests&id=def5829c0769b142b3cc0d69a9ad58935a9f237f Regards, -- Daiki Ueno