From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#28434: 25.2; Final "\ No newline at end of file" breaks Emacs patch handling. Date: Mon, 24 Jun 2019 18:13:48 +0200 Message-ID: References: <86lglj6bkl.fsf@gavenkoa.example.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="51190"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 28434@debbugs.gnu.org To: Oleksandr Gavenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 24 18:22:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfRjL-000D3J-4M for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Jun 2019 18:22:07 +0200 Original-Received: from localhost ([::1]:52968 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfRjK-0003Sa-3b for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Jun 2019 12:22:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56529) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfRbf-00079u-0y for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 12:14:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfRbZ-0001Td-Ll for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 12:14:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44190) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfRbW-0001Qu-0h for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 12:14:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hfRbV-00048c-Ml for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 12:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Jun 2019 16:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28434 X-GNU-PR-Package: emacs Original-Received: via spool by 28434-submit@debbugs.gnu.org id=B28434.156139283515871 (code B ref 28434); Mon, 24 Jun 2019 16:14:01 +0000 Original-Received: (at 28434) by debbugs.gnu.org; 24 Jun 2019 16:13:55 +0000 Original-Received: from localhost ([127.0.0.1]:57731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfRbO-00047v-K8 for submit@debbugs.gnu.org; Mon, 24 Jun 2019 12:13:54 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:60910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfRbM-00047n-Vy for 28434@debbugs.gnu.org; Mon, 24 Jun 2019 12:13:53 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfRbJ-0005BZ-17; Mon, 24 Jun 2019 18:13:51 +0200 In-Reply-To: <86lglj6bkl.fsf@gavenkoa.example.com> (Oleksandr Gavenko's message of "Tue, 12 Sep 2017 21:01:14 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161238 Archived-At: Oleksandr Gavenko writes: > It's very annoying as I have no control over file content and sometime can't > add final new line. I think that's kind of unusual -- most text file formats can end in newlines. > Emacs commands in diff mode should tolerate ``\`` message about missing final > new line. > > ediff-diff-ok-lines-regexp is: > > "^\\([0-9,]+[acd][0-9,]+?$\\|[<>] \\|---\\|.*Warning *:\\|.*No +newline\\|.*missing +newline\\|^?$\\)" > > and match that line. I think if you need this, you should add it to that variable, but I don't think this would be a good default. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no