From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.bugs Subject: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 Date: Sun, 17 Jun 2018 09:02:41 -0400 Message-ID: References: <87po132y9k.fsf@gmail.com> <87h8me3hyw.fsf@gmail.com> <87zi0611m6.fsf@gmail.com> <87vaat1ndq.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1529240473 26845 195.159.176.226 (17 Jun 2018 13:01:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 17 Jun 2018 13:01:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) Cc: Noam Postavsky , 31742-done@debbugs.gnu.org To: Alex Harsanyi Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 17 15:01:09 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUXIp-0006q9-Cu for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Jun 2018 15:01:07 +0200 Original-Received: from localhost ([::1]:55257 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUXKw-0000Xb-AW for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Jun 2018 09:03:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50703) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUXKk-0000WH-Lh for bug-gnu-emacs@gnu.org; Sun, 17 Jun 2018 09:03:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fUXKh-0003BN-Cz for bug-gnu-emacs@gnu.org; Sun, 17 Jun 2018 09:03:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44784) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fUXKh-0003BC-64 for bug-gnu-emacs@gnu.org; Sun, 17 Jun 2018 09:03:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fUXKg-0006ZF-Kf for bug-gnu-emacs@gnu.org; Sun, 17 Jun 2018 09:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thomas Fitzsimmons Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Jun 2018 13:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31742 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31742-done@debbugs.gnu.org id=D31742.152924057125227 (code D ref 31742); Sun, 17 Jun 2018 13:03:01 +0000 Original-Received: (at 31742-done) by debbugs.gnu.org; 17 Jun 2018 13:02:51 +0000 Original-Received: from localhost ([127.0.0.1]:52681 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUXKV-0006Yp-Bh for submit@debbugs.gnu.org; Sun, 17 Jun 2018 09:02:51 -0400 Original-Received: from mail-it0-f54.google.com ([209.85.214.54]:50267) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUXKT-0006Ya-Ei for 31742-done@debbugs.gnu.org; Sun, 17 Jun 2018 09:02:50 -0400 Original-Received: by mail-it0-f54.google.com with SMTP id u4-v6so8513583itg.0 for <31742-done@debbugs.gnu.org>; Sun, 17 Jun 2018 06:02:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=vJoBrjfjOwFo6nC1GHLHZnz2vsuTr05lZalyqDXGJNU=; b=Gd7wiYcpCndcEjdrgiIqQ/3LNxP7GtB37/u0dEkv7PskdzVtELn4Qm/z6YUAK6zoWU Lgf1A+jSxM4MUOR4OuvZCNqquWXaW6swyzvUkC4HZ4KN9CJSEM+i3P3UJQFyhln8I/Ob onjvvWl5YmN+P0DSUbjrcGWRRar2fbsmLKVMU/SPf9qlxu8BfruF+aWDfHKqx63flSqI lak5m3rXPaKVaOA2OHn2SRv9LUbGWeQ1hYM5UgKcH5BZ9AsV1NhoFASft/df4RRB6E/p WCQfCslfXQz/31x/bqvM7PPO0wJmd0RZjvyhof+M8/7U6qf2tvL8wvYdpIhnnpRP8ia6 zrKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=vJoBrjfjOwFo6nC1GHLHZnz2vsuTr05lZalyqDXGJNU=; b=adJPL7VuQ7zSzj2U8i8n07sff5S7DSgjdo+XazDZhA4nDz2L/5Q4RKaUQPpXwa/YAp uqIqwbP7RO4UX1Gg3RaI/raJvb6rnUUV9k8mate6XN1DATrv385BUG8PkwFL17RvzdGp coVXcEemdrbKdobd947QfiH4DiWsQEPPJd61mefEyFWpBOgl7qTLf9sEis+EEFV97p9+ f5S4Gz2ZuPDHjtMsyf39qndAazj/Zv0V5E1JVRSgh/tGCB0uIBthmelpEqzof4xP+I1H c7yxlDfGwlg6SgtsVARbUWh9yYMTYGT067z8z2X2VZJ/51to8chq6wRY2uBI5cIYMJQH KHEA== X-Gm-Message-State: APt69E2u4FsTsiyB2+t2xDcbWnJr7tIYs6JnWmx/sgf9cTtiLt3ROKoq fuSY4MUKNWvZXogq9QnW6cKX5cLv X-Google-Smtp-Source: ADUXVKI20r6mOt09V6DBJT+oT5faZxysLROwpIBPSgkldzYrD266MqgpsoRUh3ny05PbPpfadtrelA== X-Received: by 2002:a02:9914:: with SMTP id r20-v6mr6633337jaj.144.1529240563508; Sun, 17 Jun 2018 06:02:43 -0700 (PDT) Original-Received: from hp-dv5t (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id n202-v6sm3048649itg.23.2018.06.17.06.02.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 17 Jun 2018 06:02:42 -0700 (PDT) In-Reply-To: (Alex Harsanyi's message of "Sun, 17 Jun 2018 09:31:35 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147575 Archived-At: Hi Alex, I pushed the patch and the 3.1.4 tag to https://github.com/alex-hhh/emacs-soap-client.git so at least everything is consistent again, except that the ELPA page doesn't point to "Homepage". I think that's a bug in GNU ELPA's generation scripts though -- can you file a bug report for this? As for repository organization, I'm fine with things as-is, I just have to remember to push to GitHub anytime I push to emacs.git. Right now the history is almost the same between emacs.git and emacs-soap-client.git, and the files on the master branches are identical. Maybe in the future when elpa.git and emacs.git integration is better we can use the elpa.git-separate-branch approach, and emacs.git will automatically clone elpa.git as a submodule and everything will work in core and for GNU ELPA updates. In fact, soap-client is probably a good non-trivial package to experiment with different Git organization approaches for such core-and-GNU-ELPA packages. There was a thread on emacs-devel about this recently, in the context of adding BBDB to core. I'm not working on this Git integration effort directly right now, but I think some people are from time to time. Thomas Alex Harsanyi writes: > Hi Thomas, > > I was not aware that the soap-client.el in the GNU Emacs source has been > updated -- the maintainers at the time wanted a version that just worked with > debbugs, and put the most recent version in ELPA. > > There are two inconsistencies with the current system, which can cause some > confusion: > > * the soap-client web page on elpa.gnu.org has a link to the elpa.git > repository, but there is nothing there (the CGit and Gitweb links): > http://elpa.gnu.org/packages/soap-client.html > > * in the GNU Emacs source code, soap-client.el has a "Homepage" link that > points back to my GitHub repository, which is now out of date. > > I think we need to decide on where to keep the "official" development history > for this package. As I see it, there are a few options: > > * Keep it on GitHub, where it is now. In this case, I think you should push > the patch and the 3.1.4 tag there, and the ELPA links need to be fixed. > > * Import it into elpa.git, as a separate branch (I see other packages are > maintained like that). In this case, the "Homepage" link should be updated > to point to this source. > > * Keep it in the GNU Emacs source tree (this will loose the git history, but > maybe it is not important). In this case the, both the "Homepage" link and > the ELPA web page should be updated. > > I have no strong preference for either option, apart for making it easier for > people to know where to go for the package source. If the GitHub repository > is no longer the latest source code, I can archive it and point to the new > location. > > > Alex. > > On Sun, Jun 17, 2018 at 8:36 AM, Thomas Fitzsimmons wrote: >> Alex Harsanyi writes: >> >>> On Tue, Jun 12, 2018 at 9:55 AM, Thomas Fitzsimmons wrote: >>> >>>> I added the comment, bumped the soap-client version to 3.1.4 and pushed >>>> the patch to master so that GNU ELPA will be regenerated tonight. I >>>> also backported the patch to the emacs-26 branch since it fixes a >>>> functional regression. >>> >>> Hi Thomas, >>> >>> Can you let me know where did you push the soap-client changes? >>> >>> I can see that the package was released at gnu.elpa.org, but the >>> changes were not pushed either to the elpa.git repository at >>> https://git.savannah.gnu.org/git/emacs/elpa.git, or to my own copy of >>> it at https://github.com/alex-hhh/emacs-soap-client. >> >> I pushed it to the emacs.git master and emacs-26 branches: >> >> http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1feb2e221349f26ec26bc684e0cce2acecbed3ca >> >> GNU ELPA pulls soap-client.el and soap-inspect.el from emacs.git's >> master branch. >> >> Let me know if you also want me to push the patch to >> https://github.com/alex-hhh/emacs-soap-client. >> >> Thomas