unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#7511: 24.0.50; describe-variable trailing whitespace minor bug
@ 2010-11-28 17:58 jidanni
  2010-12-17 11:38 ` Chong Yidong
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: jidanni @ 2010-11-28 17:58 UTC (permalink / raw)
  To: 7511; +Cc: rfrancoise

(setq show-trailing-whitespace t)
(setq bla "1234567890")
(describe-variable 'bla) ; output looks good
(setq bla "12345678901234567890")
(describe-variable 'bla) ; ouptut now on second line (odd, though plenty of
room left on first line, but never mind that), with trailing
whitespace on first line.





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#7511: 24.0.50; describe-variable trailing whitespace minor bug
  2010-11-28 17:58 bug#7511: 24.0.50; describe-variable trailing whitespace minor bug jidanni
@ 2010-12-17 11:38 ` Chong Yidong
  2010-12-19  7:15   ` Leo
  2011-07-02 21:28 ` bug#7512: 24.0.50; emacs -Q -nw -eval '(view-lossage)' shows phantom chars under xterm Lars Magne Ingebrigtsen
  2011-07-04  2:45 ` jidanni
  2 siblings, 1 reply; 9+ messages in thread
From: Chong Yidong @ 2010-12-17 11:38 UTC (permalink / raw)
  To: jidanni; +Cc: 7511, rfrancoise

jidanni@jidanni.org writes:

> (setq show-trailing-whitespace t)
> (setq bla "1234567890")
> (describe-variable 'bla) ; output looks good
> (setq bla "12345678901234567890")
> (describe-variable 'bla) ; ouptut now on second line (odd, though plenty of
> room left on first line, but never mind that), with trailing
> whitespace on first line.

Fixed, thanks.





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#7511: 24.0.50; describe-variable trailing whitespace minor bug
  2010-12-17 11:38 ` Chong Yidong
@ 2010-12-19  7:15   ` Leo
  2010-12-20 11:31     ` Chong Yidong
  0 siblings, 1 reply; 9+ messages in thread
From: Leo @ 2010-12-19  7:15 UTC (permalink / raw)
  To: Chong Yidong; +Cc: 7511, rfrancoise, jidanni

On 2010-12-17 11:38 +0000, Chong Yidong wrote:
> jidanni@jidanni.org writes:
>
>> (setq show-trailing-whitespace t)
>> (setq bla "1234567890")
>> (describe-variable 'bla) ; output looks good
>> (setq bla "12345678901234567890")
>> (describe-variable 'bla) ; ouptut now on second line (odd, though plenty of
>> room left on first line, but never mind that), with trailing
>> whitespace on first line.
>
> Fixed, thanks.

(line-beginning-position -1) actually moves backwards two lines, which
is really unintuitive (BTW it should be brought in line with
forward-line). So with Yidong's fix all standard variables are printed
on a newline. See C-h v fill-column.

The following patch fixes typo in the fix.

diff --git a/lisp/help-fns.el b/lisp/help-fns.el
index a6cf2b4..250c4b9 100644
--- a/lisp/help-fns.el
+++ b/lisp/help-fns.el
@@ -643,7 +643,7 @@ it is displayed along with the global value."
 		(let ((from (point)))
 		  (terpri)
 		  (pp val)
-		  (if (< (point) (- 68 (line-beginning-position -1)))
+		  (if (< (point) (+ 68 (line-beginning-position 0)))
 		      (delete-region from (1+ from))
 		    (delete-region (1- from) from)))))
 	    (terpri)

-- 
Oracle is the new evil





^ permalink raw reply related	[flat|nested] 9+ messages in thread

* bug#7511: 24.0.50; describe-variable trailing whitespace minor bug
  2010-12-19  7:15   ` Leo
@ 2010-12-20 11:31     ` Chong Yidong
  0 siblings, 0 replies; 9+ messages in thread
From: Chong Yidong @ 2010-12-20 11:31 UTC (permalink / raw)
  To: Leo; +Cc: 7511, rfrancoise, jidanni

Leo <sdl.web@gmail.com> writes:

> (line-beginning-position -1) actually moves backwards two lines, which
> is really unintuitive (BTW it should be brought in line with
> forward-line). So with Yidong's fix all standard variables are printed
> on a newline. See C-h v fill-column.
>
> The following patch fixes typo in the fix.

Thanks for the catch.  I've committed your fix.





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#7512: 24.0.50; emacs -Q -nw -eval '(view-lossage)' shows phantom chars under xterm
  2010-11-28 17:58 bug#7511: 24.0.50; describe-variable trailing whitespace minor bug jidanni
  2010-12-17 11:38 ` Chong Yidong
@ 2011-07-02 21:28 ` Lars Magne Ingebrigtsen
  2011-07-03  6:22   ` Eli Zaretskii
  2011-07-04  2:45 ` jidanni
  2 siblings, 1 reply; 9+ messages in thread
From: Lars Magne Ingebrigtsen @ 2011-07-02 21:28 UTC (permalink / raw)
  To: jidanni; +Cc: rfrancoise, 7512

jidanni@jidanni.org writes:

> No big deal, but
> $ emacs -Q -nw -eval '(view-lossage)'
> shows
> ESC [ > 0 ; 2 6 6 ; 0 c ESC ] 1 1 ; r g b : 0 0 0 0
> / 0 0 0 0 / 0 0 0 0 ESC \
> when run in xterm. I did not type that.

I can confirm this in a "C" locale, too:

ESC [ > 0 ; 2 6 1 ; 0 c ESC ] 1 1 ; r g b : 0 0 0 0
/ 0 0 0 0 / 0 0 0 0 ESC \ d s d s RET ESC x ESC p ESC
x v i e w - l o s TAB RET

Are those escape codes registered as typed keystrokes?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#7512: 24.0.50; emacs -Q -nw -eval '(view-lossage)' shows phantom chars under xterm
  2011-07-02 21:28 ` bug#7512: 24.0.50; emacs -Q -nw -eval '(view-lossage)' shows phantom chars under xterm Lars Magne Ingebrigtsen
@ 2011-07-03  6:22   ` Eli Zaretskii
  2011-07-04  2:04     ` Chong Yidong
  0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2011-07-03  6:22 UTC (permalink / raw)
  To: Lars Magne Ingebrigtsen; +Cc: jidanni, rfrancoise, 7512

> From: Lars Magne Ingebrigtsen <larsi@gnus.org>
> Date: Sat, 02 Jul 2011 23:28:33 +0200
> Cc: rfrancoise@debian.org, 7512@debbugs.gnu.org
> 
> jidanni@jidanni.org writes:
> 
> > No big deal, but
> > $ emacs -Q -nw -eval '(view-lossage)'
> > shows
> > ESC [ > 0 ; 2 6 6 ; 0 c ESC ] 1 1 ; r g b : 0 0 0 0
> > / 0 0 0 0 / 0 0 0 0 ESC \
> > when run in xterm. I did not type that.
> 
> I can confirm this in a "C" locale, too:
> 
> ESC [ > 0 ; 2 6 1 ; 0 c ESC ] 1 1 ; r g b : 0 0 0 0
> / 0 0 0 0 / 0 0 0 0 ESC \ d s d s RET ESC x ESC p ESC
> x v i e w - l o s TAB RET
> 
> Are those escape codes registered as typed keystrokes?

See xterm.el:terminal-init-xterm, search for send-string-to-terminal.
In a nutshell, we send special commands to the terminal to find out
about its capabilities.





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#7512: 24.0.50; emacs -Q -nw -eval '(view-lossage)' shows phantom chars under xterm
  2011-07-03  6:22   ` Eli Zaretskii
@ 2011-07-04  2:04     ` Chong Yidong
  0 siblings, 0 replies; 9+ messages in thread
From: Chong Yidong @ 2011-07-04  2:04 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: Lars Magne Ingebrigtsen, 7512, rfrancoise, jidanni

Eli Zaretskii <eliz@gnu.org> writes:

> See xterm.el:terminal-init-xterm, search for send-string-to-terminal.
> In a nutshell, we send special commands to the terminal to find out
> about its capabilities.

And it's scarcely worth it to try to remove these characters from
lossage, so feel free to close this bug.





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#7512: 24.0.50; emacs -Q -nw -eval '(view-lossage)' shows phantom chars under xterm
  2010-11-28 17:58 bug#7511: 24.0.50; describe-variable trailing whitespace minor bug jidanni
  2010-12-17 11:38 ` Chong Yidong
  2011-07-02 21:28 ` bug#7512: 24.0.50; emacs -Q -nw -eval '(view-lossage)' shows phantom chars under xterm Lars Magne Ingebrigtsen
@ 2011-07-04  2:45 ` jidanni
  2011-07-04  5:28   ` Chong Yidong
  2 siblings, 1 reply; 9+ messages in thread
From: jidanni @ 2011-07-04  2:45 UTC (permalink / raw)
  To: cyd; +Cc: rfrancoise, larsi, 7512

>>>>> "CY" == Chong Yidong <cyd@stupidchicken.com> writes:
CY> Eli Zaretskii <eliz@gnu.org> writes:

>> See xterm.el:terminal-init-xterm, search for send-string-to-terminal.
>> In a nutshell, we send special commands to the terminal to find out
>> about its capabilities.

CY> And it's scarcely worth it to try to remove these characters from
CY> lossage, so feel free to close this bug.

But maybe also p u t  s o m e  t i n y  h i n t  i n t o that buffer so
folks know what is going on. 





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#7512: 24.0.50; emacs -Q -nw -eval '(view-lossage)' shows phantom chars under xterm
  2011-07-04  2:45 ` jidanni
@ 2011-07-04  5:28   ` Chong Yidong
  0 siblings, 0 replies; 9+ messages in thread
From: Chong Yidong @ 2011-07-04  5:28 UTC (permalink / raw)
  To: jidanni; +Cc: rfrancoise, larsi, 7512

jidanni@jidanni.org writes:

> But maybe also p u t  s o m e  t i n y  h i n t  i n t o that buffer so
> folks know what is going on.

No, I don't think it's worth it.

Closing the bug.





^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2011-07-04  5:28 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-28 17:58 bug#7511: 24.0.50; describe-variable trailing whitespace minor bug jidanni
2010-12-17 11:38 ` Chong Yidong
2010-12-19  7:15   ` Leo
2010-12-20 11:31     ` Chong Yidong
2011-07-02 21:28 ` bug#7512: 24.0.50; emacs -Q -nw -eval '(view-lossage)' shows phantom chars under xterm Lars Magne Ingebrigtsen
2011-07-03  6:22   ` Eli Zaretskii
2011-07-04  2:04     ` Chong Yidong
2011-07-04  2:45 ` jidanni
2011-07-04  5:28   ` Chong Yidong

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).