* bug#6559: 24.0.50; :keys misaligns keyboard equivalents
@ 2010-07-03 16:59 Drew Adams
2011-07-04 15:14 ` Lars Magne Ingebrigtsen
2011-07-04 16:29 ` Drew Adams
0 siblings, 2 replies; 4+ messages in thread
From: Drew Adams @ 2010-07-03 16:59 UTC (permalink / raw)
To: 6559
[-- Attachment #1: Type: text/plain, Size: 1550 bytes --]
emacs -Q
This bug is a regression, starting with Emacs 23.2. There is no such
bug in Emacs 23.1, Emacs 22, 21, or 20.
See attached screenshots.
:key was used only for the menu item `Current Status, Mode Help'; the
other menu items do not use :key. You can see that the `?' is
misaligned: it is too far to the left.
The screenshot `throw-emacs-23-1-keys-OK.png' shows what Emacs 23.1
gives - the alignment is OK. Emacs 22, 21, and 20 are similar.
These are the relevant code lines, for context:
(define-key bmkp-bmenu-menubar-menu [bmkp-bmenu-quit]
'(menu-item "Quit" bmkp-bmenu-quit
:help "..."))
(define-key bmkp-bmenu-menubar-menu [bmkp-bmenu-describe-marked]
'(menu-item "Describe Marked Bookmarks" bmkp-bmenu-describe-marked
:help "..."))
(define-key bmkp-bmenu-menubar-menu [bmkp-bmenu-describe-this-bookmark]
'(menu-item "Describe This Bookmark" bmkp-bmenu-describe-this-bookmark
:help "..."))
(define-key bmkp-bmenu-menubar-menu [bmkp-bmenu-mode-status-help]
'(menu-item "Current Status, Mode Help" bmkp-bmenu-mode-status-help :keys "?"
:help "..."))
(define-key bmkp-bmenu-menubar-menu [top-sep2] '("--"))
(define-key bmkp-bmenu-menubar-menu [bmkp-toggle-saving-menu-list-state]
'(menu-item "Toggle Autosaving Display State"
bmkp-toggle-saving-menu-list-state
:help "..."))
In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
of 2010-06-28 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/xpm/include'
[-- Attachment #2: throw-emacs-23-1-keys-OK.png --]
[-- Type: image/png, Size: 20006 bytes --]
[-- Attachment #3: drew-emacs-bookmark+-menu.png --]
[-- Type: image/png, Size: 19295 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#6559: 24.0.50; :keys misaligns keyboard equivalents
2010-07-03 16:59 bug#6559: 24.0.50; :keys misaligns keyboard equivalents Drew Adams
@ 2011-07-04 15:14 ` Lars Magne Ingebrigtsen
2011-07-04 16:31 ` Drew Adams
2011-07-04 16:29 ` Drew Adams
1 sibling, 1 reply; 4+ messages in thread
From: Lars Magne Ingebrigtsen @ 2011-07-04 15:14 UTC (permalink / raw)
To: Drew Adams; +Cc: 6559
"Drew Adams" <drew.adams@oracle.com> writes:
> This bug is a regression, starting with Emacs 23.2. There is no such
> bug in Emacs 23.1, Emacs 22, 21, or 20.
>
> See attached screenshots.
>
> :key was used only for the menu item `Current Status, Mode Help'; the
> other menu items do not use :key. You can see that the `?' is
> misaligned: it is too far to the left.
>
> The screenshot `throw-emacs-23-1-keys-OK.png' shows what Emacs 23.1
> gives - the alignment is OK. Emacs 22, 21, and 20 are similar.
>
> These are the relevant code lines, for context:
>
> (define-key bmkp-bmenu-menubar-menu [bmkp-bmenu-quit]
> '(menu-item "Quit" bmkp-bmenu-quit
> :help "..."))
I don't have this package installed, but I tried adding :keys to a dired
menu entry (in Windows Emacs 24), and things aligned as they should.
Do you still see this bug?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#6559: 24.0.50; :keys misaligns keyboard equivalents
2010-07-03 16:59 bug#6559: 24.0.50; :keys misaligns keyboard equivalents Drew Adams
2011-07-04 15:14 ` Lars Magne Ingebrigtsen
@ 2011-07-04 16:29 ` Drew Adams
1 sibling, 0 replies; 4+ messages in thread
From: Drew Adams @ 2011-07-04 16:29 UTC (permalink / raw)
To: 6559; +Cc: 'Lars Magne Ingebrigtsen'
FYI -
This was fixed in Emacs 23.3. It was broken only in Emacs 23.2.
---------------------------------------------------------------
Processing commands for control@debbugs.gnu.org:
> tags 6559 unreproducible
Bug #6559 [emacs] 24.0.50; :keys misaligns keyboard equivalents
Added tag(s) unreproducible.
>
End of message, stopping processing here.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#6559: 24.0.50; :keys misaligns keyboard equivalents
2011-07-04 15:14 ` Lars Magne Ingebrigtsen
@ 2011-07-04 16:31 ` Drew Adams
0 siblings, 0 replies; 4+ messages in thread
From: Drew Adams @ 2011-07-04 16:31 UTC (permalink / raw)
To: 'Lars Magne Ingebrigtsen'; +Cc: 6559
> Do you still see this bug?
No; it was fixed in Emacs 23.3. Thanks for checking.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-07-04 16:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-03 16:59 bug#6559: 24.0.50; :keys misaligns keyboard equivalents Drew Adams
2011-07-04 15:14 ` Lars Magne Ingebrigtsen
2011-07-04 16:31 ` Drew Adams
2011-07-04 16:29 ` Drew Adams
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).