unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Felix E. Klee" <felix.klee@inka.de>
Cc: 32359@debbugs.gnu.org
Subject: bug#32359: [PATCH] Add svg-path
Date: Fri, 12 Jul 2019 18:02:56 +0200	[thread overview]
Message-ID: <m3wogns0jz.fsf@gnus.org> (raw)
In-Reply-To: <CA+m_8J3bzmvqqmdmDHUOpF8EagqmjovghP2nnHUihKDGZx+iwg@mail.gmail.com> (Felix E. Klee's message of "Fri, 12 Jul 2019 16:35:54 +0200")

"Felix E. Klee" <felix.klee@inka.de> writes:

> If you want to play with the new functions, simply run the code examples
> from the info page inside of `example.el`.  Concerning `svg+-path`, I’d
> like to hear your thoughts: Do you see room for further improvement, or
> could this be the final interface?

I haven't read it closely, but it looks good to me.  Could you post it
as a patch to svg.el?  That'll make it easier to read.

> I was thinking about removing the double parentheses in commands such
> as:
>
>     (lineto ((100 . 200)))
>
> One could simplify that to:
>
>     (lineto (100 . 200))
>
> Polylines would change from:
>
>     (lineto ((100 . 200) (300 . 200)))
>
> To:
>
>     (lineto (100 . 200) (300 . 200))
>
> Reasons against this change:
>
>   * Parsing optional arguments (plist) could be a pain.  Currently what
>     works nicely:
>
>         (lineto ((100 . 200) (200 . 0)) :relative t)

Yeah, I think you should keep the argument as a single argument.
Varargs with optional keywords parameters just isn't very nice.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2019-07-12 16:02 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-03 11:07 bug#32359: [PATCH] Add svg-path Felix E. Klee
2018-08-03 13:05 ` Eli Zaretskii
2018-08-23 15:50   ` Felix E. Klee
2018-08-23 17:23     ` Eli Zaretskii
2018-08-24  9:15       ` Felix E. Klee
2019-06-23 22:15     ` Lars Ingebrigtsen
2019-06-24 14:32       ` Felix E. Klee
2019-06-24 14:39         ` Lars Ingebrigtsen
2019-07-12 14:35           ` Felix E. Klee
2019-07-12 16:02             ` Lars Ingebrigtsen [this message]
2019-07-15 13:34               ` Felix E. Klee
2019-07-15 15:12                 ` Lars Ingebrigtsen
2019-07-15 20:40                   ` Felix E. Klee
2019-07-15 20:48                     ` Noam Postavsky
2019-07-16 10:32                       ` Felix E. Klee
2019-07-15 21:13                     ` Felix E. Klee
2019-07-16  6:05                     ` Lars Ingebrigtsen
2019-07-16 10:31                       ` Felix E. Klee
2019-07-16 13:46                         ` Lars Ingebrigtsen
2019-07-24  7:49                           ` Felix E. Klee
2019-07-24 14:30                             ` Eli Zaretskii
2019-07-30 17:46                           ` Felix E. Klee
2019-07-31 20:31                             ` Lars Ingebrigtsen
2019-08-01 13:23                               ` Felix E. Klee
2019-08-02  6:40                                 ` Eli Zaretskii
2019-08-02 10:43                                   ` Felix E. Klee
2019-08-02 11:57                                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3wogns0jz.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=32359@debbugs.gnu.org \
    --cc=felix.klee@inka.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).