From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.bugs Subject: bug#59314: 29.0.50; EUDC and message-mode header completion Date: Wed, 07 Dec 2022 17:21:40 -0500 Message-ID: References: <87a64q7p25.fsf@ericabrahamsen.net> <878rka1y4n.fsf@ericabrahamsen.net> <9cad334f4f42725f2e244c8c81528856@condition-alpha.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11118"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eric Abrahamsen , 59314@debbugs.gnu.org To: Alexander Adolf Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 07 23:22:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p32nw-0002iU-Pt for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Dec 2022 23:22:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p32nj-00048f-PH; Wed, 07 Dec 2022 17:22:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p32ni-00048V-1O for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2022 17:22:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p32nh-0006n0-MI for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2022 17:22:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p32nh-000415-HV for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2022 17:22:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thomas Fitzsimmons Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Dec 2022 22:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59314 X-GNU-PR-Package: emacs Original-Received: via spool by 59314-submit@debbugs.gnu.org id=B59314.167045171115433 (code B ref 59314); Wed, 07 Dec 2022 22:22:01 +0000 Original-Received: (at 59314) by debbugs.gnu.org; 7 Dec 2022 22:21:51 +0000 Original-Received: from localhost ([127.0.0.1]:52536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p32nW-00040r-Kg for submit@debbugs.gnu.org; Wed, 07 Dec 2022 17:21:50 -0500 Original-Received: from mail.fitzsim.org ([69.165.165.189]:42092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p32nT-00040l-KV for 59314@debbugs.gnu.org; Wed, 07 Dec 2022 17:21:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fitzsim.org ; s=20220430; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MPY19ep5/ujF3TZJqBx+JCVOYl6CxBdI2bHLDFGnMp0=; b=LDqk8sLneK0yLhSrd9wLEE8CNm UboIQzBkep8iAyOusz9p1G3zqAZyyOEwzr7kwTHKprO/XfaqzSvs/AFvYUnWBhrjP+gALqv9d0Cuk 7hMWtDAerndAAFknsQ5P53OOzWBnAzkNT1K7Nff5konYchlq1GvgT0Q/ov8eTuv9MAPaXgunXo36h CNjTIusP2sDv0Q+NYiv3I8++6DdyPZzRPoqsxdf00MPnw0I+HmwahbD4tetLZeN7fzRk0joKoxw5s xLPfSeOceLhWf4QndOdfrfTRjDUQF4KHPAwMFga6Bdjz1AHrxYA5KV9vmbR9DjDUqeEQUQcORu0lO dYwQ7ieA==; Original-Received: from [192.168.1.1] (helo=localhost.localdomain) by mail.fitzsim.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1p32nN-0003ii-5L; Wed, 07 Dec 2022 17:21:41 -0500 In-Reply-To: (Alexander Adolf's message of "Wed, 07 Dec 2022 23:10:06 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250223 Archived-At: Alexander Adolf writes: > Thomas Fitzsimmons writes: > >> [...] >> If I remove this line from message.el: >> >> (add-hook 'completion-at-point-functions #'eudc-capf-complete -1 t) >> >> and rebuild Emacs, then my recipe works, via: >> >> message-tab -...-> message-expand-name -> eudc-expand-inline >> >> The EUDC multi-selector UI is invoked allowing me to choose between >> emacs-ert-test-3 and emacs-ert-test-4, and the full name and email >> address is inserted correctly. This is with completion-styles left at >> its default value. >> >> So that's one code path validated, phew. >> [...] > > There are two ends to this, I think. > > For one, you are no longer adding `eudc-capf-complete` to > `completion-at-point-functions` in message mode. This seems fine given > that we are not there yet to make `eudc-capf-complete` the default thing > to happen in 29. To be clear, I wasn't going to push a patch to remove that, at least not yet. It's not making anything worse, so might as well leave it as-is. > [...] I'm trying to get message--name-table's EUDC support working. I only wanted to remove eudc-capf-complete from the debugging equation, because message--name-table existed way before eudc-capf-complete was introduced. I want to understand why it doesn't work (why it results in the " <..." expansion). I haven't delved deep enough into the completion-at-point to figure that out. I was hoping with your experience writing eudc-capf-complete that you'd know what was wrong with message--name-table's EUDC support. I don't think completion-styles should have any bearing on this. message--name-table's EUDC support has to be made to work with the default completion-styles setting. Do you know how to do that? Thanks, Thomas