From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.bugs Subject: bug#59314: 29.0.50; EUDC and message-mode header completion Date: Sat, 10 Dec 2022 09:27:21 -0500 Message-ID: References: <87a64q7p25.fsf@ericabrahamsen.net> <878rka1y4n.fsf@ericabrahamsen.net> <9cad334f4f42725f2e244c8c81528856@condition-alpha.com> <4d1810369df651d02ceeb522b8f05370@condition-alpha.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36185"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eric Abrahamsen , 59314@debbugs.gnu.org To: Alexander Adolf Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 10 15:28:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p40pp-0009Fb-GF for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Dec 2022 15:28:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p40ph-0008CS-QL; Sat, 10 Dec 2022 09:28:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p40pe-00089K-Gq for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2022 09:28:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p40pe-0008SO-8T for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2022 09:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p40pe-0007fs-3i for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2022 09:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thomas Fitzsimmons Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Dec 2022 14:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59314 X-GNU-PR-Package: emacs Original-Received: via spool by 59314-submit@debbugs.gnu.org id=B59314.167068245029458 (code B ref 59314); Sat, 10 Dec 2022 14:28:02 +0000 Original-Received: (at 59314) by debbugs.gnu.org; 10 Dec 2022 14:27:30 +0000 Original-Received: from localhost ([127.0.0.1]:43052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p40p8-0007f4-3u for submit@debbugs.gnu.org; Sat, 10 Dec 2022 09:27:30 -0500 Original-Received: from mail.fitzsim.org ([69.165.165.189]:40704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p40p6-0007ex-3s for 59314@debbugs.gnu.org; Sat, 10 Dec 2022 09:27:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fitzsim.org ; s=20220430; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=WqbU1n2mggqn5Tnh/gEpwOOO1wTkHYi3c+KHiLXpbVw=; b=efXQRvX7zkBTwerF5uLY/5wBsU 19Y5W/T3RLVdE7o+aIahHyz/oZeOShK/ivcReWYuATjAqbXs6c9lAyVsvUJbQDrec+lP020P6EBGh LZBY8/DRPUp9+milRrF44xf/KidMRQn2//D6ZDPVY8NWJtJlTWZbRulOXt9U+0Hqa88V0GY3N9Z5X VZsex+te0m7g9KqRdlDf2kBX+5wG2hggUQqTeVcBYsPiXyvziV6quXactrUwn198X6YNjem5JY2Ib 2EopSpgLhmyvJAP/TKtebMgktEIk20UwAAhOIu7w2rVi489ZtGGDAcQZXdufmPwLJevUhXbwcbUx6 q3Dp1pXg==; Original-Received: from [192.168.1.1] (helo=localhost.localdomain) by mail.fitzsim.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1p40oz-0005Nx-S1; Sat, 10 Dec 2022 09:27:22 -0500 In-Reply-To: <4d1810369df651d02ceeb522b8f05370@condition-alpha.com> (Alexander Adolf's message of "Sat, 10 Dec 2022 02:40:35 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250526 Archived-At: Hi Alexander, Alexander Adolf writes: > another lengthy explanation, for which apologies up front! OK, trimmed it down. > Thomas Fitzsimmons writes: > >> [...] >> OK, but then (to lengthen the conclusion) message--name-table ignores >> the default value of 'completion-styles' (or if it doesn't, it should), >> and so the default global value of 'completion-styles' should not have >> any bearing on any of these tests we're doing. Is that correct? >> [...] > > Yes, that's correct. > > message--name-table responds to the metadata action by returning a list > containing (category . email), which instructs the completion-at-point > machinery to ignore the global completion-styles variable, and instead > consult the completion-category-defaults and > completion-category-overrides alists for the completion style defined > under the 'email entry (if one exists). > > With an eye to fixing this bug, I think there are three plus one > scenarios to look at. [...] The scenario I'd like you to make work with a minimal patch is: Scenario 3+1 + (setq message-expand-name-standard-ui t). Did you try that? I'm pretty sure if you get that working you'll find that we don't need eudc-capf-complete in completion-at-point-functions (yet), since what was there will already do what eudc-capf-complete was trying to achieve. Basically, this whole part of the discussion I've been thinking in terms of "(setq message-expand-name-standard-ui t)". When message-expand-name-standard-ui is nil, I think we've determined that eudc-capf-complete's presence in completion-at-point-functions breaks EUDC functionality. Do you concur? If that's the case we should probably remove eudc-capf-complete from completion-at-point-functions for Emacs 29.1, since that would represent a regression. I now understand that the intent of the code that was there before we added eudc-capf-complete was: message-expand-name-standard-ui nil => use EUDC multi-selector UI message-expand-name-standard-ui t => use completion-at-point selector UI But the second case was already broken before we added eudc-capf-complete. I want to understand and fix that case. (I'm rushing responses here, I'll dedicate more time to real testing maybe tomorrow, but I'm hoping you'll beat me to it with a minimal patch :-)) Thanks, Thomas