From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.bugs Subject: bug#63711: 30.0.50; Crash in xdisp.c when it->string is 0x0 Date: Thu, 03 Aug 2023 13:40:19 -0400 Message-ID: References: <83ilcgn9ud.fsf@gnu.org> <835y8gmt3f.fsf@gnu.org> <834jo0mono.fsf@gnu.org> <83353kmmoq.fsf@gnu.org> <83zg5sl2mr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17854"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 63711-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 03 19:41:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qRcKB-0004Q0-39 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Aug 2023 19:41:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qRcJs-0000Tv-Q2; Thu, 03 Aug 2023 13:41:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRcJq-0000Td-IS for bug-gnu-emacs@gnu.org; Thu, 03 Aug 2023 13:41:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qRcJq-0002v2-4Z for bug-gnu-emacs@gnu.org; Thu, 03 Aug 2023 13:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qRcJp-0004Dq-W2 for bug-gnu-emacs@gnu.org; Thu, 03 Aug 2023 13:41:01 -0400 Resent-From: Thomas Fitzsimmons Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Aug 2023 17:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 63711 X-GNU-PR-Package: emacs Mail-Followup-To: 63711@debbugs.gnu.org, fitzsim@fitzsim.org, fitzsim@fitzsim.org Original-Received: via spool by 63711-done@debbugs.gnu.org id=D63711.169108442916174 (code D ref 63711); Thu, 03 Aug 2023 17:41:01 +0000 Original-Received: (at 63711-done) by debbugs.gnu.org; 3 Aug 2023 17:40:29 +0000 Original-Received: from localhost ([127.0.0.1]:52886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRcJI-0004Co-Tt for submit@debbugs.gnu.org; Thu, 03 Aug 2023 13:40:29 -0400 Original-Received: from mail.fitzsim.org ([69.165.165.189]:57702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRcJG-0004CW-Rw for 63711-done@debbugs.gnu.org; Thu, 03 Aug 2023 13:40:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fitzsim.org ; s=20220430; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nbPtpkstUTzuPjCAJ7vFtyEySnU8Ro9RrhVXGIVof6M=; b=JMtU2PxFxf8ngi+x79vFqDtt5T M39/tGZj7kzCD81bRCJsZmirCr5MroJ2dVQOtt/29TT8Zfr/rb1vNeXP0ql2wjyeB2oYKo23gVKbh sGm9L43J/p4dcp04tpiAh72QrrLIcUowrf995V15VEfmY/c8o4rgXbVsIxTkLH1/t2zU81ODd4pNQ Luei4Pp9Ar/ALpIiP0xTXc73j1oBppbRTO521Bjfp1I2sqV6xKAr+kdanZRPNiVngoa6KOFOfm6Ew 4af0StqXqMST/lCXrdNxMUYK1huzSh+Z7lzTvvulm+VAtgIHtHoWi73Wxt4B6FVQNlah+18HLoAuF i6fXafdw==; Original-Received: from [192.168.1.1] (helo=localhost.localdomain) by mail.fitzsim.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qRcJA-001FST-Kc; Thu, 03 Aug 2023 13:40:20 -0400 In-Reply-To: (Thomas Fitzsimmons's message of "Thu, 25 May 2023 14:12:23 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266614 Archived-At: Hi Eli, Thomas Fitzsimmons writes: > Eli Zaretskii writes: > >>> Cc: 63711@debbugs.gnu.org Date: Thu, 25 May 2023 18:54:13 >>> +0300 From: Eli Zaretskii >>> > > (gdb) p first_row_to_display->y >>> > $24 = 701 >>> > > (gdb) p window_text_bottom_y(w) >>> > $25 = 701 >>> And this also tells us that we are using the wrong glyph row, >>> I think: its Y coordinate is outside of the visible text area. >>> I think I understand the problem. Let me think about a >>> solution. >> >> I installed a fix on the emacs-29 branch, let's hope it fixes >> this. > > Thank you; I'm running a "-g -O0" build of emacs-29 tip now, > with GDB attached. I'll follow up in a month to confirm > success, provided there are no issues in the meantime. I haven't seen this particular crash in over a month, after having applied your patch; whereas before your patch I saw it at least twice, so it seems your patch fixed the issue. I'm closing this bug report. Thanks! Thomas