From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#35326: 26.1; vc-git-grep should pass -i like isearch Date: Tue, 25 Jun 2019 12:59:44 +0200 Message-ID: References: <87d0lheuhv.fsf@curie.anarc.at> <87wohcyob9.fsf@mail.linkov.net> <87v9wu4sqo.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="134280"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Antoine =?UTF-8?Q?Beaupr=C3=A9?= , 35326@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 25 13:00:24 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfjBY-000Ymp-A0 for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 13:00:24 +0200 Original-Received: from localhost ([::1]:58734 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfjBX-0001rp-8i for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 07:00:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45955) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfjBE-0001rS-Gp for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 07:00:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfjBD-0001DT-Ds for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 07:00:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45154) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfjBD-0001DH-A9 for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 07:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hfjBC-000711-Kj for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 07:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2019 11:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35326 X-GNU-PR-Package: emacs Original-Received: via spool by 35326-submit@debbugs.gnu.org id=B35326.156146039326932 (code B ref 35326); Tue, 25 Jun 2019 11:00:02 +0000 Original-Received: (at 35326) by debbugs.gnu.org; 25 Jun 2019 10:59:53 +0000 Original-Received: from localhost ([127.0.0.1]:58698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfjB3-00070I-98 for submit@debbugs.gnu.org; Tue, 25 Jun 2019 06:59:53 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:46694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfjB1-00070A-Fs for 35326@debbugs.gnu.org; Tue, 25 Jun 2019 06:59:52 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfjAu-00079w-Uh; Tue, 25 Jun 2019 12:59:47 +0200 In-Reply-To: <87v9wu4sqo.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 24 Jun 2019 23:45:51 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161331 Archived-At: Juri Linkov writes: > The confusion was caused by the original report mentioning `M-x grep'. > In fact, `M-x grep' doesn't expand the template. Only the following > commands expand the template: > > lgrep > rgrep > vc-git-grep > >> And should the vc-git version be more like grep or lgrep? > > vc-git-grep should be like other commands that expand the template, > i.e. lgrep and rgrep, that the patch in the original report > correctly achieves, so committing it would be an improvement > since `git grep' supports most of grep options, including --color, > -i and -w. Makes sense. I've now applied Antoine's patch to the trunk. > PS: Regarding -w that I proposed previously, I could create > a separate request, but here is a preliminary version: [...] > + (when grep-word-search > + (push "-w" opts)) Hm... I always just say \bfoo\b when I want the word-ish version, so I don't know whether this really warrants a new command. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no