From: Lars Ingebrigtsen <larsi@gnus.org>
To: phillip.lord@russet.org.uk
Cc: mah@everybody.org, 36598@debbugs.gnu.org,
Stefan Monnier <monnier@IRO.UMontreal.CA>
Subject: bug#36598: 26.1; (error "‘/tmp/emacs1000’ is not a safe directory because it is a symlink")
Date: Sun, 14 Jul 2019 13:44:05 +0200 [thread overview]
Message-ID: <m3v9w46dtm.fsf@gnus.org> (raw)
In-Reply-To: <44a502116d2c0568d120b7328913b26a@russet.org.uk> (phillip lord's message of "Sat, 13 Jul 2019 16:56:19 +0100")
phillip.lord@russet.org.uk writes:
> On 2019-07-13 15:45, Lars Ingebrigtsen wrote:
>> phillip.lord@russet.org.uk writes:
>>
>>> Launch emacs-27, start the server. Now launch emacs-26 and start the
>>> server with a different. The problem is that
>>> emacs-27 creates the file /tmp/emacs($PID) as a symlink, while
>>> emacs-26 doesn't like it.
>>>
>>> Probably created by
>>>
>>> b663c837249 (Stefan Monnier 2019-05-03 538)
>>
>> Could you post a backtrace for the "doesn't like it" case?
>
> Sure. It is Emacs-26 that errors.
>
> As far as I can see, this will only affect the edge case of someone
> running two versions of Emacs. I tend to do this (I run gnus in a
> standalone release emacs, and everything else in another emacs).
Commit b663c837249 (in May) which says "Cosmetic changes" is the one
that introduced this code?
(let ((olddir (or (getenv "TMPDIR") "/tmp")))
(when (and (equal dir (format "%s/emacs" (getenv "XDG_RUNTIME_DIR")))
(file-writable-p olddir))
(let ((link (format "%s/emacs%d" olddir (user-uid))))
(unless (file-directory-p link)
;; We're using the new location, so try and setup a symlink from
;; the old location, in case we want to use an old emacsclient.
;; FIXME: Check that it's safe to use!
(make-symbolic-link dir link t)))))
And instead of making things work with an old emacsclient, it breaks the
Emacs 26 emacsclient?
I may be reading the region history wrong, though.
Stefan, was this checked in by mistake?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-07-14 11:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 14:10 bug#36598: 26.1; (error "‘/tmp/emacs1000’ is not a safe directory because it is a symlink") Mark A. Hershberger
2019-07-13 4:38 ` Lars Ingebrigtsen
2019-07-13 14:30 ` phillip.lord
2019-07-13 14:45 ` Lars Ingebrigtsen
2019-07-13 15:56 ` phillip.lord
2019-07-14 1:43 ` Glenn Morris
2019-07-14 11:44 ` Lars Ingebrigtsen [this message]
2019-07-14 19:11 ` phillip.lord
2019-07-15 13:04 ` Stefan Monnier
2019-07-18 6:27 ` Eli Zaretskii
2019-07-23 12:07 ` Noam Postavsky
2019-07-13 12:46 ` Noam Postavsky
2019-07-13 13:06 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3v9w46dtm.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=36598@debbugs.gnu.org \
--cc=mah@everybody.org \
--cc=monnier@IRO.UMontreal.CA \
--cc=phillip.lord@russet.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).