unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#17890: 24.4.50; flyspell highlights ``doesn't''  incorrect
@ 2014-07-01  4:16 Leo Liu
  2014-07-01  6:25 ` Glenn Morris
  2014-07-01 13:03 ` Agustin Martin
  0 siblings, 2 replies; 14+ messages in thread
From: Leo Liu @ 2014-07-01  4:16 UTC (permalink / raw)
  To: 17890


As in the subject line.

Leo





^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#17890: 24.4.50; flyspell highlights ``doesn't''  incorrect
  2014-07-01  4:16 bug#17890: 24.4.50; flyspell highlights ``doesn't'' incorrect Leo Liu
@ 2014-07-01  6:25 ` Glenn Morris
  2014-07-01 11:13   ` Leo Liu
  2014-07-01 13:03 ` Agustin Martin
  1 sibling, 1 reply; 14+ messages in thread
From: Glenn Morris @ 2014-07-01  6:25 UTC (permalink / raw)
  To: Leo Liu; +Cc: 17890


Works for me.








^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#17890: 24.4.50; flyspell highlights ``doesn't''  incorrect
  2014-07-01  6:25 ` Glenn Morris
@ 2014-07-01 11:13   ` Leo Liu
  0 siblings, 0 replies; 14+ messages in thread
From: Leo Liu @ 2014-07-01 11:13 UTC (permalink / raw)
  To: Glenn Morris; +Cc: 17890

[-- Attachment #1: Type: text/plain, Size: 116 bytes --]

On 2014-07-01 02:25 -0400, Glenn Morris wrote:
> Works for me.

Odd. this is what I see in emacs -Q in CentOS 6.5:


[-- Attachment #2: flyspell.png --]
[-- Type: image/png, Size: 1651 bytes --]

[-- Attachment #3: Type: text/plain, Size: 5 bytes --]


Leo

^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#17890: 24.4.50; flyspell highlights ``doesn't''  incorrect
  2014-07-01  4:16 bug#17890: 24.4.50; flyspell highlights ``doesn't'' incorrect Leo Liu
  2014-07-01  6:25 ` Glenn Morris
@ 2014-07-01 13:03 ` Agustin Martin
  2014-07-01 13:32   ` Leo Liu
  1 sibling, 1 reply; 14+ messages in thread
From: Agustin Martin @ 2014-07-01 13:03 UTC (permalink / raw)
  To: Leo Liu; +Cc: 17890

On Tue, Jul 01, 2014 at 12:16:22PM +0800, Leo Liu wrote:
> 
> As in the subject line.

Which dictionary and spellchecker are you using?

There is a known problem with the typographically correct apostrophe
(“right single quotation mark” U+2019) (bug#17437). Does the problem
happen with the single quote or with that U+2019 apostrophe?

-- 
Agustin





^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#17890: 24.4.50; flyspell highlights ``doesn't''  incorrect
  2014-07-01 13:03 ` Agustin Martin
@ 2014-07-01 13:32   ` Leo Liu
  2014-07-01 15:43     ` Eli Zaretskii
  0 siblings, 1 reply; 14+ messages in thread
From: Leo Liu @ 2014-07-01 13:32 UTC (permalink / raw)
  To: Agustin Martin; +Cc: 17890

On 2014-07-01 15:03 +0200, Agustin Martin wrote:
> There is a known problem with the typographically correct apostrophe
> (“right single quotation mark” U+2019) (bug#17437). Does the problem
> happen with the single quote or with that U+2019 apostrophe?

They both give me the highlight. I am using emacs -Q and there is no
settings for dictionary unless it is based on locale. Mine is
en_GB.UTF-8.

CentOS with /usr/bin/hunspell
        - 24.3.1 compiled on 2013-12-09 doesn't have this bug
        - 24.3.92 compiled on 2014-06-30 and 24.4.50 (2014-06-29) both have this
          bug.

MacOSX with /usr/bin/aspell

24.3.92.1 doesn't have this bug.

Thanks,
Leo





^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#17890: 24.4.50; flyspell highlights ``doesn't''  incorrect
  2014-07-01 13:32   ` Leo Liu
@ 2014-07-01 15:43     ` Eli Zaretskii
  2014-07-01 16:23       ` Leo Liu
  0 siblings, 1 reply; 14+ messages in thread
From: Eli Zaretskii @ 2014-07-01 15:43 UTC (permalink / raw)
  To: Leo Liu; +Cc: 17890, agustin.martin

> From: Leo Liu <sdl.web@gmail.com>
> Date: Tue, 01 Jul 2014 21:32:21 +0800
> Cc: 17890@debbugs.gnu.org
> 
> On 2014-07-01 15:03 +0200, Agustin Martin wrote:
> > There is a known problem with the typographically correct apostrophe
> > (“right single quotation mark” U+2019) (bug#17437). Does the problem
> > happen with the single quote or with that U+2019 apostrophe?
> 
> They both give me the highlight. I am using emacs -Q and there is no
> settings for dictionary unless it is based on locale. Mine is
> en_GB.UTF-8.
> 
> CentOS with /usr/bin/hunspell
>         - 24.3.1 compiled on 2013-12-09 doesn't have this bug
>         - 24.3.92 compiled on 2014-06-30 and 24.4.50 (2014-06-29) both have this
>           bug.

I don't see this problem with Hunspell and today's trunk and emacs-24
branch.

If you invoke Hunspell outside of Emacs, does it accept "doesn't" as
correct spelling?  Here's what I get when I type "doesn't" into
Hunspell and hit RET:

  hunspell -a
  @(#) International Ispell Version 3.2.06 (but really Hunspell 1.3.2)
  doesn't
  *

The asterisk response means the word is correct.





^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#17890: 24.4.50; flyspell highlights ``doesn't''  incorrect
  2014-07-01 15:43     ` Eli Zaretskii
@ 2014-07-01 16:23       ` Leo Liu
  2014-07-01 16:49         ` Agustin Martin
  0 siblings, 1 reply; 14+ messages in thread
From: Leo Liu @ 2014-07-01 16:23 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 17890, agustin.martin

On 2014-07-01 18:43 +0300, Eli Zaretskii wrote:
>   hunspell -a
>   @(#) International Ispell Version 3.2.06 (but really Hunspell 1.3.2)
>   doesn't
>   *

I have

@(#) International Ispell Version 3.2.06 (but really Hunspell 1.2.8)
doesn't
& doesn 7 0: does, doest, does n, domes, dominoes, doe, doyen
*

Leo





^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#17890: 24.4.50; flyspell highlights ``doesn't''  incorrect
  2014-07-01 16:23       ` Leo Liu
@ 2014-07-01 16:49         ` Agustin Martin
  2014-07-02  7:33           ` Leo Liu
  0 siblings, 1 reply; 14+ messages in thread
From: Agustin Martin @ 2014-07-01 16:49 UTC (permalink / raw)
  To: Leo Liu, 17890

On Wed, Jul 02, 2014 at 12:23:42AM +0800, Leo Liu wrote:
> On 2014-07-01 18:43 +0300, Eli Zaretskii wrote:
> >   hunspell -a
> >   @(#) International Ispell Version 3.2.06 (but really Hunspell 1.3.2)
> >   doesn't
> >   *
>
> I have
>
> @(#) International Ispell Version 3.2.06 (but really Hunspell 1.2.8)
> doesn't
> & doesn 7 0: does, doest, does n, domes, dominoes, doe, doyen
> *

Does your dict .aff file contain a WORDCHARS section? Is apostrophe in it?
For instance, in my box (Sorry for the unixisms)

$ grep -i wordchars /usr/share/hunspell/en_{AU,GB,US}.aff
/usr/share/hunspell/en_GB.aff:WORDCHARS 0123456789'-.’
/usr/share/hunspell/en_US.aff:WORDCHARS 0123456789'

That is, australian dict does not have it, so I get

$ echo doesn\'t | hunspell -a -d en_GB
@(#) International Ispell Version 3.2.06 (but really Hunspell 1.3.3)
*

$ echo doesn\'t | hunspell -a -d en_US
@(#) International Ispell Version 3.2.06 (but really Hunspell 1.3.3)
*

But if I use the australian dict

$ echo doesn\'t | hunspell -a -d en_AU
@(#) International Ispell Version 3.2.06 (but really Hunspell 1.3.3)
& doesn 3 0: does, doest, does n
*

--
Agustin





^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#17890: 24.4.50; flyspell highlights ``doesn't''  incorrect
  2014-07-01 16:49         ` Agustin Martin
@ 2014-07-02  7:33           ` Leo Liu
  2014-07-02 14:45             ` Eli Zaretskii
  0 siblings, 1 reply; 14+ messages in thread
From: Leo Liu @ 2014-07-02  7:33 UTC (permalink / raw)
  To: 17890

On 2014-07-01 18:49 +0200, Agustin Martin wrote:
> Does your dict .aff file contain a WORDCHARS section? Is apostrophe in it?
> For instance, in my box (Sorry for the unixisms)

$ grep -i wordchars /usr/share/myspell/en_{AU,GB,US}.aff
/usr/share/myspell/en_US.aff:WORDCHARS 0123456789

i.e. en_GB.aff has no WORDCHARS.

Leo






^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#17890: 24.4.50; flyspell highlights ``doesn't''  incorrect
  2014-07-02  7:33           ` Leo Liu
@ 2014-07-02 14:45             ` Eli Zaretskii
  2014-07-02 15:23               ` Leo Liu
  0 siblings, 1 reply; 14+ messages in thread
From: Eli Zaretskii @ 2014-07-02 14:45 UTC (permalink / raw)
  To: Leo Liu; +Cc: 17890

> From: Leo Liu <sdl.web@gmail.com>
> Date: Wed, 02 Jul 2014 15:33:55 +0800
> 
> On 2014-07-01 18:49 +0200, Agustin Martin wrote:
> > Does your dict .aff file contain a WORDCHARS section? Is apostrophe in it?
> > For instance, in my box (Sorry for the unixisms)
> 
> $ grep -i wordchars /usr/share/myspell/en_{AU,GB,US}.aff
> /usr/share/myspell/en_US.aff:WORDCHARS 0123456789
> 
> i.e. en_GB.aff has no WORDCHARS.

So I guess the problem is with the Hunspell dictionary, not with
Emacs.  Perhaps try copying the WORDCHARS line from en_US.aff to
en_GB.aff, and see if that helps.





^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#17890: 24.4.50; flyspell highlights ``doesn't''  incorrect
  2014-07-02 14:45             ` Eli Zaretskii
@ 2014-07-02 15:23               ` Leo Liu
  2014-07-02 15:36                 ` Stefan Monnier
  0 siblings, 1 reply; 14+ messages in thread
From: Leo Liu @ 2014-07-02 15:23 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 17890

On 2014-07-02 17:45 +0300, Eli Zaretskii wrote:
> So I guess the problem is with the Hunspell dictionary, not with
> Emacs.  Perhaps try copying the WORDCHARS line from en_US.aff to
> en_GB.aff, and see if that helps.

Ineed. But what is odd is that emacs 24.3 on the same system doesn't
have this problem.

Leo





^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#17890: 24.4.50; flyspell highlights ``doesn't''  incorrect
  2014-07-02 15:23               ` Leo Liu
@ 2014-07-02 15:36                 ` Stefan Monnier
  2014-07-02 16:20                   ` Eli Zaretskii
  0 siblings, 1 reply; 14+ messages in thread
From: Stefan Monnier @ 2014-07-02 15:36 UTC (permalink / raw)
  To: Leo Liu; +Cc: 17890

>> So I guess the problem is with the Hunspell dictionary, not with
>> Emacs.  Perhaps try copying the WORDCHARS line from en_US.aff to
>> en_GB.aff, and see if that helps.
> Ineed. But what is odd is that emacs 24.3 on the same system doesn't
> have this problem.

Are you sure it also uses Hunspell, and with the same dictionary?


        Stefan





^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#17890: 24.4.50; flyspell highlights ``doesn't''  incorrect
  2014-07-02 15:36                 ` Stefan Monnier
@ 2014-07-02 16:20                   ` Eli Zaretskii
  2014-07-02 16:39                     ` Leo Liu
  0 siblings, 1 reply; 14+ messages in thread
From: Eli Zaretskii @ 2014-07-02 16:20 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: 17890, sdl.web

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Eli Zaretskii <eliz@gnu.org>,  17890@debbugs.gnu.org
> Date: Wed, 02 Jul 2014 11:36:26 -0400
> 
> >> So I guess the problem is with the Hunspell dictionary, not with
> >> Emacs.  Perhaps try copying the WORDCHARS line from en_US.aff to
> >> en_GB.aff, and see if that helps.
> > Ineed. But what is odd is that emacs 24.3 on the same system doesn't
> > have this problem.
> 
> Are you sure it also uses Hunspell, and with the same dictionary?

Didn't we make a change in 24.4 in ispell.el to take more info from
Hunspell and its dictionaries, instead of from ispell-dictionary-alist
etc.?  That could explain why it worked before.





^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#17890: 24.4.50; flyspell highlights ``doesn't''  incorrect
  2014-07-02 16:20                   ` Eli Zaretskii
@ 2014-07-02 16:39                     ` Leo Liu
  0 siblings, 0 replies; 14+ messages in thread
From: Leo Liu @ 2014-07-02 16:39 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 17890-done

On 2014-07-02 19:20 +0300, Eli Zaretskii wrote:
> Didn't we make a change in 24.4 in ispell.el to take more info from
> Hunspell and its dictionaries, instead of from ispell-dictionary-alist
> etc.?  That could explain why it worked before.

OK, I didn't know about this. Closing for now. Thanks, Leo





^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2014-07-02 16:39 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-01  4:16 bug#17890: 24.4.50; flyspell highlights ``doesn't'' incorrect Leo Liu
2014-07-01  6:25 ` Glenn Morris
2014-07-01 11:13   ` Leo Liu
2014-07-01 13:03 ` Agustin Martin
2014-07-01 13:32   ` Leo Liu
2014-07-01 15:43     ` Eli Zaretskii
2014-07-01 16:23       ` Leo Liu
2014-07-01 16:49         ` Agustin Martin
2014-07-02  7:33           ` Leo Liu
2014-07-02 14:45             ` Eli Zaretskii
2014-07-02 15:23               ` Leo Liu
2014-07-02 15:36                 ` Stefan Monnier
2014-07-02 16:20                   ` Eli Zaretskii
2014-07-02 16:39                     ` Leo Liu

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).