From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.bugs Subject: bug#22823: 25.0.50; Excorporate 0.7: incorrect number of parameters to EWS FindItem Date: Fri, 26 Feb 2016 20:39:02 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1456537231 18442 80.91.229.3 (27 Feb 2016 01:40:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 27 Feb 2016 01:40:31 +0000 (UTC) Cc: 22823@debbugs.gnu.org To: Aaron Jacobs Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 27 02:40:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aZTri-0003ul-5Y for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Feb 2016 02:40:14 +0100 Original-Received: from localhost ([::1]:52915 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZTre-0006TO-Cw for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Feb 2016 20:40:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZTrb-0006SM-Cy for bug-gnu-emacs@gnu.org; Fri, 26 Feb 2016 20:40:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZTrX-0006Ic-Cq for bug-gnu-emacs@gnu.org; Fri, 26 Feb 2016 20:40:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50905) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZTrX-0006IV-95 for bug-gnu-emacs@gnu.org; Fri, 26 Feb 2016 20:40:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aZTrX-0005YX-19 for bug-gnu-emacs@gnu.org; Fri, 26 Feb 2016 20:40:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thomas Fitzsimmons Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Feb 2016 01:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22823-submit@debbugs.gnu.org id=B22823.145653715121293 (code B ref 22823); Sat, 27 Feb 2016 01:40:02 +0000 Original-Received: (at 22823) by debbugs.gnu.org; 27 Feb 2016 01:39:11 +0000 Original-Received: from localhost ([127.0.0.1]:48032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZTqh-0005XN-7A for submit@debbugs.gnu.org; Fri, 26 Feb 2016 20:39:11 -0500 Original-Received: from mail-ig0-f177.google.com ([209.85.213.177]:35347) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZTqf-0005X9-6I for 22823@debbugs.gnu.org; Fri, 26 Feb 2016 20:39:09 -0500 Original-Received: by mail-ig0-f177.google.com with SMTP id hb3so45579976igb.0 for <22823@debbugs.gnu.org>; Fri, 26 Feb 2016 17:39:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=8XUIvdlaweT8XhLtsu68kEgjA9BB9pQTvuu6b6Ftxjw=; b=Crwiz45aJIE6BZrkERKX2kxfYkN/yEuGAzp0Y6NOHGpBpmB6JaaRaR3Xp78gMz79PH PhR7tGLFhLVZM865NdtfiwjG+w4Gjl8Wm0h6L59ubloVhjNOnxLrqjkPKb8kY3BiQ6o2 Wumc97bNZhKlg1zjYnLQX8q1hPSnPnByohUxgH8f+mZ3/7FxF1RmeAzNWXqj0tdbBPOT 7YwtTJL1aUbEbncBS967uPgeqhU/yuTnx+qfCatFfbJhsHoEWPCUY2+0UdHi+oen6DBW newHKCKuLz7MV3ODC9dWNtow3Q09/uL5748ueBaf1LLv52b6fTzJ7bhy8US7viz/pM/b VvXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=8XUIvdlaweT8XhLtsu68kEgjA9BB9pQTvuu6b6Ftxjw=; b=f3V0ep5kCYNNrlPqWJ+fXtm0po4gsm6RrcnkRDBvAtoB646fk1nEo3eSslLOewqjMF bxi8F1X4TTaLM4A0ugSygHH1jS34V/okaIAxm6apXPGMPf/6HgtM45ESImgAKL/LFT53 CMqA8nBYbK9E4wKYEY8m9BrhWg6JwZ3LAtGvaNXmJkKnrXStDCd7lrgxVUm9N3xWRsyw EeLUYSspF/ruJfcEsd+bSqsIyXcGygDQdbXiv+OM4LvF9/BWEG52unUi5p/GpETisKEd +sJ+8IRuoSEjwtqsCpFZFMm/QnPzIpurrbs5j6k1KoC4oQ4ASITUhYypMoOn1KFWo4Hw VcGA== X-Gm-Message-State: AD7BkJIHRawMDfxHJk6jx918e2hP2JgzpWfkir6uF4wmhb4ga1VGXR3qhSAA7KNPDiNe8w== X-Received: by 10.50.178.148 with SMTP id cy20mr687734igc.61.1456537143760; Fri, 26 Feb 2016 17:39:03 -0800 (PST) Original-Received: from hp-dv5t (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id ee9sm2498345igb.7.2016.02.26.17.39.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Feb 2016 17:39:03 -0800 (PST) In-Reply-To: (Aaron Jacobs's message of "Fri, 26 Feb 2016 17:38:11 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:113921 Archived-At: Hi Aaron, Aaron Jacobs writes: > This seems to be a bug in the `excorporate' package, version 0.7 as > released yesterday on GNU ELPA I believe. The author has indicated that > bugs should be reported using `M-x report-emacs-bug' (see release blog > post at https://www.fitzsim.org/blog/?p=313), and so here one is: > > I have been unable to retrieve calendar events from our Exchange server. > The relevant *fsm-debug* output for the event is as follows: > > Fri Feb 26 16:45:45 2016: exco--fsm [redacted] server version is > Exchange2010_SP1 > Fri Feb 26 16:47:36 2016: Sent "FindItem" to exco--fsm in state :retrieving-data > Fri Feb 26 16:47:36 2016: Error in exco--fsm/:retrieving-data: Wrong > number of parameters for FindItem: expected 5, got 6 > > This is my first time using the package. Autodiscovery was successful in > my case, as evidenced by the successful retrieval of the server version. > > Any advice on this matter would be appreciated. Thanks for the report. Can you try this patch (untested)? Thanks, Thomas --- ./excorporate.el~ +++ ./excorporate.el @@ -706,11 +706,14 @@ (defun exco-get-meetings-for-day (identifier month day year callback) (ParentFolderIds (DistinguishedFolderId (Id . "calendar")))) ;; Empty arguments. - ,@(let ((server-major-version - (string-to-number - (substring (exco-server-version identifier) 8 12)))) + ,@(let* ((server-version (exco-server-version identifier)) + (server-major-version (string-to-number + (substring server-version 8 12)))) (cond - ((<= server-major-version 2007) + ((or (<= server-major-version 2007) + ;; The FindItem argument count changed between + ;; Exchange2010_SP1 and Exchange2010_SP2. + (equal server-version "Exchange2010_SP1")) '(nil nil nil nil)) ((< server-major-version 2013) '(nil nil nil nil nil))