From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
To: Aaron Jacobs <atheriel@gmail.com>
Cc: 22823@debbugs.gnu.org
Subject: bug#22823: 25.0.50; Excorporate 0.7: incorrect number of parameters to EWS FindItem
Date: Fri, 26 Feb 2016 20:39:02 -0500 [thread overview]
Message-ID: <m3twkvq6dl.fsf@fitzsim.org> (raw)
In-Reply-To: <CAPncpoffguE0buuXP6VfX1C_aSPqrpsViVp59sLM=ujrmSBpFg@mail.gmail.com> (Aaron Jacobs's message of "Fri, 26 Feb 2016 17:38:11 -0500")
Hi Aaron,
Aaron Jacobs <atheriel@gmail.com> writes:
> This seems to be a bug in the `excorporate' package, version 0.7 as
> released yesterday on GNU ELPA I believe. The author has indicated that
> bugs should be reported using `M-x report-emacs-bug' (see release blog
> post at https://www.fitzsim.org/blog/?p=313), and so here one is:
>
> I have been unable to retrieve calendar events from our Exchange server.
> The relevant *fsm-debug* output for the event is as follows:
>
> Fri Feb 26 16:45:45 2016: exco--fsm [redacted] server version is
> Exchange2010_SP1
> Fri Feb 26 16:47:36 2016: Sent "FindItem" to exco--fsm in state :retrieving-data
> Fri Feb 26 16:47:36 2016: Error in exco--fsm/:retrieving-data: Wrong
> number of parameters for FindItem: expected 5, got 6
>
> This is my first time using the package. Autodiscovery was successful in
> my case, as evidenced by the successful retrieval of the server version.
>
> Any advice on this matter would be appreciated.
Thanks for the report. Can you try this patch (untested)?
Thanks,
Thomas
--- ./excorporate.el~
+++ ./excorporate.el
@@ -706,11 +706,14 @@ (defun exco-get-meetings-for-day (identifier month day year callback)
(ParentFolderIds
(DistinguishedFolderId (Id . "calendar"))))
;; Empty arguments.
- ,@(let ((server-major-version
- (string-to-number
- (substring (exco-server-version identifier) 8 12))))
+ ,@(let* ((server-version (exco-server-version identifier))
+ (server-major-version (string-to-number
+ (substring server-version 8 12))))
(cond
- ((<= server-major-version 2007)
+ ((or (<= server-major-version 2007)
+ ;; The FindItem argument count changed between
+ ;; Exchange2010_SP1 and Exchange2010_SP2.
+ (equal server-version "Exchange2010_SP1"))
'(nil nil nil nil))
((< server-major-version 2013)
'(nil nil nil nil nil))
next prev parent reply other threads:[~2016-02-27 1:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 22:38 bug#22823: 25.0.50; Excorporate 0.7: incorrect number of parameters to EWS FindItem Aaron Jacobs
2016-02-27 1:39 ` Thomas Fitzsimmons [this message]
2016-03-18 12:02 ` Thomas Fitzsimmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3twkvq6dl.fsf@fitzsim.org \
--to=fitzsim@fitzsim.org \
--cc=22823@debbugs.gnu.org \
--cc=atheriel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).