From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Liu Newsgroups: gmane.emacs.bugs Subject: bug#17549: 24.4.50; regression: url-insert-file-contents Date: Thu, 26 Jun 2014 12:03:19 +0800 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1403755469 8820 80.91.229.3 (26 Jun 2014 04:04:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 26 Jun 2014 04:04:29 +0000 (UTC) Cc: 17549@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 26 06:04:22 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X00v7-0000SP-4a for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Jun 2014 06:04:21 +0200 Original-Received: from localhost ([::1]:42129 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X00v6-0001V0-JB for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Jun 2014 00:04:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42244) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X00uw-0001Tp-Ip for bug-gnu-emacs@gnu.org; Thu, 26 Jun 2014 00:04:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X00up-0005S3-2o for bug-gnu-emacs@gnu.org; Thu, 26 Jun 2014 00:04:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41629) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X00uo-0005Rz-V9 for bug-gnu-emacs@gnu.org; Thu, 26 Jun 2014 00:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1X00uo-0006ab-CF for bug-gnu-emacs@gnu.org; Thu, 26 Jun 2014 00:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Leo Liu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Jun 2014 04:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17549 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17549-submit@debbugs.gnu.org id=B17549.140375541325275 (code B ref 17549); Thu, 26 Jun 2014 04:04:02 +0000 Original-Received: (at 17549) by debbugs.gnu.org; 26 Jun 2014 04:03:33 +0000 Original-Received: from localhost ([127.0.0.1]:32779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X00uL-0006Za-9N for submit@debbugs.gnu.org; Thu, 26 Jun 2014 00:03:33 -0400 Original-Received: from mail-pd0-f177.google.com ([209.85.192.177]:39271) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X00uH-0006ZD-BA for 17549@debbugs.gnu.org; Thu, 26 Jun 2014 00:03:30 -0400 Original-Received: by mail-pd0-f177.google.com with SMTP id y10so2466706pdj.8 for <17549@debbugs.gnu.org>; Wed, 25 Jun 2014 21:03:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=jLFIcprmKURWcmyqrMSvDUVjDan41LHp92xDDdFW3lk=; b=nzsw1HhOULuw5XsfaifTaVxdDRvgVLoYjlGL7dslfKcDQesh0wL5Edl4ztR+V8mQ6J nQ+2KK/LHSSA78GllvdAllxe+M31mDLt97q+kr2jJzlCW8x9NG4L8wNY70B/9LEdi8LP x1D7xwNlp8mutBvgkDZdHM8ekcVak+mWLuHAxOi1ldx7QY3SdOiHzEHi2eo6scURbvwG MTrqyIdS8qdmiUXCgaA5qUtcNSTClkEpAAEZBjtAeeA9vgc/K3a3jzObuYztepN0J+dS EuAi5S2rs/ZSXdZjoZkpw84qlMHSNUxDRMwefid5cZo4J4rac+ghvn6BPCMP573GhrDw c92A== X-Received: by 10.68.164.100 with SMTP id yp4mr17416344pbb.136.1403755403300; Wed, 25 Jun 2014 21:03:23 -0700 (PDT) Original-Received: from fortuna ([221.222.155.37]) by mx.google.com with ESMTPSA id yv7sm27829029pac.33.2014.06.25.21.03.21 for (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Wed, 25 Jun 2014 21:03:22 -0700 (PDT) Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAG1BMVEUAAAA9Cgm3Hx1WWFWA gn+WmJWsrqv4+vcCAwCRl2MkAAAAAXRSTlMAQObYZgAAAAFiS0dEAIgFHUgAAAAJcEhZcwAAAYoA AAGKATOXMFgAAAAHdElNRQfXAQwDNR+ZJmElAAABIklEQVQoz22SPW+DQAyGWUq65qasd9PNUSX4 AZHK2C1rJy5jpDS4IwRVup9dn7GNafpKIPPgzztXFSujqq1eM2n8h22oMkvxI/i9C97kRfMRUN55 dS3BrsAwBXUtMLAO4lryh8kTjOxKpQNniNxAgZOEe4bZwsDTFhKdqZRLNII4OQNHhEuq/RMkm6Cj TnnEA/fk0BorcYn5qA3oaeAxbaBOLrX+9G48NZ2Fzc2tzDM8Q+tMypEOqYHh8mAWaaK3U/cDMOT5 aMZMABgPXc7zPMs1A8DXO756GFJ/4fMEq47hTsAdn5avoxZ4ywl0c2w4Flu2Ybeyb3S+EqxX2DYA H8veJGEDTnHnrXvRaPyt+2kSfK6rfBZ2tUtfP/mR+pR6sX8BUZ/cDV7tvkoAAAAASUVORK5CYII= In-Reply-To: (Stefan Monnier's message of "Wed, 25 Jun 2014 22:38:37 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (CentOS 6.5) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:90829 Archived-At: Fixed in 24.4 On 2014-06-25 22:38 -0400, Stefan Monnier wrote: > IIUC the above just adds a "(when (bound-and-true-p > url-http-response-status)" wrapper around the existing code, right? > If so, it looks like a safe enough fix to install it in emacs-24. Yes, it should be safe enough. So bound-and-true-p make sure it is http/s. Secondly we don't re-do url-http-parse-response and rely on its point end at before the status-text. > This still doesn't look like The Right Way to do things in URL. > I think The Right Way would be for the url-http code to set some > backend-agnostic properties which url-handlers.el can then use. I agree. This bit of code is http specific and should be in the backend instead. I'll add a note for now. BTW, it might not be easy to invent similar semantics for other protocols though. Thanks, Leo