From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#35390: 26.2; [PATCH] `ls-lisp--dired', like `dired', should accept nil DIR-OR-LIST argument Date: Sun, 23 Jun 2019 19:25:15 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="33382"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35390@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 23 19:26:42 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hf6GH-0008Zn-43 for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Jun 2019 19:26:41 +0200 Original-Received: from localhost ([::1]:45940 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hf6GG-0002UR-4p for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Jun 2019 13:26:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39080) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hf6Fs-0002QZ-31 for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 13:26:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hf6Fo-0003Uf-9G for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 13:26:14 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40884) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hf6Fg-0003K9-GU for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 13:26:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hf6Fe-0007AN-HG for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 13:26:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Jun 2019 17:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35390 X-GNU-PR-Package: emacs Original-Received: via spool by 35390-submit@debbugs.gnu.org id=B35390.156131072227472 (code B ref 35390); Sun, 23 Jun 2019 17:26:02 +0000 Original-Received: (at 35390) by debbugs.gnu.org; 23 Jun 2019 17:25:22 +0000 Original-Received: from localhost ([127.0.0.1]:54425 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf6F0-000791-FF for submit@debbugs.gnu.org; Sun, 23 Jun 2019 13:25:22 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:44032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf6Ey-00078r-Ky for 35390@debbugs.gnu.org; Sun, 23 Jun 2019 13:25:20 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hf6Eu-0008QB-4A; Sun, 23 Jun 2019 19:25:18 +0200 In-Reply-To: (Drew Adams's message of "Tue, 23 Apr 2019 05:24:56 -0700 (PDT)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161137 Archived-At: Drew Adams writes: > The doc of command `dired' does not define the behavior if its DIRNAME > argument is not a string or a cons. `dired' just passes this arg to > `dired-noselect', and `dired-noselect' starts by doing this: > > (or dir-or-list (setq dir-or-list default-directory)) > > This means that `dired', via `dired-noselect', handles a nil value for > DIRNAME by using the value of `default-directory' (a string). > > `ls-lisp--dired' should do the same - it is a stand-in for `dired'. Makes sense. > Currently it raises an error if passed nil as the directory. It would > make sense to add this at the beginning of `ls-lisp--dired' (just after > the `interactive' spec): > > (unless dir-or-list (setq dir-or-list default-directory)) > > That's the "patch" - just add that line as indicated. In the future, could you submit code changes as real patches, with changelog entries on the normal format? Thanks. I've now done this change manually, though. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no