unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 35390@debbugs.gnu.org
Subject: bug#35390: 26.2; [PATCH] `ls-lisp--dired', like `dired', should accept nil DIR-OR-LIST argument
Date: Sun, 23 Jun 2019 19:25:15 +0200	[thread overview]
Message-ID: <m3sgs05i4k.fsf@gnus.org> (raw)
In-Reply-To: <c088a156-46ad-4e9a-a1da-5821f30e0cc3@default> (Drew Adams's message of "Tue, 23 Apr 2019 05:24:56 -0700 (PDT)")

Drew Adams <drew.adams@oracle.com> writes:

> The doc of command `dired' does not define the behavior if its DIRNAME
> argument is not a string or a cons.  `dired' just passes this arg to
> `dired-noselect', and `dired-noselect' starts by doing this:
>
>  (or dir-or-list (setq dir-or-list default-directory))
>
> This means that `dired', via `dired-noselect', handles a nil value for
> DIRNAME by using the value of `default-directory' (a string).
>
> `ls-lisp--dired' should do the same - it is a stand-in for `dired'.

Makes sense.

> Currently it raises an error if passed nil as the directory.  It would
> make sense to add this at the beginning of `ls-lisp--dired' (just after
> the `interactive' spec):
>
>  (unless dir-or-list (setq dir-or-list  default-directory))
>
> That's the "patch" - just add that line as indicated.

In the future, could you submit code changes as real patches, with
changelog entries on the normal format?  Thanks.

I've now done this change manually, though.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





      reply	other threads:[~2019-06-23 17:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-23 12:24 bug#35390: 26.2; [PATCH] `ls-lisp--dired', like `dired', should accept nil DIR-OR-LIST argument Drew Adams
2019-06-23 17:25 ` Lars Ingebrigtsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3sgs05i4k.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=35390@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).