bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[jidanni]

Please make sure v q removes the buffer for JPGs just like it does for
text files, in dired. Yes this is a duplicate report.
You will notice all the JPGs you viewed still sitting there in your
buffer list.

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Lars Magne Ingebrigtsen]

jidanni@jidanni.org writes:

> Please make sure v q removes the buffer for JPGs just like it does for
> text files, in dired. Yes this is a duplicate report.  You will notice
> all the JPGs you viewed still sitting there in your buffer list.

The problem is this:

  (if (eq (with-current-buffer buffer
	    (get major-mode 'mode-class))
	  'special)
      (progn
	(switch-to-buffer buffer)
	(message "Not using View mode because the major mode is special"))


`view-mode' refuses to switch itself on if the mode is special, and
Image mode is apparently special.

Is there any particular reason for `view-mode' to refuse to switch
itself on in special modes?
        
-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Chong Yidong]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> `view-mode' refuses to switch itself on if the mode is special, and
> Image mode is apparently special.
>
> Is there any particular reason for `view-mode' to refuse to switch
> itself on in special modes?

How does it make sense to visit image buffers in view mode?

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[jidanni]

>>>>> "CY" == Chong Yidong <cyd@stupidchicken.com> writes:
CY> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

>> `view-mode' refuses to switch itself on if the mode is special, and
>> Image mode is apparently special.
>> 
>> Is there any particular reason for `view-mode' to refuse to switch
>> itself on in special modes?

CY> How does it make sense to visit image buffers in view mode?

So then the buffer will disappear when we hit "q"!

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Stefan Monnier]

>>> `view-mode' refuses to switch itself on if the mode is special, and
>>> Image mode is apparently special.
>>> 
>>> Is there any particular reason for `view-mode' to refuse to switch
>>> itself on in special modes?

CY> How does it make sense to visit image buffers in view mode?

> So then the buffer will disappear when we hit "q"!

That should happen even without using view-mode.


        Stefan

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[jidanni]

>>>>> "SM" == Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>>> `view-mode' refuses to switch itself on if the mode is special, and
>>>> Image mode is apparently special.
>>>> 
>>>> Is there any particular reason for `view-mode' to refuse to switch
>>>> itself on in special modes?

CY> How does it make sense to visit image buffers in view mode?

>> So then the buffer will disappear when we hit "q"!

SM> That should happen even without using view-mode.

Well it doesn't in both cases.
$ emacs -q a_directory_full_of_jpgs
v q C-x C-b SPC <return> q C-x C-b
Note how the picture entries are both still disgustingly hanging around
there on the C-x C-b table.

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Lars Magne Ingebrigtsen]

jidanni@jidanni.org writes:

> Well it doesn't in both cases.
> $ emacs -q a_directory_full_of_jpgs
> v q C-x C-b SPC <return> q C-x C-b
> Note how the picture entries are both still disgustingly hanging around
> there on the C-x C-b table.

If having `view-mode' not being able to work in `special' modes (I don't
know why that is, but there's probably a reason?), then the `v' Dired
command could just bind the `q' command explicitly in all `special'
modes.

That is, it'd start the a tiny `dired-view-mode' in `special' modes,
where the only command it would bind would be `q'.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Chong Yidong]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> If having `view-mode' not being able to work in `special' modes (I don't
> know why that is, but there's probably a reason?), then the `v' Dired
> command could just bind the `q' command explicitly in all `special'
> modes.
>
> That is, it'd start the a tiny `dired-view-mode' in `special' modes,
> where the only command it would bind would be `q'.

I prefer a more limited fix: bind `q' in Image mode to a command that
kills the buffer.  Better still, add an option to bury instead of kill.

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Lars Magne Ingebrigtsen]

Chong Yidong <cyd@stupidchicken.com> writes:

> I prefer a more limited fix: bind `q' in Image mode to a command that
> kills the buffer.  Better still, add an option to bury instead of kill.

Isn't burying a buffer the more common "quit"-like action in most modes?
I guess there's no real standard for that, so having `q' be
`kill-buffer' sounds OK to me.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Stefan Monnier]

>> I prefer a more limited fix: bind `q' in Image mode to a command that
>> kills the buffer.  Better still, add an option to bury instead of kill.

> Isn't burying a buffer the more common "quit"-like action in most modes?
> I guess there's no real standard for that, so having `q' be
> `kill-buffer' sounds OK to me.

AFAIK, usually `q' is bound to `quit-window'.


        Stefan

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Lars Magne Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> Isn't burying a buffer the more common "quit"-like action in most modes?
>> I guess there's no real standard for that, so having `q' be
>> `kill-buffer' sounds OK to me.
>
> AFAIK, usually `q' is bound to `quit-window'.

Which hides the window and buries the buffer.  But doesn't kill it, like
`view-mode' does.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Stefan Monnier]

>>> Isn't burying a buffer the more common "quit"-like action in most modes?
>>> I guess there's no real standard for that, so having `q' be
>>> `kill-buffer' sounds OK to me.
>> AFAIK, usually `q' is bound to `quit-window'.
> Which hides the window and buries the buffer.  But doesn't kill it, like
> `view-mode' does.

C-u q does.  And in any case, I was just describing the usual binding
used in special-modes, regardless of whether it behaves like view-mode.
FWIW, I find view-mode's behavior generally odd and hard to predict (as
a user), so I don't think it's crucial to always follow its lead.


        Stefan

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Lars Magne Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> C-u q does.  And in any case, I was just describing the usual binding
> used in special-modes, regardless of whether it behaves like view-mode.
> FWIW, I find view-mode's behavior generally odd and hard to predict (as
> a user), so I don't think it's crucial to always follow its lead.

No, but it would be nice if `v' in dired always did the same thing with
`q'.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Stefan Monnier]

>> C-u q does.  And in any case, I was just describing the usual binding
>> used in special-modes, regardless of whether it behaves like view-mode.
>> FWIW, I find view-mode's behavior generally odd and hard to predict (as
>> a user), so I don't think it's crucial to always follow its lead.
> No, but it would be nice if `v' in dired always did the same thing
> with `q'.

Why?


        Stefan

bug#6954: all viewed images left sitting in buffer-list

[jidanni]

v runs the command dired-view-file
When run on a normal file, a subsequent q is
q runs the command View-quit

But when run upon a .jpg file,
a subsequent q is
q runs the command quit-window

Which leaves the buffer sitting around in the buffer-list!
C-x C-b runs the command list-buffers

emacs-version "24.0.50.1"

I don't know how you will wish to solve this problem. But please don't
ask the user to do C-u q when finished viewing an image vs. q for when
finished viewing a text file.

bug#6954: bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[jidanni]

After years of using v q SPC v q SPC v q SPC to view photos in dired,
you fellows latest tinkering has really thrown a monkey wrench into my life.
Though I even in my previous letter promised to learn the new ways,
I am afraid that is no longer possible.
Therefore perhaps someone can provide me with a doctors prescription I
can put into .emacs, that would make v and q act like the good old days.

bug#6954: bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[jidanni]

>>>>> "SM" == Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>> C-u q does.  And in any case, I was just describing the usual binding
>>> used in special-modes, regardless of whether it behaves like view-mode.
>>> FWIW, I find view-mode's behavior generally odd and hard to predict (as
>>> a user), so I don't think it's crucial to always follow its lead.
>> No, but it would be nice if `v' in dired always did the same thing
>> with `q'.

SM> Why?

Because when we hit q on a text file, it neatly disappears (from the
buffer list), whereas hitting q on an image file oddly leaves it sitting
on the buffer list, one look at which would shock one off ones chair --
my god how did I stuff emacs memory with all those images?

bug#6954: bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[jidanni]

>>>>> "CY" == Chong Yidong <cyd@stupidchicken.com> writes:
CY> I don't see why it's important for `q' to do exactly the same thing in

Well as long as there is a way for me the user to put something in his
.emacs file to "make sure v q removes the buffer for JPGs just like it
does for other files". Also like xli(1)'s q too.

bug#6954: bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Lars Magne Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>> C-u q does.  And in any case, I was just describing the usual binding
>>> used in special-modes, regardless of whether it behaves like view-mode.
>>> FWIW, I find view-mode's behavior generally odd and hard to predict (as
>>> a user), so I don't think it's crucial to always follow its lead.
>> No, but it would be nice if `v' in dired always did the same thing
>> with `q'.
>
> Why?

If the user uses `v', they probably expects to see the article in view
mode.  If they didn't, they would have hit RET instead.

One of the things that `v' gives you is `q'.

QED.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[jidanni]

Now broken even more in
emacs-snapshot:
  Installed: 1:20110705-1

$ emacs -Q a_directory_with_images
type v on an image
type q
Now guess what we are looking at?
Back to the directory?
No.
You folks buried it!
And the image is also buried, not killed, too!

bug#6954: bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Lars Magne Ingebrigtsen]

jidanni@jidanni.org writes:

> Now broken even more in
> emacs-snapshot:
>   Installed: 1:20110705-1
>
> $ emacs -Q a_directory_with_images
> type v on an image
> type q
> Now guess what we are looking at?
> Back to the directory?
> No.
> You folks buried it!
> And the image is also buried, not killed, too!

I don't think anything has actually changed with the bug you reported,
but yeah, wow.  `q' popped to a totally different buffer than I
expected.

Is this a part of the switch-to-buffer/window thingie rework?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Lars Magne Ingebrigtsen]

jidanni@jidanni.org writes:

> Now broken even more in
> emacs-snapshot:
>   Installed: 1:20110705-1
>
> $ emacs -Q a_directory_with_images
> type v on an image
> type q
> Now guess what we are looking at?
> Back to the directory?
> No.
> You folks buried it!
> And the image is also buried, not killed, too!

I don't think anything has actually changed with the bug you reported,
but yeah, wow.  `q' popped to a totally different buffer than I
expected.

Is this a part of the switch-to-buffer/window thingie rework?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#8615: bug#6954: bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Christoph Scholtes]

On 7/15/2011 3:30 PM, Lars Magne Ingebrigtsen wrote:

>> $ emacs -Q a_directory_with_images
>> type v on an image
>> type q
>> Now guess what we are looking at?
>> Back to the directory?
>> No.
>> You folks buried it!
>> And the image is also buried, not killed, too!
>
> I don't think anything has actually changed with the bug you reported,
> but yeah, wow.  `q' popped to a totally different buffer than I
> expected.
>
> Is this a part of the switch-to-buffer/window thingie rework?

I can reproduce the described behavior with build from a couple of 
minutes ago.

According to describe-key, the `q' key is bound to quit-window. The `q' 
key should bury the buffer (image). `z' will kill it.

All of this is consistent with image-mode using special-mode map, which 
maps `q' to quit-window and `z' to kill buffer.

Not sure though, why `q' does not switch back to the dired buffer. It 
seems to put the dired buffer second in the buffer list and switch to 
the buffer which is first in the list.

Christoph

bug#6954: bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Christoph Scholtes]

On 7/15/2011 3:30 PM, Lars Magne Ingebrigtsen wrote:

>> $ emacs -Q a_directory_with_images
>> type v on an image
>> type q
>> Now guess what we are looking at?
>> Back to the directory?
>> No.
>> You folks buried it!
>> And the image is also buried, not killed, too!
>
> I don't think anything has actually changed with the bug you reported,
> but yeah, wow.  `q' popped to a totally different buffer than I
> expected.
>
> Is this a part of the switch-to-buffer/window thingie rework?

I can reproduce the described behavior with build from a couple of 
minutes ago.

According to describe-key, the `q' key is bound to quit-window. The `q' 
key should bury the buffer (image). `z' will kill it.

All of this is consistent with image-mode using special-mode map, which 
maps `q' to quit-window and `z' to kill buffer.

Not sure though, why `q' does not switch back to the dired buffer. It 
seems to put the dired buffer second in the buffer list and switch to 
the buffer which is first in the list.

Christoph

bug#6954: bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[martin rudalics]

 >> $ emacs -Q a_directory_with_images
 >> type v on an image
 >> type q
 >> Now guess what we are looking at?
 >> Back to the directory?
 >> No.
 >> You folks buried it!
 >> And the image is also buried, not killed, too!
 >
 > I don't think anything has actually changed with the bug you reported,
 > but yeah, wow.  `q' popped to a totally different buffer than I
 > expected.
 >
 > Is this a part of the switch-to-buffer/window thingie rework?

It is ;-)  As a matter of fact it's the combination of

(1) a bug in Emacs 23's `pop-to-buffer' causing it to _not_ reselect the
     selected window when it's used for displaying the buffer, and

(2) a recent change which had `find-file' use `pop-to-buffer' instead of
     `set-window-buffer'.

Hopefully fixed now (the bug in Emacs 23 remains unfixed since noone has
complained about it yet - after all `pop-to-buffer' was supposed to use
any but the selected window).

Thanks for complaining, martin

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[martin rudalics]

 >> $ emacs -Q a_directory_with_images
 >> type v on an image
 >> type q
 >> Now guess what we are looking at?
 >> Back to the directory?
 >> No.
 >> You folks buried it!
 >> And the image is also buried, not killed, too!
 >
 > I don't think anything has actually changed with the bug you reported,
 > but yeah, wow.  `q' popped to a totally different buffer than I
 > expected.
 >
 > Is this a part of the switch-to-buffer/window thingie rework?

It is ;-)  As a matter of fact it's the combination of

(1) a bug in Emacs 23's `pop-to-buffer' causing it to _not_ reselect the
     selected window when it's used for displaying the buffer, and

(2) a recent change which had `find-file' use `pop-to-buffer' instead of
     `set-window-buffer'.

Hopefully fixed now (the bug in Emacs 23 remains unfixed since noone has
complained about it yet - after all `pop-to-buffer' was supposed to use
any but the selected window).

Thanks for complaining, martin

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Christoph Scholtes]

On 7/16/2011 7:11 AM, martin rudalics wrote:

> Hopefully fixed now (the bug in Emacs 23 remains unfixed since noone has
> complained about it yet - after all `pop-to-buffer' was supposed to use
> any but the selected window).

Now it behaves correctly on `q' and switches back to the dired buffer. 
Thanks for the fix.

However, the original issue reported is still not resolved. `q' buries 
the buffer and does not kill it, like it used to before special-mode was 
introduced.

Maybe Stefan or Chong can comment on whether this is to be regarded an 
issue or not.

I still think view-mode and special-mode need to be aligned in terms of 
these common actions.

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Lars Magne Ingebrigtsen]

Christoph Scholtes <cschol2112@googlemail.com> writes:

> I still think view-mode and special-mode need to be aligned in terms
> of these common actions.

What's the reason `view-mode' is inhibited for `special' modes?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Stefan Monnier]

>> I still think view-mode and special-mode need to be aligned in terms
>> of these common actions.
> What's the reason `view-mode' is inhibited for `special' modes?

I think the problem here is that the notion of "special mode" is not
well defined.  Until recently I think it only applied to non-file modes,
so did not affect dired's `v'.

I'd tend to think that view-mode's refusal to run in special modes
should not apply to files.


        Stefan

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Lars Magne Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> I'd tend to think that view-mode's refusal to run in special modes
> should not apply to files.

I've now altered `view-mode' to allow running in `special' modes that
are visiting a file.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Juri Linkov]

This is a regression.  It makes special modes `image-mode', `archive-mode'
unusable when visited from dired because their keybindings are clobbered
with view's keybindings.

I propose to remove this regression by reverting revno#105285.
The original request was for something different.  The OP asked
for killing the image buffer with `q', not visiting it with `view-mode'.

There are different ways to do this properly.  One is to rebind `q'
to `kill-this-buffer' in `image-mode' (inherited from `special-mode-map').
This change will affect all users.

Or to document a way to do this individually with a customization like Stefan
demonstrated in http://lists.gnu.org/archive/html/emacs-devel/2011-10/msg01136.html

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Lars Magne Ingebrigtsen]

Juri Linkov <juri@jurta.org> writes:

> This is a regression.  It makes special modes `image-mode', `archive-mode'
> unusable when visited from dired because their keybindings are clobbered
> with view's keybindings.

That only happens if you use the `v' command instead of the ordinary
`RET' command to view these files, right?

If you're using the `v' command, you presumably want to see the files
using `view-mode', since that's what that command is supposed to do.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Juri Linkov]

>> This is a regression.  It makes special modes `image-mode', `archive-mode'
>> unusable when visited from dired because their keybindings are clobbered
>> with view's keybindings.
>
> That only happens if you use the `v' command instead of the ordinary
> `RET' command to view these files, right?
>
> If you're using the `v' command, you presumably want to see the files
> using `view-mode', since that's what that command is supposed to do.

Like jidanni, I used to type `v q SPC v q SPC v q SPC' to browse files in Dired.
Now when images and archives are viewed with `v', keybindings overridden
by view.el are useless (except `q'), so functionality of these modes is broken.

It's a pain to be careful of using the right key for different kind of files:
to type `RET' to view images and archives, or to type `v' to view other files.

bug#6954: bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Christoph Scholtes]

On 7/16/2011 7:11 AM, martin rudalics wrote:

> Hopefully fixed now (the bug in Emacs 23 remains unfixed since noone has
> complained about it yet - after all `pop-to-buffer' was supposed to use
> any but the selected window).

Now it behaves correctly on `q' and switches back to the dired buffer. 
Thanks for the fix.

However, the original issue reported is still not resolved. `q' buries 
the buffer and does not kill it, like it used to before special-mode was 
introduced.

Maybe Stefan or Chong can comment on whether this is to be regarded an 
issue or not.

I still think view-mode and special-mode need to be aligned in terms of 
these common actions.

bug#8615: bug#6954: bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[jidanni]

All I am asking is for the same actions for the same keys.
I'm willing to learn the new keys, as long as they are consistent.
Currently q and z act differently, depending on if one is viewing a
image vs. non image.

Even though both I got to via a "v" in dired.

CS> Not sure though, why `q' does not switch back to the dired buffer. It
CS> seems to put the dired buffer second in the buffer list and switch to
CS> the buffer which is first in the list.

That needs to be fixed too. That started last week.

bug#6954: bug#8615: bug#6954: bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Christoph Scholtes]

On 7/15/2011 5:22 PM, jidanni@jidanni.org wrote:
> All I am asking is for the same actions for the same keys.
> I'm willing to learn the new keys, as long as they are consistent.
> Currently q and z act differently, depending on if one is viewing a
> image vs. non image.
>
> Even though both I got to via a "v" in dired.

Most other files (all?) are opened in view-mode, which binds `q' and `z' 
differently. I think view-mode and special-mode need to agree on how to 
map certain keys, e.g. `q', i.e. common operations like quit or 
kill-buffer. Either by deriving view-mode from special-mode or matching 
the maps.

bug#8615: bug#6954: bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Christoph Scholtes]

On 7/15/2011 5:22 PM, jidanni@jidanni.org wrote:
> All I am asking is for the same actions for the same keys.
> I'm willing to learn the new keys, as long as they are consistent.
> Currently q and z act differently, depending on if one is viewing a
> image vs. non image.
>
> Even though both I got to via a "v" in dired.

Most other files (all?) are opened in view-mode, which binds `q' and `z' 
differently. I think view-mode and special-mode need to agree on how to 
map certain keys, e.g. `q', i.e. common operations like quit or 
kill-buffer. Either by deriving view-mode from special-mode or matching 
the maps.

bug#6954: bug#8615: bug#6954: bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Lars Magne Ingebrigtsen]

Christoph Scholtes <cschol2112@googlemail.com> writes:

> Most other files (all?) are opened in view-mode, which binds `q' and
> z' differently. I think view-mode and special-mode need to agree on
> how to map certain keys, e.g. `q', i.e. common operations like quit or
> kill-buffer. Either by deriving view-mode from special-mode or
> matching the maps.

It's not a view-mode issue.

Open up a directory in dired.  Select a sub-directory.  Type `q'.  End
up in a buffer that wasn't the one you started in.

So `quit-window' and friends have apparently gotten a bit confused in
the last couple of days.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#8615: bug#6954: bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Lars Magne Ingebrigtsen]

Christoph Scholtes <cschol2112@googlemail.com> writes:

> Most other files (all?) are opened in view-mode, which binds `q' and
> z' differently. I think view-mode and special-mode need to agree on
> how to map certain keys, e.g. `q', i.e. common operations like quit or
> kill-buffer. Either by deriving view-mode from special-mode or
> matching the maps.

It's not a view-mode issue.

Open up a directory in dired.  Select a sub-directory.  Type `q'.  End
up in a buffer that wasn't the one you started in.

So `quit-window' and friends have apparently gotten a bit confused in
the last couple of days.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#8615: bug#6954: bug#8615: bug#6954: bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Christoph Scholtes]

On 7/15/2011 5:38 PM, Lars Magne Ingebrigtsen wrote:
> Christoph Scholtes<cschol2112@googlemail.com>  writes:
>
>> Most other files (all?) are opened in view-mode, which binds `q' and
>> z' differently. I think view-mode and special-mode need to agree on
>> how to map certain keys, e.g. `q', i.e. common operations like quit or
>> kill-buffer. Either by deriving view-mode from special-mode or
>> matching the maps.
>
> It's not a view-mode issue.

IMO, it is very much a view-mode issue. The original issue description 
states that v q should remove the image buffer, i.e. kill it. It will 
never do this, since image-mode uses special mode map, and special-mode 
buries on `q', whereas other modes use view-mode. view-mode does kill 
the buffer on q, but I believe exit-action has to be set correctly.

> Open up a directory in dired.  Select a sub-directory.  Type `q'.  End
> up in a buffer that wasn't the one you started in.
>
> So `quit-window' and friends have apparently gotten a bit confused in
> the last couple of days.

This is a separate issue and needs to be fixed.

bug#6954: bug#8615: bug#6954: bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Christoph Scholtes]

On 7/15/2011 5:38 PM, Lars Magne Ingebrigtsen wrote:
> Christoph Scholtes<cschol2112@googlemail.com>  writes:
>
>> Most other files (all?) are opened in view-mode, which binds `q' and
>> z' differently. I think view-mode and special-mode need to agree on
>> how to map certain keys, e.g. `q', i.e. common operations like quit or
>> kill-buffer. Either by deriving view-mode from special-mode or
>> matching the maps.
>
> It's not a view-mode issue.

IMO, it is very much a view-mode issue. The original issue description 
states that v q should remove the image buffer, i.e. kill it. It will 
never do this, since image-mode uses special mode map, and special-mode 
buries on `q', whereas other modes use view-mode. view-mode does kill 
the buffer on q, but I believe exit-action has to be set correctly.

> Open up a directory in dired.  Select a sub-directory.  Type `q'.  End
> up in a buffer that wasn't the one you started in.
>
> So `quit-window' and friends have apparently gotten a bit confused in
> the last couple of days.

This is a separate issue and needs to be fixed.

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[jidanni]

>>>>> "JL" == Juri Linkov <juri@jurta.org> writes:

JL> Like jidanni, I used to type `v q SPC v q SPC v q SPC' to browse files in Dired.
JL> Now when images and archives are viewed with `v', keybindings overridden
JL> by view.el are useless (except `q'), so functionality of these modes is broken.

JL> It's a pain to be careful of using the right key for different kind of files:
JL> to type `RET' to view images and archives, or to type `v' to view other files.

No need, everything seems to be working fine now with emacs -q in
Package: emacs-snapshot Version: 1:20111121-1

The only things left in the *Buffer List* after lots of v q SPC v q SPC
are directories... but I guess there is some reason to keep them laying around?

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Juri Linkov]

> JL> Like jidanni, I used to type `v q SPC v q SPC v q SPC' to browse files in Dired.
> JL> Now when images and archives are viewed with `v', keybindings overridden
> JL> by view.el are useless (except `q'), so functionality of these modes is broken.
>
> JL> It's a pain to be careful of using the right key for different kind of files:
> JL> to type `RET' to view images and archives, or to type `v' to view other files.
>
> No need, everything seems to be working fine now with emacs -q in
> Package: emacs-snapshot Version: 1:20111121-1

Do you view images with `v q SPC v q SPC'?  When viewing images with
`v', image-mode is broken because image viewing keybindings are rebound
to functions of view.el.

Perhaps you visit only small images that fit into the screen,
so you don't need to use image-mode keys other than `q'.
But when images are larger and you need to scroll them, you are screwed.

> The only things left in the *Buffer List* after lots of v q SPC v q SPC
> are directories... but I guess there is some reason to keep them laying around?

I have the same problem with directories, so I have in .emacs:

  (defun quit-window-kill-buffer ()
    "Quit WINDOW and kill its buffer."
    (interactive)
    (quit-window t))
  (define-key dired-mode-map "q" 'quit-window-kill-buffer)

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Chong Yidong]

Juri Linkov <juri@jurta.org> writes:

> Do you view images with `v q SPC v q SPC'?  When viewing images with
> `v', image-mode is broken because image viewing keybindings are rebound
> to functions of view.el.

Which keybindings are you referring to?  Just the `q' (quit-window vs
View-quit) key, or more?

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Juri Linkov]

>> Do you view images with `v q SPC v q SPC'?  When viewing images with
>> `v', image-mode is broken because image viewing keybindings are rebound
>> to functions of view.el.
>
> Which keybindings are you referring to?  Just the `q' (quit-window vs
> View-quit) key, or more?

I mean keybindings

  RET		image-toggle-animation
  SPC		image-scroll-up
  DEL		image-scroll-down

vs

  RET		View-scroll-line-forward
  SPC		View-scroll-page-forward
  DEL		View-scroll-page-backward

As for `q', I don't understand why `quit-window' should differ from `View-quit'.
Why does `q' bound to `View-quit' kill the buffer, while `quit-window'
bound to `q' doesn't?

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Lars Magne Ingebrigtsen]

Juri Linkov <juri@jurta.org> writes:

> As for `q', I don't understand why `quit-window' should differ from
> `View-quit'.  Why does `q' bound to `View-quit' kill the buffer, while
> `quit-window' bound to `q' doesn't?

I thought the point of "view mode" was to give you a mode for, well,
quick viewing.  In that context it makes perfect sense for `q' to kill
the buffer.  If you're using a regular non-view mode, having `q' kill
the buffer would be odd.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Stefan Monnier]

>> As for `q', I don't understand why `quit-window' should differ from
>> `View-quit'.  Why does `q' bound to `View-quit' kill the buffer, while
>> `quit-window' bound to `q' doesn't?

> I thought the point of "view mode" was to give you a mode for, well,
> quick viewing.  In that context it makes perfect sense for `q' to kill
> the buffer.  If you're using a regular non-view mode, having `q' kill
> the buffer would be odd.

Using "view mode" as the deciding factor is wrong.  The "quick viewing"
meaning is bound to the use of "v" is dired, not to the use of
view-mode.  So maybe the right solution is to make view-mode use
quit-window, change quit-window so it obeys a `quit-window-kills'
variable (which toggles the meaning of C-u), and change dired's v to set
quit-window-kills buffer-locally?

I'm sure it's the right behavior: I do think that we want to move
towards merging View-quit and quit-window, but other than that I don't
know because I like my Emacs to accumulate buffers.


        Stefan

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Stefan Monnier]

> I'm sure it's the right behavior: I do think that we want to move
    ^^^
    not

Sorry,

         Stefan

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Juri Linkov]

> I'm not sure it's the right behavior: I do think that we want to move
> towards merging View-quit and quit-window, but other than that I don't
> know because I like my Emacs to accumulate buffers.

That's the main problem: some users like to accumulate buffers
and some users don't like.  So there should be an option to disable
accumulating by `q'.  One variant is remap such as you recommended in
http://lists.gnu.org/archive/html/emacs-devel/2011-10/msg01136.html
Another variant is adding a defcustom such as `quit-window-kills'.
It seems defcustom is more user-friendly.

bug#8615: Please make sure v q removes the buffer for JPGs just likeit does for other files

[Drew Adams]

> > because I like my Emacs to accumulate buffers.
> 
> That's the main problem: some users like to accumulate buffers
> and some users don't like.  So there should be an option to disable
> accumulating by `q'.  One variant is remap such as you recommended in
> http://lists.gnu.org/archive/html/emacs-devel/2011-10/msg01136.html
> Another variant is adding a defcustom such as `quit-window-kills'.
> It seems defcustom is more user-friendly.

Another distinction that it might help to make here is the kind of buffer and
its purpose.  I have no problem accumulating buffers, in general, but I have no
need to accumulate buffers that are essentially temporary and part of a dialog,
once that dialog is finished.

Emacs currently displays some buffers as part of a (non-modal) dialog, but there
is no real (operational, code-aware) notion of such a dialog, and generally no
way for the code to know that the displayed buffer is no longer needed after the
dialog is finished (if the code even knows when it is finished).  Such a buffer
is really only for temporary display, but it is not handled using any simple
construct such as `with-temp-buffer'.  (A user will know, of course, and one
approach could be to have two different keys, one that blows the buffer away and
another that holds onto it.)

If this rings a bell, fine.  If not, fuggeddabowdit - I'm not interested in
belaboring this; we've been through it before.

I agree that a reasonable start would be a user option, as Juri suggests (and
has been suggested before) - some way for a user to express a preference.  "I
like my Emacs to accumulate buffers" is fine as an expression of individual
preference, but not as a guide to Emacs design for everyone.

bug#8615: Please make sure v q removes the buffer for JPGs just likeit does for other files

[Juri Linkov]

> Another distinction that it might help to make here is the kind of buffer and
> its purpose.  I have no problem accumulating buffers, in general, but I have no
> need to accumulate buffers that are essentially temporary and part of a dialog,
> once that dialog is finished.

I have problems with accumulating buffers because I use desktop.el
that remembers all file buffers and tries to restore them after restart.
Other users may have other problems with accumulating buffers.
I solved this problem for myself by adding to .emacs:

(define-key image-mode-map "q" 'quit-window-kill-buffer)
(define-key archive-mode-map "q" 'quit-window-kill-buffer)
(define-key tar-mode-map "q" 'quit-window-kill-buffer)
(define-key dired-mode-map "q" 'quit-window-kill-buffer)

Of course, we should not suggest users doing the same.
So perhaps a defcustom would be the best solution.

bug#8615: Please make sure v q removes the buffer for JPGs just likeit does for other files

[Stefan Monnier]

> I have problems with accumulating buffers because I use desktop.el
> that remembers all file buffers and tries to restore them after restart.
> Other users may have other problems with accumulating buffers.
> I solved this problem for myself by adding to .emacs:

> (define-key image-mode-map "q" 'quit-window-kill-buffer)
> (define-key archive-mode-map "q" 'quit-window-kill-buffer)
> (define-key tar-mode-map "q" 'quit-window-kill-buffer)
> (define-key dired-mode-map "q" 'quit-window-kill-buffer)

(define-key special-mode-map "q" 'quit-window-kill-buffer)

should be sufficient (tho I haven't checked that all the modes above
inherit from special-mode).


        Stefan

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Chong Yidong]

Juri Linkov <juri@jurta.org> writes:

> I mean keybindings
>
>   RET		image-toggle-animation
>   SPC		image-scroll-up
>   DEL		image-scroll-down
>
> vs
>
>   RET		View-scroll-line-forward
>   SPC		View-scroll-page-forward
>   DEL		View-scroll-page-backward

Hmm, SPC and DEL seem to do pretty much the same thing in both cases,
but the difference for RET is clearly problematic.

So I think you're right, we should revert 105285.  The original behavior
requested by the OP (making `q' delete the buffer) can be handled, as
discussed, by introducing an option to make quit-window delete the
buffer---but that bit can wait till post-24.1.

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Juri Linkov]

> So I think you're right, we should revert 105285.

Done.

> The original behavior requested by the OP (making `q' delete the
> buffer) can be handled, as discussed, by introducing an option to make
> quit-window delete the buffer---but that bit can wait till post-24.1.

Meanwhile, jidanni and other users could use a redefinition
recommended by Stefan:

(global-set-key [remap quit-window]
  (lambda () (interactive) (quit-window (not current-prefix-arg))))

or

(define-key special-mode-map "q"
  (lambda () (interactive) (quit-window (not current-prefix-arg))))

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Juri Linkov]

> I only want viewing of images, and OK maybe directories too to disappear
> from the buffer list upon 'q'. The rest is overkill. I like the
> *compilation* buffer etc. to stay around even if no running process. Help.

Then bind them separately:

(eval-after-load "image-mode"
  '(progn
     (define-key image-mode-map "q"
       (lambda () (interactive) (quit-window (not current-prefix-arg))))))

(eval-after-load "dired"
  '(progn
     (define-key dired-mode-map "q"
       (lambda () (interactive) (quit-window (not current-prefix-arg))))))

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Juri Linkov]

> The only things left in the *Buffer List* after lots of v q SPC v q SPC
> are directories... but I guess there is some reason to keep them laying around?

Following the same strict logic, typing `v' on a directory should enable
`view-mode' in Dired mode, so jidanni could use `q' to kill Dired buffers.
Of course, this makes no sense, like it makes no sense to enable
`view-mode' in Archive mode that is very similar to Dired mode.

So I see only one way to resolve this situation it to revert the regression
(another reason to do that is that logic of enabling `view-mode' should be
the same as in `toggle-read-only' that checks only for special mode,
not for `buffer-file-name').

As for the request for `q' to kill Dired and Image buffers,
we could recommend jidanni to put in his .emacs these two lines:

  (global-set-key [remap quit-window]
    (lambda () (interactive) (quit-window (not current-prefix-arg))))

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[jidanni]

>>>>> "JL" == Juri Linkov <juri@jurta.org> writes:
JL> Perhaps you visit only small images that fit into the screen,
JL> so you don't need to use image-mode keys other than `q'.
JL> But when images are larger and you need to scroll them, you are screwed.
Hmmm, well the only difference I see is C-h m doesn't give a key list
... Also no key to reduce the size so an image fits in the buffer.

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Juri Linkov]

> JL> Perhaps you visit only small images that fit into the screen,
> JL> so you don't need to use image-mode keys other than `q'.
> JL> But when images are larger and you need to scroll them, you are screwed.
> Hmmm, well the only difference I see is C-h m doesn't give a key list

You can see the difference with `C-h b'.  Then you will see:

  RET		image-toggle-animation
  SPC		image-scroll-up
  DEL		image-scroll-down

vs.

  RET		View-scroll-line-forward
  SPC		View-scroll-page-forward
  DEL		View-scroll-page-backward

> ... Also no key to reduce the size so an image fits in the buffer.

`image-scale-fit-height' is intended to be bound to `c f h' in
`image-transform-mode', but for some reason it's commented out.

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[jidanni]

>>>>> "JL" == Juri Linkov <juri@jurta.org> writes:
JL> You can see the difference with `C-h b'.
OK, but usually we look in C-h m... anyway I was doing OK with the
arrow keys.

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[jidanni]

>>>>> "JL" == Juri Linkov <juri@jurta.org> writes:
JL> As for the request for `q' to kill Dired and Image buffers,
JL> we could recommend jidanni to put in his .emacs these two lines:

JL>   (global-set-key [remap quit-window]
JL>     (lambda () (interactive) (quit-window (not current-prefix-arg))))
Yes but I only use emacs for a max of four hours, so it doesn't fill up
so bad, I just thought it might be a bug.

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[jidanni]

Erg... this is what I have so far,

(eval-after-load "image-mode"
  '(progn
     (define-key image-mode-map "q"
       (lambda () (interactive) (quit-window (not current-prefix-arg))))));bug#8615
(eval-after-load "dired"
  '(progn
     (define-key dired-mode-map "q"
       (lambda () (interactive) (quit-window (not current-prefix-arg))))))
(eval-after-load "arc-mode"
  '(progn
     (define-key archive-mode-map "q";note the difference from the library name
       (lambda () (interactive) (quit-window (not current-prefix-arg))))))

i.e., an ever growing list. OK, I give up, you win. I'll use

(global-set-key [remap quit-window]
  (lambda () (interactive) (quit-window (not current-prefix-arg))))

But please tell me how to then restore the virgin "q" behavior for one or two
modes, e.g.,

(eval-after-load "compile"
  '(progn
     (define-key compilation-mode-map ... ???

I tired several things but nothing worked. Perhaps the "remap" above
ruined it for everything.

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Kevin Rodgers]

On 12/10/11 3:17 AM, jidanni@jidanni.org wrote:
> Erg... this is what I have so far,
>
> (eval-after-load "image-mode"
>    '(progn
>       (define-key image-mode-map "q"
>         (lambda () (interactive) (quit-window (not current-prefix-arg))))));bug#8615
> (eval-after-load "dired"
>    '(progn
>       (define-key dired-mode-map "q"
>         (lambda () (interactive) (quit-window (not current-prefix-arg))))))
> (eval-after-load "arc-mode"
>    '(progn
>       (define-key archive-mode-map "q";note the difference from the library name
>         (lambda () (interactive) (quit-window (not current-prefix-arg))))))
>
> i.e., an ever growing list. OK, I give up, you win. I'll use
>
> (global-set-key [remap quit-window]
>    (lambda () (interactive) (quit-window (not current-prefix-arg))))
>
> But please tell me how to then restore the virgin "q" behavior for one or two
> modes, e.g.,
>
> (eval-after-load "compile"
>    '(progn
>       (define-key compilation-mode-map ... ???
>
> I tired several things but nothing worked. Perhaps the "remap" above
> ruined it for everything.

Just a guess, assuming that the original behavior is (quit-window 
current-prefix-arg):

(defvar remap-quit-window-exceptions '()
   "List of `major-mode' symbols in which `quit-window' should not be remapped.")

(global-set-key [remap quit-window]
    (lambda () (interactive)
      (if (memq major-mode remap-quit-window-exceptions)
	 (quit-window current-prefix-arg)
        (quit-window (not current-prefix-arg)))))

;; (setq remap-quit-window-exceptions
;;       (cons 'compilation-mode remap-quit-window-exceptions))

-- 
Kevin Rodgers
Denver, Colorado, USA

bug#8615: Please make sure v q removes the buffer for JPGs just like it does for other files

[Juri Linkov]

> (eval-after-load "compile"
>   '(progn
>      (define-key compilation-mode-map ... ???
>
> I tired several things but nothing worked. Perhaps the "remap" above
> ruined it for everything.

You could try:

(define-key special-mode-map "q"
  (lambda () (interactive) (quit-window (not current-prefix-arg))))

(eval-after-load "compile"
  '(progn
     (define-key compilation-mode-map "q" 'quit-window)))

PS:
This means that in 24.2 we should add two customizable options:
one with a list of modes to remap, and one with a list of modes
to exclude from remapping.