From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.bugs Subject: bug#59314: 29.0.50; EUDC and message-mode header completion Date: Tue, 22 Nov 2022 10:21:05 -0500 Message-ID: References: <87a64q7p25.fsf@ericabrahamsen.net> <878rka1y4n.fsf@ericabrahamsen.net> <87sfigx58k.fsf@ericabrahamsen.net> <87k03nx2t1.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4865"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Alexander Adolf , 59314@debbugs.gnu.org To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 22 16:22:29 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxV6R-0000rS-HE for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Nov 2022 16:22:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxV6B-0007yh-Dz; Tue, 22 Nov 2022 10:22:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxV63-0007qi-SX for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 10:22:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxV63-0005As-Hy for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 10:22:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxV63-00043E-D8 for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 10:22:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thomas Fitzsimmons Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Nov 2022 15:22:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59314 X-GNU-PR-Package: emacs Original-Received: via spool by 59314-submit@debbugs.gnu.org id=B59314.166913048615507 (code B ref 59314); Tue, 22 Nov 2022 15:22:03 +0000 Original-Received: (at 59314) by debbugs.gnu.org; 22 Nov 2022 15:21:26 +0000 Original-Received: from localhost ([127.0.0.1]:52279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxV5S-000421-4U for submit@debbugs.gnu.org; Tue, 22 Nov 2022 10:21:26 -0500 Original-Received: from mail.fitzsim.org ([69.165.165.189]:41052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxV5H-000419-0L for 59314@debbugs.gnu.org; Tue, 22 Nov 2022 10:21:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fitzsim.org ; s=20220430; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+DS3zxgya43sTchq+aHon1/ptQR9R4JTAa6OwRgBuC4=; b=QcMGomwTXHiN4E/h295pcpN+XR nHpzXVEqsTlAx4zQFc74o44PAUMpGRN8hLstZHqztPsPeW6E4h+JHqIDO9nDiEvFAhTvnSRCmcJC1 D638nycwWXzXULBB8tIJLYCMO0fNK3ZKpGozfupKptGyZp+3XRmyMTblLkVjYfNuOXI0SDsVinaj6 FgKYNqrZX1jj/bWGyDvANJh+rYDRLa471eYfVoaTm0TLMPkZl1qE9cIIEXKX9MO3qtFAwaYa7A5OW fn6nXReq3soAb7dqvigLKqG9TExQD0iB1i6zopOx+uYEREQmr6pK96FL+ocnJD+DYGUw5SuOHorqU 5kPeaQdg==; Original-Received: from [192.168.1.1] (helo=localhost.localdomain) by mail.fitzsim.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1oxV57-000GrO-Ms; Tue, 22 Nov 2022 10:21:08 -0500 In-Reply-To: <87k03nx2t1.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Mon, 21 Nov 2022 16:15:06 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248652 Archived-At: Eric Abrahamsen writes: > Thomas Fitzsimmons writes: > > [...] > >> That's the extent of my email completion setup. I think the only reason >> this setup doesn't generalize (assuming an EUDC EBDB backend in your >> case) is that other people like different UIs, e.g., when the same >> prefix expands to multiple possible addresses (as you alluded to), what >> UI should one use to select? I use the UI provided by EUDC. >> >> Anyway, tonight I did manage to add ERT tests for the EUDC LDAP backend. >> Can you try: >> >> make -C test lisp/net/eudc-tests.log > > No love! > > Running 11 tests (2022-11-21 16:04:40-0800, selector `(not (or (tag :unstable) (tag :nativecomp)))') > passed 1/11 eudc--plist-member (0.000396 sec) > passed 2/11 eudc-lax-plist-get (0.000433 sec) > passed 3/11 eudc-plist-get (0.000417 sec) > passed 4/11 eudc-plist-member (0.000390 sec) > passed 5/11 eudc-test-make-address (0.000151 sec) > passed 6/11 eudc-test-rfc5322-quote-phrase (0.000067 sec) > passed 7/11 eudc-test-rfc5322-valid-comment-p (0.000760 sec) > skipped 8/11 eudcb-bbdb (0.000102 sec) > passed 9/11 eudcb-ecomplete (0.007451 sec) > Loading eudcb-ldap... > Parsing results... > Parsing results... done > Parsing results... > Parsing results... done > Test eudcb-ldap backtrace: > signal(error ("No match")) > apply(signal (error ("No match"))) > (setq value-640 (apply fn-638 args-639)) > (unwind-protect (setq value-640 (apply fn-638 args-639)) (setq form- > (if (unwind-protect (setq value-640 (apply fn-638 args-639)) (setq f > (let (form-description-642) (if (unwind-protect (setq value-640 (app > (let ((value-640 'ert-form-evaluation-aborted-641)) (let (form-descr > (let* ((fn-638 #'equal) (args-639 (condition-case err (let ((signal- > (let ((ldap-process (start-process "slapd" "*slapd*" "/usr/sbin/slap > (closure (t) nil (let ((value-636 (gensym "ert-form-evaluation-abort > ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test > ert-run-test(#s(ert-test :name eudcb-ldap :documentation "Test the L > ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m > ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil > ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp)))) > ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco > eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n > command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/net/eudc-tests.el" " > command-line() > normal-top-level() > Test eudcb-ldap condition: > (error "No match") > FAILED 10/11 eudcb-ldap (1.024022 sec) at lisp/net/eudc-tests.el:271 > Parsing /home/eric/dev/emacs/test/lisp/net/eudc-resources/mailrc... > Parsing /home/eric/dev/emacs/test/lisp/net/eudc-resources/mailrc... done > passed 11/11 eudcb-mailabbrev (0.002174 sec) > > Ran 11 tests, 9 results as expected, 1 unexpected, 1 skipped (2022-11-21 16:04:41-0800, 1.151547 sec) > > 1 unexpected results: > FAILED eudcb-ldap > > 1 skipped results: > SKIPPED eudcb-bbdb Thanks for trying. Can you try changing "(sleep-for 1)" to "(sleep-for 5)"? (In a subsequent patch I'll replace the sleep with a retry loop to make this more reliable.) If that doesn't work, then below is roughly what the test is doing. Can you see if this works for you on the command line? You can change "-d 0" => "-d 255" for lots of debugging output. The test first changes to the "test/lisp/net" directory, which is important, because the slapd.conf line "directory eudc-resources" specifies a relative directory. cd test/lisp/net /usr/sbin/slapd -h "ldap://127.0.0.1:3899" \ -d 0 -4 \ -f eudc-resources/slapd.conf & \ sleep 5 && \ ldapsearch -x -LLL -h127.0.0.1:3899 \ -b "dc=gnu,dc=org" "cn=emacs-ert-test-1" => dn: cn=emacs-ert-test-1,dc=gnu,dc=org objectClass: OpenLDAPperson cn: emacs-ert-test-1 description:: RW1hY3Mg uid: 1 sn: ERT1 givenName: Emacs mail: emacs-ert-test-1@ldap.gnu.org Thanks, Thomas