unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: no-spam@cua.dk (Kim F. Storm)
To: Per Cederqvist <ceder@ingate.com>
Cc: bug-gnu-emacs@gnu.org
Subject: Re: accept-process-output incompatible change in CVS Emacs: patch included
Date: Sat, 05 May 2007 00:33:39 +0200	[thread overview]
Message-ID: <m3ps5gkym4.fsf@kfs-l.imdomain.dk> (raw)
In-Reply-To: <x3mz0lklv4.fsf@rapture.ingate.se> (Per Cederqvist's message of "04 May 2007 10\:56\:47 +0200")

Per Cederqvist <ceder@ingate.com> writes:

> This change in the upcoming Emacs 22 breaks some code:
>
>> 2006-03-22  Kim F. Storm  <storm@cua.dk>
>> 
>> 	* process.c (Faccept_process_output): Fix to comply with lisp
>> 	reference.  Change arg "timeout" to "seconds" and allow both
>> 	integer and float value.  Change arg "timeout-msec" to "millisec"
>> 	and interpret" as milliseconds rather than microseconds.  Fix doc
>> 	string accordingly.

Please see:

http://lists.gnu.org/archive/html/emacs-devel/2006-03/msg00937.html

>
> I enclose a patch that makes accept-process-output
> backwards-compatible with Emacs 21.
>
> One application I'm running now runs very slowly, since its carefully
> tuned timeoutes are multiplied by 1000.

Well, other code believing the lisp ref, and was broken by the old
behaviour.

So just reverting the change is no good at this time.

What application is that?  

>  If, for some reason, my patch is unacceptable, please
> mention this as an incompatible change in the NEWS file.

This is a good point.

-- 
Kim F. Storm  http://www.cua.dk

  reply	other threads:[~2007-05-04 22:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-04  8:56 accept-process-output incompatible change in CVS Emacs: patch included Per Cederqvist
2007-05-04 22:33 ` Kim F. Storm [this message]
2007-05-05  8:42   ` Per Cederqvist
2007-05-05  8:57     ` Eli Zaretskii
2007-05-05 23:19       ` Richard Stallman
2007-05-05 23:19     ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3ps5gkym4.fsf@kfs-l.imdomain.dk \
    --to=no-spam@cua.dk \
    --cc=bug-gnu-emacs@gnu.org \
    --cc=ceder@ingate.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).