unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Sergio Durigan Junior <sergiodj@riseup.net>
To: Roland Winkler <winkler@gnu.org>
Cc: 11580@debbugs.gnu.org, emacs-devel@gnu.org
Subject: bug#11580: [PATCH] Fix bug #11580
Date: Sat, 29 Sep 2012 16:30:42 -0300	[thread overview]
Message-ID: <m3pq54hbj1.fsf__33482.2780955166$1348947117$gmane$org@riseup.net> (raw)
In-Reply-To: <87d3152fxd.fsf@gnu.org> (Roland Winkler's message of "Sat, 29 Sep 2012 07:04:46 -0500")

On Saturday, September 29 2012, Roland Winkler wrote:

> On Wed, Sep 26 2012, Tassilo Horn wrote:
>>> The attached patch fixes the bug listed on $SUBJECT.  Maybe there are
>>> better ways to fix it, but a quick hack did the trick so I am sending
>>> it for review.
>>
>> I don't use bbdb, so I've Cc-ed Roland who is the current bbdb
>> maintainer.  Roland, the complete bug thread is here:
>
> It seems this is all about BBDB v2. Unfortunately, the BBDB v3 that I
> have been working on for a little while has not yet been released
>
> Nobody on the BBDB mailing list has ever mentioned EUDC. So I never
> thought about this till I saw this bug report.
>
> I've tried to clean up the code of BBDB and make it more robust. Lots of
> things have changed along this way. It seems to me that eudc-bbdb.el
> would likewise benefit from that. However, the current version of
> eudc-bbdb.el will not work with BBDB v3.
>
> There are a few things left I'd like to do before making the first
> proper release of BBDB v3. It appears to me that then it would make more
> sense to look into adapting eudc-bbdb.el to BBDB v3.
>
> If in the meanwhile you have a patch that fixes the bug for you, can you
> continue with it till then?

Thank you for the explanations.  I think this patch has more to do with
EUDC than with BBDB, TBH.  And this is a simple fix to a long-standing
problem.

I am afraid I did not understand the last paragraph.  Are you saying
that it is OK to commit this patch upstream?

Thanks,

-- 
Sergio





  parent reply	other threads:[~2012-09-29 19:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87ipb64w5x.fsf@riseup.net>
2012-09-26 17:54 ` bug#11580: [PATCH] Fix bug #11580 Tassilo Horn
2012-09-29 12:04   ` Roland Winkler
     [not found]   ` <87d3152fxd.fsf@gnu.org>
2012-09-29 19:30     ` Sergio Durigan Junior [this message]
     [not found]     ` <m3pq54hbj1.fsf@riseup.net>
     [not found]       ` <20584.24939.541992.925590@gargle.gargle.HOWL>
2012-05-29  5:14         ` bug#11580: 23.3; EUDC can't handle empty last names in BBDB Sergio Durigan Junior
     [not found]           ` <handler.11580.B.133834110724596.ack@debbugs.gnu.org>
2012-07-12  2:00             ` bug#11580: Acknowledgement (23.3; EUDC can't handle empty last names in BBDB) Sergio Durigan Junior
2012-07-12 14:37               ` Stefan Monnier
2012-10-02  1:46           ` bug#11580: [PATCH] Fix bug #11580 Sergio Durigan Junior
     [not found]         ` <87d3113ass.fsf@riseup.net>
2012-10-02  1:58           ` Roland Winkler
2012-10-02  2:50             ` Sergio Durigan Junior
2012-10-02  3:59           ` Stefan Monnier
2012-10-02  5:10           ` Chong Yidong
2012-09-30 15:12       ` Roland Winkler
     [not found] ` <87mx0c655g.fsf@thinkpad.tsdh.de>
2012-09-26 18:18   ` Sergio Durigan Junior
     [not found]   ` <m3ipb0r6kf.fsf@riseup.net>
2012-09-26 18:56     ` Tassilo Horn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='m3pq54hbj1.fsf__33482.2780955166$1348947117$gmane$org@riseup.net' \
    --to=sergiodj@riseup.net \
    --cc=11580@debbugs.gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=winkler@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).