From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#34233: 27.0.50; defvar in comment Date: Wed, 10 Jul 2019 13:42:10 +0200 Message-ID: References: <87o923qdrm.fsf@mouse.gnus.org> <875zobdowo.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="114227"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34233@debbugs.gnu.org, Sebastian Miele , Stefan Monnier To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 10 13:46:07 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hlB30-000TYh-Gx for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Jul 2019 13:46:06 +0200 Original-Received: from localhost ([::1]:60126 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlB0E-0001vx-Lb for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Jul 2019 07:43:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40868) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlB06-0001vn-RN for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2019 07:43:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hlB05-00084f-HS for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2019 07:43:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54347) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hlB01-00080F-TM for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2019 07:43:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hlB01-00070T-OM for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2019 07:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jul 2019 11:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34233 X-GNU-PR-Package: emacs Original-Received: via spool by 34233-submit@debbugs.gnu.org id=B34233.156275894026881 (code B ref 34233); Wed, 10 Jul 2019 11:43:01 +0000 Original-Received: (at 34233) by debbugs.gnu.org; 10 Jul 2019 11:42:20 +0000 Original-Received: from localhost ([127.0.0.1]:34935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlAzM-0006zV-6X for submit@debbugs.gnu.org; Wed, 10 Jul 2019 07:42:20 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:36180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlAzK-0006zN-8b for 34233@debbugs.gnu.org; Wed, 10 Jul 2019 07:42:18 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hlAzD-0008Jq-66; Wed, 10 Jul 2019 13:42:13 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEXa2djt7eyjoZ/k5OL+ //79/f3Ozcu+vbvUGkYsAAACbUlEQVQ4jbWPQY/bIBCFh0WBayjr3WuWSuYKQeucI/UHxHV3eyWx CleHaJm/38HaVlXV3tqJjZT38d4bw6e/DPx7cDF7Y2q25e03oGiCV2q8/0PUZfeftjq+3Hfq2L2o o3pR6mXsuu44fulGoEXGsaOD1hpV9/OAcZWaOoZf2Ahk7byaVOg6HVZxZR1FKa2U95ruB0Ws+YhQ lOp8mJra3uC1Hn3rUJ4FPWn6T4Te8Bx8iwOvp4n0QIhuB6b96u1g9DTPwXnwIfjANScLdQIn3Tnt mQPVHrZtcUqDnk5bz3jYauD0bGFq1knDc+BnDm7LuGuyage1KdDMnU6nLUuOicSAB9AuTCHA9kT3 4TwLnkJKWmzIwjcENvG8YVwMbhbRJSYiSQBaw0m8PgyCz3FwaR4ag+iBeQDGYT7HNMxcJC7mB0qE LVUxYFEMwyNUASk+JJfgAZgL8CpeJYF4wxQhrSxA8hTzFq/fzkuSoqYoq6s8UWjUQM3DkHOOi0h1 wDkvcxKO3CKKKOPtVnNMOeYKGA8pugjzTCqmLCUdGDFK5DHR13wVj4d9fjzkijXiInHIbb9E5fVa r0tfMdvaLIQjgIBHKQeUWC5YsdTcJ6yyEoElStpJ1l2PtVhpF8RKKwS41Xrtn2xvS7HZNEaEKkDu P8jL57LfX9BYNLJUakIiy7I87eyut9YWUw2tkGtCRDgcqDkXNIVeYn2h76Ef1Frxcil3xVqDpjem VbStbsuu7z9SEmm2WCxmbeBw16Y57ooxxVBeM2Gl8h1ZemNNG4KNWCqnCkTzY2zT1qEoqqZpl1eX pYpWbvr3eQ9bc4h9B6WuB3+i6A6mAAAAAElFTkSuQmCC In-Reply-To: <875zobdowo.fsf@web.de> (Michael Heerdegen's message of "Tue, 09 Jul 2019 20:49:11 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162613 Archived-At: Michael Heerdegen writes: > This is `eval-sexp-add-defvars' not checking if defvars are really code. So is this the correct solution? diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el index cb1b17b447..0e99cb9ac0 100644 --- a/lisp/progmodes/elisp-mode.el +++ b/lisp/progmodes/elisp-mode.el @@ -1179,7 +1179,13 @@ eval-sexp-add-defvars (let ((var (intern (match-string 1)))) (and (not (special-variable-p var)) (save-excursion - (zerop (car (syntax-ppss (match-beginning 0))))) + (let ((syntax (syntax-ppss (match-beginning 0)))) + ;; Top-level. + (and (zerop (car syntax)) + ;; Not in a comment. + (null (nth 4 syntax)) + ;; Not in a string. + (null (nth 3 syntax))))) (push var vars)))) `(progn ,@(mapcar (lambda (v) `(defvar ,v)) vars) ,exp))))) (Those ppss things really should have accessors. :-)) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no