unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Magne Ingebrigtsen <larsi@gnus.org>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 52@debbugs.gnu.org
Subject: bug#52: FW: [mouse-1 in Customize should respect mouse-1-click-follows-link]
Date: Wed, 06 Jul 2011 19:24:03 +0200	[thread overview]
Message-ID: <m3mxgr2uh8.fsf@quimbies.gnus.org> (raw)
In-Reply-To: <001a01c883a2$b94cae10$0600a8c0@us.oracle.com> (Drew Adams's message of "Tue, 11 Mar 2008 10:07:09 -0800")

"Drew Adams" <drew.adams@oracle.com> writes:

> These are links. They should be controlled by `mouse-1-click-follows-link'.

[...]

>> Click mouse-1 on a link in a Customize buffer that is a link to
>> another option name or similar. That is, on text between `' that is
>> highlighted with mouseover (`mouse-face').  The link is followed.
>> 
>> The link should not be followed by `mouse-1' if
>> `mouse-1-click-follows-link' is nil.  In that case, only clicking
>> `mouse-2' should follow the link.

That sounds logical.

The actual key binding in these buffers for the mouse is:

<down-mouse-1>	widget-button-click
<down-mouse-2>	widget-button-click

How is `mouse-1-click-follows-link' generally supposed to work?  Is
`widget-button-click' supposed to not do its thing if
`mouse-1-click-follows-link' is nil?  That seems rather yucky.  Or is
the mode not supposed to bind `down-mouse-1' to anything if it's nil?

That variable is unknown to me.  The documentation says:

------
This feature only works in modes that specifically identify
clickable text as links, so it may not work with some external
packages.  See `mouse-on-link-p' for details.
------

Customize can't be said to be an "external package".  :-)  

`mouse-on-link-p' says:

------
A clickable link is identified by one of the following methods:

- If the character at POS has a non-nil `follow-link' text or
overlay property, the value of that property determines what to do.

- If there is a local key-binding or a keybinding at position POS
for the `follow-link' event, the binding of that event determines
what to do.
------

And the widget stuff does put `follow-link' on stuff.  So how is this
supposed to tie together?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/





       reply	other threads:[~2011-07-06 17:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <001a01c883a2$b94cae10$0600a8c0@us.oracle.com>
2011-07-06 17:24 ` Lars Magne Ingebrigtsen [this message]
2011-07-06 17:32   ` bug#52: FW: [mouse-1 in Customize should respect mouse-1-click-follows-link] Drew Adams
2011-07-06 20:09   ` Stefan Monnier
2011-07-07 16:19     ` Lars Magne Ingebrigtsen
2011-07-07 19:03     ` Chong Yidong
2011-10-27 21:16       ` Drew Adams
2011-10-27 21:28         ` bug#52: FW: [mouse-1 in Customize should respectmouse-1-click-follows-link] Drew Adams
2011-10-29  4:46           ` Chong Yidong
2011-10-29 15:04             ` Drew Adams
2011-10-30  3:25               ` Chong Yidong
2011-10-30 14:46                 ` Drew Adams
2012-09-17  0:26                   ` bug#52: FW: [mouse-1 in Customize shouldrespectmouse-1-click-follows-link] Drew Adams
2011-10-27 21:13 ` bug#52: FW: bug#52: FW: [mouse-1 in Customize should respect mouse-1-click-follows-link] Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3mxgr2uh8.fsf@quimbies.gnus.org \
    --to=larsi@gnus.org \
    --cc=52@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).