From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daiki Ueno Newsgroups: gmane.emacs.bugs Subject: bug#10403: epg--make-temp-file permissions race condition fixes Date: Tue, 10 Jan 2012 11:57:58 +0900 Message-ID: References: <4EFCE840.4000405@cs.ucla.edu> <87r4zckmue.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1326164336 3968 80.91.229.12 (10 Jan 2012 02:58:56 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 10 Jan 2012 02:58:56 +0000 (UTC) Cc: 10403@debbugs.gnu.org, Paul Eggert , Chong Yidong To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 10 03:58:51 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RkRvH-0004ea-4J for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Jan 2012 03:58:51 +0100 Original-Received: from localhost ([::1]:32817 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkRvG-0001Sq-E7 for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Jan 2012 21:58:50 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:43376) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkRvD-0001SV-Gl for bug-gnu-emacs@gnu.org; Mon, 09 Jan 2012 21:58:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RkRvB-0003Ae-CN for bug-gnu-emacs@gnu.org; Mon, 09 Jan 2012 21:58:47 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56932) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkRvB-0003AK-4C for bug-gnu-emacs@gnu.org; Mon, 09 Jan 2012 21:58:45 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1RkRvR-0004pL-KE for bug-gnu-emacs@gnu.org; Mon, 09 Jan 2012 21:59:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daiki Ueno Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Jan 2012 02:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 10403-submit@debbugs.gnu.org id=B10403.132616431618522 (code B ref 10403); Tue, 10 Jan 2012 02:59:01 +0000 Original-Received: (at 10403) by debbugs.gnu.org; 10 Jan 2012 02:58:36 +0000 Original-Received: from localhost ([127.0.0.1]:51605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RkRv1-0004oh-Ak for submit@debbugs.gnu.org; Mon, 09 Jan 2012 21:58:35 -0500 Original-Received: from www10194u.sakura.ne.jp ([182.48.42.232]:60881) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RkRuy-0004oR-75 for 10403@debbugs.gnu.org; Mon, 09 Jan 2012 21:58:33 -0500 In-Reply-To: (Stefan Monnier's message of "Sat, 07 Jan 2012 13:19:26 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:55599 Archived-At: Stefan Monnier writes: >> Could you review the patch posted by Paul? Thanks. >> Paul Eggert writes: > > BTW, why copy the code from poe.el rather than from Emacs itself? Maybe because poe.el's code seems to provide better compatibility with ancient Emacs and XEmacs. For example, in the Emacs definition of make-temp-file, I see MUSTBENEW arg of write-region is used, which is missing in XEmacs 21.4. > Also, why use `eval-and-compile' since the function is not used > during compilation? Right. I think we could get rid of such a eval-and-compile from several places. Regards, -- Daiki Ueno