From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.bugs Subject: bug#35969: 26.2, Excorporate Date: Mon, 17 Jun 2019 18:08:08 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="27022"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Andreas Schwab , 35969@debbugs.gnu.org To: "tenspd137 ." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 18 00:09:21 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hczoX-0006up-70 for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Jun 2019 00:09:21 +0200 Original-Received: from localhost ([::1]:52182 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hczoV-0000Ke-SC for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Jun 2019 18:09:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58185) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hczoH-0000KL-L4 for bug-gnu-emacs@gnu.org; Mon, 17 Jun 2019 18:09:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hczoF-0005nU-QN for bug-gnu-emacs@gnu.org; Mon, 17 Jun 2019 18:09:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58096) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hczoE-0005mB-3l for bug-gnu-emacs@gnu.org; Mon, 17 Jun 2019 18:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hczoD-0006jV-Rl for bug-gnu-emacs@gnu.org; Mon, 17 Jun 2019 18:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thomas Fitzsimmons Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Jun 2019 22:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35969 X-GNU-PR-Package: emacs Original-Received: via spool by 35969-submit@debbugs.gnu.org id=B35969.156080929825815 (code B ref 35969); Mon, 17 Jun 2019 22:09:01 +0000 Original-Received: (at 35969) by debbugs.gnu.org; 17 Jun 2019 22:08:18 +0000 Original-Received: from localhost ([127.0.0.1]:43407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcznV-0006iI-Vw for submit@debbugs.gnu.org; Mon, 17 Jun 2019 18:08:18 -0400 Original-Received: from mail-io1-f65.google.com ([209.85.166.65]:45711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcznT-0006i4-W5 for 35969@debbugs.gnu.org; Mon, 17 Jun 2019 18:08:16 -0400 Original-Received: by mail-io1-f65.google.com with SMTP id e3so24853838ioc.12 for <35969@debbugs.gnu.org>; Mon, 17 Jun 2019 15:08:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=4Xe2MgZuTHEcWyimThLbtpgUyDIyq656EG3kffyc2NI=; b=D+lEbXZrHXWWclpw97YFvh1sm6EeSYyhuQZChATKWpVEz+8kQNoHkwHeiH4FJ3g7mJ etj6z/NQ4PXhUhE4sBJ+x801GtmiBG30apvwzkvJl93JlO+RvgYMTbqqio9p0Wy2CTY9 PPxZmFe4jtTg2FKOu8ob3Blg7N2vp5CThTuWB0eNkPXcrjIYMbHqcVYxtqkVbjm2EV6d fjKsjaCdAYieRUW63TIJKGmGTjgBX2wUg/v5lhiY+Ub1PETNtu6QR45QP5CDvp11F4zL nIAQ3EvfPSt8v8caGcKqu3kYF9YmTuVxofNN6UE9IUveFqxSb2cWRA2MtfGaa8x4uCkP +NMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=4Xe2MgZuTHEcWyimThLbtpgUyDIyq656EG3kffyc2NI=; b=FP9KITsmzsymKUleMB15nt5qvgncZnRZsdVKob4puDqjfc8FXpowqQ+hoNwqt685AA RQzVvm2by0ze8XCh1oqDS+WsAENXxR1hzBuvhZv3NLXP1ISx59+vzXwrg5/HFI/9+0wk RKVJ/hvkFPPkUG82y3XFgOI6cwgfBh10HHPDoGhkSpRp8zacuQNiEp+tFhswLn1Z7ROK oIioftf7zi+dqn22jaAhcTdK1AyDb+tuPwTsLOAax8I1S0GYBNz0CV063s2NzsviOV3C sPrhicPytGwPSPn22WrHwsCrAn1xZtR1Wq0lp1qTc6sYJwJ94N93sPr4/wbcfrHuacRv eIbQ== X-Gm-Message-State: APjAAAX49j5MQbWFT/jvWx7HDOQXqPN29RkImpg7AOrR963Sg5ucGIz9 ZnjtC22WWweIN8gV2FAve5e0HkXCoUg= X-Google-Smtp-Source: APXvYqyS8Iqciyis1yh6k6lQwKLqNE6POpNAWABM8+NLwynDpsB/Vc5iqxYANunLLfX7olJC11Q7vw== X-Received: by 2002:a5e:8210:: with SMTP id l16mr1372764iom.240.1560809289854; Mon, 17 Jun 2019 15:08:09 -0700 (PDT) Original-Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id k8sm14298375iob.78.2019.06.17.15.08.08 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jun 2019 15:08:08 -0700 (PDT) In-Reply-To: (tenspd's message of "Mon, 17 Jun 2019 10:31:40 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160748 Archived-At: Hi, Good to hear that the patch I posted worked! Yes, that's the patch that Andreas's commit 84613dae5c34ea742dd9a3e56f5acb55f604b483 applied. From what I can tell, you will not have that in Emacs 26.2. Can you try reverting my patch and applying Andreas's patch, and see if Excorporate still works through the proxy? Thanks, Thomas "tenspd137 ." writes: > The patch Thomas seems to work from behind the proxy. My current > emacs version is 26.2, so I would think it would include the commit > Andreas is talking about.... I went and looked it up - is this the > correct commit? > > diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el > index 53798f7..817c5ce 100644 > --- a/lisp/url/url-http.el > +++ b/lisp/url/url-http.el > @@ -1412,7 +1412,9 @@ The return value of this function is the > retrieval buffer." > 'url-http-wait-for-headers-change-function) > (set-process-filter tls-connection 'url-http-generic-filter) > (process-send-string tls-connection > - (url-http-create-request))) > + ;; Use the non-proxy form of the request > + (let (url-http-proxy) > + (url-http-create-request)))) > (gnutls-error > (url-http-activate-callback) > (error "gnutls-error: %s" e)) > > Thanks! > > -C > > > On Sat, Jun 15, 2019 at 1:41 AM Andreas Schwab wrote: >> >> On Jun 14 2019, Thomas Fitzsimmons wrote: >> >> > diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el >> > index 00803a103a..723d111d58 100644 >> > --- a/lisp/url/url-http.el >> > +++ b/lisp/url/url-http.el >> > @@ -329,7 +329,10 @@ url-http-create-request >> > ;; The request >> > (or url-http-method "GET") " " >> > (url-http--encode-string >> > - (if using-proxy (url-recreate-url url-http-target-url) real-fname)) >> > + (if (and using-proxy >> > + (not (equal "https" (url-type url-http-target-url)))) >> > + (url-recreate-url url-http-target-url) >> > + real-fname)) >> >> That should already be handled by commit 84613dae5c. >> >> Andreas. >> >> -- >> Andreas Schwab, schwab@linux-m68k.org >> GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 >> "And now for something completely different."