From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#21025: tabulated-list.el: It should preserve header line set by derived modes. (Encl. a suggested PATCH) Date: Tue, 25 Jun 2019 18:39:24 +0200 Message-ID: References: <559EBE29.8000302@gmail.com> <87k2lvvk1z.fsf@gnus.org> <5d81d55b-8f22-435c-aaf5-8c93db7beec5@default> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="49575"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Vaidheeswaran C , 21025@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 25 18:40:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfoUO-000Ckl-KX for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 18:40:12 +0200 Original-Received: from localhost ([::1]:33990 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfoUN-0003rw-Iw for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 12:40:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50212) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfoUI-0003rm-EP for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 12:40:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfoUG-0003ED-BY for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 12:40:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48089) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfoUE-0003DT-Sa for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 12:40:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hfoUE-0006WF-28 for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 12:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2019 16:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21025 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 21025-submit@debbugs.gnu.org id=B21025.156148077225012 (code B ref 21025); Tue, 25 Jun 2019 16:40:02 +0000 Original-Received: (at 21025) by debbugs.gnu.org; 25 Jun 2019 16:39:32 +0000 Original-Received: from localhost ([127.0.0.1]:33400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfoTk-0006VM-Gb for submit@debbugs.gnu.org; Tue, 25 Jun 2019 12:39:32 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:52720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfoTi-0006V9-HI for 21025@debbugs.gnu.org; Tue, 25 Jun 2019 12:39:30 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfoTc-00020W-Gl; Tue, 25 Jun 2019 18:39:26 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAMFBMVEWdnZ0gHx+Hh4dycnHs 7Ozg4OBFRESysbH///8HBQX9/f339/ddXVzV1dXJycm9vb0QqBh3AAACTElEQVQ4jWPowA66GHBI dFBfovVu9NWOrR37Qq6EoEq0T547qYMzRIB/PheaxJyUSTsq9af3T8tCk5g0bxLrNRGB95MmoNnB /rW87n6pQ+z/OjRXpck8miL5Nfn5cQ00Cc3ES1M+yk3St0Szo+Mm46Ipz6cKTWAXQZPo39f79cZv /1dvbxDp81EJYiSudLRiinZ3rGYoLb3UUY4usaDjEYN80aUrx1hQxddvjrjD8G9d8Q92ZNEWr44m G4sihprbyhz2z/ThFrksf9fbXiQQyCDakvCjUnjBBqhyFr3vDwJN92cmMky6+pij8l1AcBcksi8b 8DEzT29nyGSQ9fh4Wmnv5zdNFRD36DxKFD24NcKSQfzGt/TUOmXmmBVgCXefzWyzG/z4JzJMLnEw nJoiM00eannvwTmz33QwzmHIWf63aF5xUqYEzFk+M2V1bqzRZyhqqFgyd/OckxpgUa+O1gtnjv/Z sd+IQa9BI/Z0gyxjBEh8FXNHhyITN+P++GMMi37nKa3omcwP1hCwoePWQ74V5wuWFzOkR1xg7thY mwzM8x0dMUpd5jwmHXwW7TEMmucf23S/3Ty3o4N3R0fNwV151Soun8P3bmFYovwgmJfbTbqj/VFH R5PlFyWPjjcGOhwdDBE+IdV9vO3nuw+XdnRdZ+MTs73x7olZSgfDOocOjS67MLWHQhzbV5/lP3Aw ILq1m0egg2HxzRcvOsQ5r2UysTwN09ia/uae4ubfRpN2M3z+mVGzd96nhyfP1Bbs+RVT/rBseoOr WfoHANr+UIpIZ/mSAAAAAElFTkSuQmCC In-Reply-To: <5d81d55b-8f22-435c-aaf5-8c93db7beec5@default> (Drew Adams's message of "Tue, 25 Jun 2019 09:35:57 -0700 (PDT)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161398 Archived-At: Drew Adams writes: >> >> - (overlay-put tabulated-list--header-overlay 'face 'underline)))) >> >> + (overlay-put tabulated-list--header-overlay >> >> + 'face '(:overline t :underline t :weight bold))))) >> > >> > This might be more controversial, though. I think it looks nice, but >> > some people don't like so many lines. Perhaps it should be a defface, >> > so that people can change this themselves? The default could be what >> > you're describing, though. >> >> I've now done this change and otherwise applied your patch. > > This is a bad way to do things - makes it difficult > for users do customize the appearance. Emacs is "the > extensible, customizable, self-documenting, real-time > display editor". > > The right way to take care of what is essentially a > user's preference for column-header appearance is not > to change the hard-coded appearance but to define a > face for this in `tabulated-list.el'. Then ALL users > can get the appearance they want just by customizing > that face. That's what I did, and that's what I said I did. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no