unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
To: Devon Gleeson <dgleeson@tripwire.com>
Cc: 22969@debbugs.gnu.org
Subject: bug#22969: 24.5; excorporate 0.7.0 split-string failure
Date: Wed, 09 Mar 2016 18:46:19 -0500	[thread overview]
Message-ID: <m3lh5rz038.fsf@fitzsim.org> (raw)
In-Reply-To: <mvi2tz1t7j8hpb.fsf@pdxdgleesonm.i-did-not-set--mail-host-address--so-tickle-me> (Devon Gleeson's message of "Wed, 9 Mar 2016 21:28:00 +0000")

Hi Devon,

Devon Gleeson <dgleeson@tripwire.com> writes:

> I installed excorporate from elpa. Excorporate connected to my exchange
> server and said it was ready. I opened my calendar and hit the 'e' key,
> I saw the following error in my mini-buffer and in *Messages*
>
> Scheduled to <2016-03-09 Wed 18:00>
> error in process filter: split-string: Wrong type argument: stringp, nil
> error in process filter: Wrong type argument: stringp, nil
>
> The org-mode document *Excorporate* rendered, but had an incomplete list
> of calendar events.

Thanks for the bug report.  This happens when there are no invitees.
This will be fixed in 0.7.3 once I can merge soap-client.el, which
diverged on emacs-master.  In the meantime, I suspect these patches will
fix it for you (apply by hand):

--- ./excorporate.el~
+++ ./excorporate.el
@@ -649,7 +649,9 @@ (defun exco-calendar-item-iterate (response callback)
 				   end 'dateTime)))
 	     (location (cdr (assoc 'Location calendar-item)))
 	     (to-invitees (cdr (assoc 'DisplayTo calendar-item)))
-	     (main-invitees (mapcar 'org-trim (split-string to-invitees ";")))
+	     (main-invitees (when to-invitees
+			      (mapcar 'org-trim
+				      (split-string to-invitees ";"))))
 	     (cc-invitees (cdr (assoc 'DisplayCc calendar-item)))
 	     (optional-invitees (when cc-invitees
 				  (mapcar 'org-trim

--- ./excorporate-org.el~
+++ ./excorporate-org.el
@@ -88,8 +88,9 @@ (defun exco-org-insert-meeting (subject start end location
   (insert (format "+ Duration: %d minutes\n"
 		  (round (/ (float-time (time-subtract end start)) 60.0))))
   (insert (format "+ Location: %s\n" location))
-  (insert "+ Invitees:\n")
-  (exco-org-insert-invitees main-invitees)
+  (when main-invitees
+    (insert "+ Invitees:\n")
+    (exco-org-insert-invitees main-invitees))
   (when optional-invitees
     (insert "+ Optional invitees:\n")
     (exco-org-insert-invitees optional-invitees)))

Thomas





  reply	other threads:[~2016-03-09 23:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-09 21:28 bug#22969: 24.5; excorporate 0.7.0 split-string failure Devon Gleeson
2016-03-09 23:46 ` Thomas Fitzsimmons [this message]
2016-03-10  3:54   ` Devon Gleeson
2016-03-18 12:00     ` Thomas Fitzsimmons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3lh5rz038.fsf@fitzsim.org \
    --to=fitzsim@fitzsim.org \
    --cc=22969@debbugs.gnu.org \
    --cc=dgleeson@tripwire.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).