From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes Date: Tue, 25 Jun 2019 17:44:33 +0200 Message-ID: References: <2a6ff247-2b75-4f85-9a4c-889576ed7b34@default> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="76773"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 22457@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 25 17:45:54 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfndq-000JrA-1e for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 17:45:54 +0200 Original-Received: from localhost ([::1]:33326 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfndp-0002Xz-0W for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 11:45:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36569) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfndJ-0002Sd-VN for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 11:45:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfnd7-0005t1-JQ for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 11:45:14 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47983) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfncz-0005kS-TZ for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 11:45:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hfncz-0006x5-Ke for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 11:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2019 15:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22457 X-GNU-PR-Package: emacs Original-Received: via spool by 22457-submit@debbugs.gnu.org id=B22457.156147747926674 (code B ref 22457); Tue, 25 Jun 2019 15:45:01 +0000 Original-Received: (at 22457) by debbugs.gnu.org; 25 Jun 2019 15:44:39 +0000 Original-Received: from localhost ([127.0.0.1]:33291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfncd-0006wA-BM for submit@debbugs.gnu.org; Tue, 25 Jun 2019 11:44:39 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:51690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfncb-0006w1-Oz for 22457@debbugs.gnu.org; Tue, 25 Jun 2019 11:44:38 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfncX-0001W8-IV; Tue, 25 Jun 2019 17:44:35 +0200 In-Reply-To: (Drew Adams's message of "Tue, 25 Jun 2019 08:33:14 -0700 (PDT)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161389 Archived-At: Drew Adams writes: >> Could you re-spin your change and submit a patch? > > diff -u dired.el dired-2019-06-25a-patched.el > --- dired.el 2019-06-25 07:57:35.886354900 -0700 > +++ dired-2019-06-25a-patched.el 2019-06-25 08:09:23.058466400 -0700 Thanks; applied to the Emacs trunk. As this is a user-visible change (but a good one, I think), it might be controversial. The change is basically what I put in NEWS: -- *** The marking commands now report how many files were marked by the command itself, not how many files are marked in total. -- Perhaps somebody will want to weigh in here; feel free to revert the commit if this is felt to be a confusing change. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no