From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#24960: 25.1; etags incorrectly indexes quoted Erlang atoms Date: Tue, 25 Jun 2019 19:13:55 +0200 Message-ID: References: <83d1htdwgo.fsf@gnu.org> <838tsgd912.fsf@gnu.org> <83k1d9linv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="202397"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: david.hull@openx.com, 24960@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 25 19:15:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfp2F-000qUI-5q for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 19:15:11 +0200 Original-Received: from localhost ([::1]:34196 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfp2E-0003dU-79 for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 13:15:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57185) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfp27-0003aK-QB for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 13:15:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfp26-0001N6-Nl for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 13:15:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48119) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfp26-0001Mw-JP for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 13:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hfp26-0007Qo-Dx for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 13:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2019 17:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24960 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24960-submit@debbugs.gnu.org id=B24960.156148284428471 (code B ref 24960); Tue, 25 Jun 2019 17:15:02 +0000 Original-Received: (at 24960) by debbugs.gnu.org; 25 Jun 2019 17:14:04 +0000 Original-Received: from localhost ([127.0.0.1]:33427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfp1A-0007P8-Ie for submit@debbugs.gnu.org; Tue, 25 Jun 2019 13:14:04 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:53144) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfp18-0007Oc-Eu for 24960@debbugs.gnu.org; Tue, 25 Jun 2019 13:14:02 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfp11-0002Ia-Fr; Tue, 25 Jun 2019 19:13:58 +0200 In-Reply-To: <83k1d9linv.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 25 Jun 2019 19:43:48 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161403 Archived-At: Eli Zaretskii writes: >> From: Lars Ingebrigtsen >> Cc: David Hull , 24960@debbugs.gnu.org >> Date: Tue, 25 Jun 2019 01:39:10 +0200 >> >> It looks like the copyright assignment went through, but the patch >> wasn't applied. >> >> I had a look at the patch, but I know nothing about either Erlang or >> etags.c, so I can't really say whether it's reasonable or not. It looks >> nice, though. :-) > > I think it should go in. There was one problem in the patch: if (len > 0) - make_tag (cp, len, true, s, cp + len - s, lineno, linecharno); + /* If the name is quoted, the quotes are not part of the name. */ + if (len > 2 && cp[0] == '\'' && cp[len - 1] == '\'') + { + cp++; + len -= 2; + } + make_tag (cp, len, true, s, pos, lineno, linecharno); I think what was meant was that the make_tag should be in that "if" branch, so I slapped a brace pair around the new lines. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no