unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: david.hull@openx.com, 24960@debbugs.gnu.org
Subject: bug#24960: 25.1; etags incorrectly indexes quoted Erlang atoms
Date: Tue, 25 Jun 2019 19:13:55 +0200	[thread overview]
Message-ID: <m3imst4mgc.fsf@gnus.org> (raw)
In-Reply-To: <83k1d9linv.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 25 Jun 2019 19:43:48 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Lars Ingebrigtsen <larsi@gnus.org>
>> Cc: David Hull <david.hull@openx.com>,  24960@debbugs.gnu.org
>> Date: Tue, 25 Jun 2019 01:39:10 +0200
>> 
>> It looks like the copyright assignment went through, but the patch
>> wasn't applied.
>> 
>> I had a look at the patch, but I know nothing about either Erlang or
>> etags.c, so I can't really say whether it's reasonable or not.  It looks
>> nice, though.  :-)
>
> I think it should go in.

There was one problem in the patch:

       if (len > 0)
-	make_tag (cp, len, true, s, cp + len - s, lineno, linecharno);
+        /* If the name is quoted, the quotes are not part of the name. */
+        if (len > 2 && cp[0] == '\'' && cp[len - 1] == '\'')
+          {
+            cp++;
+            len -= 2;
+          }
+	make_tag (cp, len, true, s, pos, lineno, linecharno);

I think what was meant was that the make_tag should be in that "if"
branch, so I slapped a brace pair around the new lines.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2019-06-25 17:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-18  1:52 bug#24960: 25.1; etags incorrectly indexes quoted Erlang atoms David Hull
2016-11-18  8:27 ` Eli Zaretskii
2016-11-18 16:33   ` David Hull
2016-11-18 16:53     ` Eli Zaretskii
2019-06-24 23:39       ` Lars Ingebrigtsen
2019-06-25 16:43         ` Eli Zaretskii
2019-06-25 17:13           ` Lars Ingebrigtsen [this message]
2019-06-25 17:26             ` Eli Zaretskii
2019-06-25 17:35               ` David Hull

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3imst4mgc.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=24960@debbugs.gnu.org \
    --cc=david.hull@openx.com \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).