From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#35756: [PATCH] file-size-human-readable: fix glitches and add optional space Date: Sun, 23 Jun 2019 18:56:16 +0200 Message-ID: References: <28D42987-D855-4213-9111-DB01E0753D9A@acm.org> <83zhnlbp4l.fsf@gnu.org> <4C9BDFF7-BCE4-421C-84AE-20E243894495@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="183593"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35756@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 23 18:57:25 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hf5nx-000lcb-3f for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Jun 2019 18:57:25 +0200 Original-Received: from localhost ([::1]:45748 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hf5nw-0007hO-4E for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Jun 2019 12:57:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60453) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hf5nb-0007hC-BH for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 12:57:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hf5na-0001os-B0 for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 12:57:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40830) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hf5na-0001oi-4q for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 12:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hf5na-0003Of-2u for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 12:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Jun 2019 16:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35756 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35756-submit@debbugs.gnu.org id=B35756.156130898212952 (code B ref 35756); Sun, 23 Jun 2019 16:57:02 +0000 Original-Received: (at 35756) by debbugs.gnu.org; 23 Jun 2019 16:56:22 +0000 Original-Received: from localhost ([127.0.0.1]:54373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf5mw-0003Mo-5i for submit@debbugs.gnu.org; Sun, 23 Jun 2019 12:56:22 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:43622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf5mu-0003Mf-H7 for 35756@debbugs.gnu.org; Sun, 23 Jun 2019 12:56:20 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hf5mq-00088j-Kg; Sun, 23 Jun 2019 18:56:18 +0200 In-Reply-To: <4C9BDFF7-BCE4-421C-84AE-20E243894495@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Fri, 17 May 2019 13:01:19 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161133 Archived-At: Mattias Engdeg=C3=A5rd writes: > I also added the optional argument UNIT to settle that problem. New > patch attached. Looks good to me. The only thing is: In end of data: files.el:7717:1:Warning: the function `string-empty-p' is not known to be defined. That function is from subr-x, and I if I remember correctly, files.el isn't supposed to load that file... --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no