* bug#30527: 26.0.91; describe-face does not mention :package-version
@ 2018-02-19 14:53 Basil L. Contovounesios
2019-07-14 15:02 ` Lars Ingebrigtsen
0 siblings, 1 reply; 4+ messages in thread
From: Basil L. Contovounesios @ 2018-02-19 14:53 UTC (permalink / raw)
To: 30527
Severity: wishlist
After evaluating the following:
(defgroup my-group nil
"Custom group.")
(defcustom my-var nil
"User option."
:package-version '(my-group . "0.1"))
(defface my-face '((t :inherit default))
"Custom face."
:package-version '(my-group . "0.1"))
C-h v my-var RET then reports, "This variable was introduced, or its
default value was changed, in version 0.1 of the my-group package."
M-x describe-face RET my-face RET, on the other hand, makes no such
comment. Given that defface is documented as accepting the same
keywords as defcustom, I think it would be nice if describe-face were
consistent with describe-variable in this regard.
--
Basil
In GNU Emacs 26.0.91 (build 5, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
of 2018-02-18 built on thunk
Repository revision: 36e729f06cddd2a02fba15516f43f4c1a53bab55
Windowing system distributor 'The X.Org Foundation', version 11.0.11906000
System Description: Debian GNU/Linux testing (buster)
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#30527: 26.0.91; describe-face does not mention :package-version
2018-02-19 14:53 bug#30527: 26.0.91; describe-face does not mention :package-version Basil L. Contovounesios
@ 2019-07-14 15:02 ` Lars Ingebrigtsen
2019-07-14 16:32 ` Andy Moreton
0 siblings, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2019-07-14 15:02 UTC (permalink / raw)
To: Basil L. Contovounesios; +Cc: 30527
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> Severity: wishlist
>
> After evaluating the following:
>
> (defgroup my-group nil
> "Custom group.")
>
> (defcustom my-var nil
> "User option."
> :package-version '(my-group . "0.1"))
>
> (defface my-face '((t :inherit default))
> "Custom face."
> :package-version '(my-group . "0.1"))
>
> C-h v my-var RET then reports, "This variable was introduced, or its
> default value was changed, in version 0.1 of the my-group package."
>
> M-x describe-face RET my-face RET, on the other hand, makes no such
> comment. Given that defface is documented as accepting the same
> keywords as defcustom, I think it would be nice if describe-face were
> consistent with describe-variable in this regard.
Makes sense. I've now added this to the Emacs trunk.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#30527: 26.0.91; describe-face does not mention :package-version
2019-07-14 15:02 ` Lars Ingebrigtsen
@ 2019-07-14 16:32 ` Andy Moreton
2019-07-14 16:39 ` Lars Ingebrigtsen
0 siblings, 1 reply; 4+ messages in thread
From: Andy Moreton @ 2019-07-14 16:32 UTC (permalink / raw)
To: 30527
On Sun 14 Jul 2019, Lars Ingebrigtsen wrote:
> Makes sense. I've now added this to the Emacs trunk.
This fails to build on 64bit MSYS2 (Windows) when dumping:
Loading faces...
(require subr-x) while preparing to dump
make[1]: *** [Makefile:584: emacs.pdmp] Error 127
make[1]: Leaving directory '/c/emacs/git/emacs/master/build/mingw64-x86_64-O2/src'
make: *** [Makefile:424: src] Error 2
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#30527: 26.0.91; describe-face does not mention :package-version
2019-07-14 16:32 ` Andy Moreton
@ 2019-07-14 16:39 ` Lars Ingebrigtsen
0 siblings, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2019-07-14 16:39 UTC (permalink / raw)
To: Andy Moreton; +Cc: 30527
Andy Moreton <andrewjmoreton@gmail.com> writes:
> On Sun 14 Jul 2019, Lars Ingebrigtsen wrote:
>
>> Makes sense. I've now added this to the Emacs trunk.
>
> This fails to build on 64bit MSYS2 (Windows) when dumping:
>
> Loading faces...
> (require subr-x) while preparing to dump
> make[1]: *** [Makefile:584: emacs.pdmp] Error 127
> make[1]: Leaving directory
> '/c/emacs/git/emacs/master/build/mingw64-x86_64-O2/src'
> make: *** [Makefile:424: src] Error 2
I've now reverted the patch; I'll rework it to not use subr-x, I
guess...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-14 16:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-19 14:53 bug#30527: 26.0.91; describe-face does not mention :package-version Basil L. Contovounesios
2019-07-14 15:02 ` Lars Ingebrigtsen
2019-07-14 16:32 ` Andy Moreton
2019-07-14 16:39 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).