unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Juri Linkov <juri@linkov.net>
Cc: "Charles A. Roelli" <charles@aurox.ch>, 31063@debbugs.gnu.org
Subject: bug#31063: 27.0.50; improve help for advised functions
Date: Mon, 15 Jul 2019 12:12:41 +0200	[thread overview]
Message-ID: <m3h87n38ti.fsf@gnus.org> (raw)
In-Reply-To: <87ftn8qqt6.fsf@mail.linkov.net> (Juri Linkov's message of "Sun,  14 Jul 2019 23:55:33 +0300")

Juri Linkov <juri@linkov.net> writes:

>>>>>> (eval-defun EDEBUG-IT)
>>>>>>
>>>>>> :override advice: ‘edebug-eval-defun’
>>>>>
>>>>> (where ":override advice:" is highlighted in orange)
>>>>>
>>>>> Could we please remove (or amend) the orange color for readability,
>>>>
>>>> I also removed the warning face, but feel free to put that back if
>>>> somebody thinks that this deserves a warning.  It seemed a bit too
>>>> dramatic to me.
>>>
>>> It could have a link on ":override advice:" clicking on which will
>>> visit the advice definition.
>>
>> That would be nice.  Do we have that information?
>
> I remember that old defadvice had some link in the Help buffer, but
> now I can't confirm this.  But for new nadvice maybe this will work:
> if a piece of advice is at least a function defined by `defun' then
> maybe it's possible to display the body of advice with a link to the
> function defined by `defun'?

Hm...  isn't that what that `edebug-eval-defun' thing up there is,
though?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





      reply	other threads:[~2019-07-15 10:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-04 18:43 bug#31063: 27.0.50; improve help for advised functions Charles A. Roelli
2019-07-13 15:50 ` Lars Ingebrigtsen
2019-07-14 19:55   ` Juri Linkov
2019-07-14 20:07     ` Lars Ingebrigtsen
2019-07-14 20:55       ` Juri Linkov
2019-07-15 10:12         ` Lars Ingebrigtsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3h87n38ti.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=31063@debbugs.gnu.org \
    --cc=charles@aurox.ch \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).