From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ari Roponen Newsgroups: gmane.emacs.bugs Subject: bug#9679: 24.0.90; After rgrep, next-error goes to the wrong line Date: Fri, 07 Oct 2011 08:15:49 +0300 Message-ID: References: <8739f6w35v.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1317964622 19273 80.91.229.12 (7 Oct 2011 05:17:02 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 7 Oct 2011 05:17:02 +0000 (UTC) Cc: 9679@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 07 07:16:57 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RC2no-0002gq-Lm for geb-bug-gnu-emacs@m.gmane.org; Fri, 07 Oct 2011 07:16:56 +0200 Original-Received: from localhost ([::1]:60756 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RC2nn-0007HB-5H for geb-bug-gnu-emacs@m.gmane.org; Fri, 07 Oct 2011 01:16:55 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:42998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RC2nj-0007Gh-PK for bug-gnu-emacs@gnu.org; Fri, 07 Oct 2011 01:16:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RC2ni-0000FS-JK for bug-gnu-emacs@gnu.org; Fri, 07 Oct 2011 01:16:51 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49588) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RC2ni-0000FH-FR for bug-gnu-emacs@gnu.org; Fri, 07 Oct 2011 01:16:50 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RC2nu-00085x-IX for bug-gnu-emacs@gnu.org; Fri, 07 Oct 2011 01:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ari Roponen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Oct 2011 05:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9679 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9679-submit@debbugs.gnu.org id=B9679.131796457831054 (code B ref 9679); Fri, 07 Oct 2011 05:17:02 +0000 Original-Received: (at 9679) by debbugs.gnu.org; 7 Oct 2011 05:16:18 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RC2nB-00084n-Kl for submit@debbugs.gnu.org; Fri, 07 Oct 2011 01:16:18 -0400 Original-Received: from mail-bw0-f44.google.com ([209.85.214.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RC2n8-00084U-Vi for 9679@debbugs.gnu.org; Fri, 07 Oct 2011 01:16:15 -0400 Original-Received: by bkaq10 with SMTP id q10so3996111bka.3 for <9679@debbugs.gnu.org>; Thu, 06 Oct 2011 22:15:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=u0Pgf2uY8/ObGXGzE/L+MFDAgkESBvzCsqASbEYNkXk=; b=loZH9GnNMnZZyLPYZXrn95REvMixqqeUc6ijUbTfEV08JC58yOdGzXa5xbT0mjxEk3 yME01zNvD9AF5IyIQphS65CXWrPe1+71+JrjIwh4ow5axzQwpKvt3gp1c/c6g3tU5lbz bJmlcCP3jtdTdEYBOUY5MCeT0bg9yMBwu2wOs= Original-Received: by 10.223.65.3 with SMTP id g3mr8625220fai.25.1317964556595; Thu, 06 Oct 2011 22:15:56 -0700 (PDT) Original-Received: from arirop (dsl-jklbrasgw1-fe17fb00-113.dhcp.inet.fi. [84.251.23.113]) by mx.google.com with ESMTPS id v17sm10712334fai.18.2011.10.06.22.15.53 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 06 Oct 2011 22:15:55 -0700 (PDT) In-Reply-To: <8739f6w35v.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 06 Oct 2011 18:27:56 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 07 Oct 2011 01:17:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:52348 Archived-At: Juri Linkov writes: > Thanks for the comprehensive test case. I tried it but the second call > goes into the line starting with "(mapcar #'string-to-number ...". Hi, I compared the behavior between the version with commits reverted and not reverted. In the reverted commits case, typing M-g M-p and M-g M-n goes to the correct line and column, but highlights the whole line. In the non-reverted commits case, typing those commands goes to the wrong line but right column. The highlight seems to start at the end of correct match and end at the cursor position. I found something that may be relevant to the problem. These are the values of *grep*-buffer's variable compilation-locs in both cases: * Reverted commits case: Value: #s(hash-table size 65 test equal weakness value rehash-size 1.5 rehash-threshold 0.8 data ( ("./test.el") (("./test.el" nil) nil (8 (nil 8 #1 # nil . t)) (3 (nil 3 #1 # nil . t))))) * Non-reverted commits case: Value: #s(hash-table size 65 test equal weakness value rehash-size 1.5 rehash-threshold 0.8 data (("Grep started at Fri Oct 7 07") (("Grep started at Fri Oct 7 07" nil) nil (31 (nil 31 #1 nil nil))) ("./test.el") (("./test.el" nil) nil (8 (13 8 #1 # nil) (7 8 #1 # nil . t)) (3 (13 3 #1 # nil) (7 3 #1 # nil . t))) ("Grep finished (matches found) at Fri Oct 7 07") (("Grep finished (matches found) at Fri Oct 7 07" nil) nil (31 (nil 31 #1 nil nil))))) In the non-reverted commits case, The marker pairs seem to delimit the matched text. The first pair (from 258 to 387) starts at the end of correct match and goes too far. The second pair (from 90 to 96) highlight correctly the first match. I noticed that killing the buffer the markers use seems to fix the problem: 1. Run the test case from the original bug report. 2. Kill the "test.el"-buffer 3. Type M-g M-p M-g M-n Now the cursor is at the beginning of the match and the match is highlighted correctly. The value of compilation-locs in *grep*-buffer is also correct: Value: #s(hash-table size 65 test equal weakness value rehash-size 1.5 rehash-threshold 0.8 data (("Grep started at Fri Oct 7 07") (("Grep started at Fri Oct 7 07" nil) nil (56 (nil 56 #1 nil nil))) ("./test.el") (("./test.el" nil) nil (8 (13 8 #1 # nil) (7 8 #1 # nil . t)) (3 (13 3 #1 # nil) (7 3 #1 # nil . t))) ("Grep finished (matches found) at Fri Oct 7 07") (("Grep finished (matches found) at Fri Oct 7 07" nil) nil (56 (nil 56 #1 nil nil))))) I guess the problem has something to do with those markers. -- Ari Roponen