unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: 36565@debbugs.gnu.org
Subject: bug#36565: [PATCH] Suppress interactive-only warnings in undo-tests.el
Date: Thu, 11 Jul 2019 16:11:25 +0200	[thread overview]
Message-ID: <m3ftncy836.fsf@gnus.org> (raw)
In-Reply-To: <CADwFkm=jG0mdOQ2H9rWp-aPZ9EgB7KS4UqPWO1Or5oHf3ZCiUQ@mail.gmail.com> (Stefan Kangas's message of "Thu, 11 Jul 2019 00:53:01 +0200")

Stefan Kangas <stefan@marxist.se> writes:

> Lars Ingebrigtsen <larsi@gnus.org> writes:
>> Hm...  is it worth it to suppress warnings in the tests, though?  I
>> think we kinda expect there to be a lot of noise when running the tests?
>
> I'm not sure I understand.  Do you mean that you're not sure if it's
> worth it to fix warnings in the Emacs test suite, or do you mean
> fixing with-suppressed-warnings to handle this case?

I meant the first.  I mean, I'm not opposed to it or anything, but my
opinion is that aiming for a warning-free test suite would be to put
an undue burden on the test writers for little gain.  (When we're used
to having a warning-free build, then any warning sticks out like a sore
thumb and is generally fixed pretty quickly...)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2019-07-11 14:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-10  1:14 bug#36565: [PATCH] Suppress interactive-only warnings in undo-tests.el Stefan Kangas
2019-07-10  1:24 ` Stefan Kangas
2019-07-10  3:40   ` Stefan Kangas
2019-07-10  3:53     ` Stefan Kangas
2019-07-17 20:08       ` Noam Postavsky
2019-08-04 16:46         ` Stefan Kangas
2019-08-08 12:30           ` Noam Postavsky
2019-07-10 12:09 ` Lars Ingebrigtsen
2019-07-10 22:53   ` Stefan Kangas
2019-07-11 14:11     ` Lars Ingebrigtsen [this message]
2019-07-11 17:31       ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3ftncy836.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=36565@debbugs.gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).