* bug#74: Bug#74: defcustom keyword :custom-show isn't documented [not found] <v9eja3olxa.fsf@marauder.physik.uni-ulm.de> @ 2010-01-21 5:08 ` Glenn Morris 2011-07-06 17:27 ` bug#74: " Lars Magne Ingebrigtsen 0 siblings, 1 reply; 4+ messages in thread From: Glenn Morris @ 2010-01-21 5:08 UTC (permalink / raw) To: 74 reassign 74 emacs stop Reiner Steib wrote: > Neither the doc string of `defcustom', nor the manual explains it. It seems that it (:custom-show) is supposed to make the variable value field be hidden by default when it is created. In other words, make the custom buffer look like you have clicked the "Hide the value of this option" button. The idea is that when a variable has a complex value, it should be hidden by default, to avoid cluttering up the display. However, AFAICS it doesn't work (in Emacs 21, 22, or 23). custom-variable-value-create only uses custom-show when a variable has a nil :custom-state. Since variables are created with state 'unknown, it never does anything. Making the obvious change doesn't work (the variable is created hidden ok, but can't be unhidden by clicking the relevant button). Given that it seems never to have worked, I'm not sure it's worth bothering trying to fix it. It's only used in gnus-art (and cus-edit tries to apply it to long editable-fields). ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#74: defcustom keyword :custom-show isn't documented 2010-01-21 5:08 ` bug#74: Bug#74: defcustom keyword :custom-show isn't documented Glenn Morris @ 2011-07-06 17:27 ` Lars Magne Ingebrigtsen 2011-07-06 20:15 ` Stefan Monnier 0 siblings, 1 reply; 4+ messages in thread From: Lars Magne Ingebrigtsen @ 2011-07-06 17:27 UTC (permalink / raw) To: Glenn Morris; +Cc: 74 Glenn Morris <rgm@gnu.org> writes: >> Neither the doc string of `defcustom', nor the manual explains it. > > It seems that it (:custom-show) is supposed to make the variable value > field be hidden by default when it is created. In other words, make the > custom buffer look like you have clicked the "Hide the value of this > option" button. > > The idea is that when a variable has a complex value, it should be > hidden by default, to avoid cluttering up the display. > > However, AFAICS it doesn't work (in Emacs 21, 22, or 23). > custom-variable-value-create only uses custom-show when a variable has a > nil :custom-state. Since variables are created with state 'unknown, it > never does anything. > > Making the obvious change doesn't work (the variable is created hidden > ok, but can't be unhidden by clicking the relevant button). > > Given that it seems never to have worked, I'm not sure it's worth > bothering trying to fix it. It's only used in gnus-art (and cus-edit > tries to apply it to long editable-fields). Perhaps we should just remove the usages, and mark :custom-show as obsolete? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#74: defcustom keyword :custom-show isn't documented 2011-07-06 17:27 ` bug#74: " Lars Magne Ingebrigtsen @ 2011-07-06 20:15 ` Stefan Monnier 2011-07-07 15:59 ` Lars Magne Ingebrigtsen 0 siblings, 1 reply; 4+ messages in thread From: Stefan Monnier @ 2011-07-06 20:15 UTC (permalink / raw) To: Lars Magne Ingebrigtsen; +Cc: 74 >> Given that it seems never to have worked, I'm not sure it's worth >> bothering trying to fix it. It's only used in gnus-art (and cus-edit >> tries to apply it to long editable-fields). > Perhaps we should just remove the usages, and mark :custom-show as > obsolete? Agreed, Stefan ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#74: defcustom keyword :custom-show isn't documented 2011-07-06 20:15 ` Stefan Monnier @ 2011-07-07 15:59 ` Lars Magne Ingebrigtsen 0 siblings, 0 replies; 4+ messages in thread From: Lars Magne Ingebrigtsen @ 2011-07-07 15:59 UTC (permalink / raw) To: Stefan Monnier; +Cc: 74 Stefan Monnier <monnier@iro.umontreal.ca> writes: >>> Given that it seems never to have worked, I'm not sure it's worth >>> bothering trying to fix it. It's only used in gnus-art (and cus-edit >>> tries to apply it to long editable-fields). >> Perhaps we should just remove the usages, and mark :custom-show as >> obsolete? > > Agreed, I've now added a comment to the definition of the :custom-show widget, and marked the `custom-show' function as obsolete. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-07-07 15:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <v9eja3olxa.fsf@marauder.physik.uni-ulm.de>
2010-01-21 5:08 ` bug#74: Bug#74: defcustom keyword :custom-show isn't documented Glenn Morris
2011-07-06 17:27 ` bug#74: " Lars Magne Ingebrigtsen
2011-07-06 20:15 ` Stefan Monnier
2011-07-07 15:59 ` Lars Magne Ingebrigtsen
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).