From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Liu Newsgroups: gmane.emacs.bugs Subject: bug#17630: 24.3.91; gv expander for a few places are incorrect Date: Sat, 31 May 2014 11:04:07 +0800 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1401505529 32272 80.91.229.3 (31 May 2014 03:05:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 31 May 2014 03:05:29 +0000 (UTC) Cc: 17630@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 31 05:05:22 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WqZbl-0000Ip-CT for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 May 2014 05:05:21 +0200 Original-Received: from localhost ([::1]:57924 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WqZbk-00017b-Tf for geb-bug-gnu-emacs@m.gmane.org; Fri, 30 May 2014 23:05:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WqZba-00010k-M6 for bug-gnu-emacs@gnu.org; Fri, 30 May 2014 23:05:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WqZbT-0005ii-74 for bug-gnu-emacs@gnu.org; Fri, 30 May 2014 23:05:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39444) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WqZbT-0005i7-2x for bug-gnu-emacs@gnu.org; Fri, 30 May 2014 23:05:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WqZbS-0000GZ-E5 for bug-gnu-emacs@gnu.org; Fri, 30 May 2014 23:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Leo Liu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 May 2014 03:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17630 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17630-submit@debbugs.gnu.org id=B17630.1401505472958 (code B ref 17630); Sat, 31 May 2014 03:05:02 +0000 Original-Received: (at 17630) by debbugs.gnu.org; 31 May 2014 03:04:32 +0000 Original-Received: from localhost ([127.0.0.1]:38321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqZax-0000FN-SZ for submit@debbugs.gnu.org; Fri, 30 May 2014 23:04:32 -0400 Original-Received: from mail-pa0-f53.google.com ([209.85.220.53]:42259) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqZaw-0000F7-82 for 17630@debbugs.gnu.org; Fri, 30 May 2014 23:04:31 -0400 Original-Received: by mail-pa0-f53.google.com with SMTP id lj1so1263838pab.12 for <17630@debbugs.gnu.org>; Fri, 30 May 2014 20:04:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=4zcL7CAoTJ+Vb+aYjanPTp0bDHBQa0bDWNbA5IKBH0w=; b=NqXcIe6SfcsqRxbAJXVpKSDzAJK2ym7nqmJ2tSnVxYYOwOeUKG709oeNNwbD0haw/0 sLe7IOBMZt2I50hDn3xFVqQFPSDPNZ4II9co/IEVA6C/jSgw7XjGYECz2EbJIHBdwZOu dVnjgOEcMUoqfxyApf0UykwOr5eUaUxnamMhiHSGWtCDDPpdLxBK7h1yHdMHgDFDXqkX oKCsO9Q3C6hLy5j8jEo2vA66ahf+2FIP/JjNhOAuFj207q/0l53mhbq2QTZpcd7DV1iz LktwARA5M1lOem1NTSEuHzKbjlkigA2OG6u/LoXTzV6yCEy0o3grEtMoKF2ytV00eMAw 0qjA== X-Received: by 10.69.20.10 with SMTP id gy10mr23759406pbd.162.1401505464015; Fri, 30 May 2014 20:04:24 -0700 (PDT) Original-Received: from fortuna ([222.130.180.115]) by mx.google.com with ESMTPSA id pv4sm27057028pac.14.2014.05.30.20.04.17 for (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Fri, 30 May 2014 20:04:22 -0700 (PDT) Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAElBMVEUAAAAAAP+LRRP0pGC+ vr7///+7mT1iAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9cBBwMO DhglKe4AAAEsSURBVCjPbZNBboQwDEV/Cd4X9QJRThApmn0XYW+Jyf2v0m+HhqDBgiAe9rcTG7QH w/1Vn2Ar8gBb/ocywSN3qK9T3z4eFDB4eApocBpeBs1RSykoJd8gQcm8pGmHXFso3ajnmsqV0TnY DQkOfXUfN5NwaI7AWTVOyEhcu1aHmdWItHddUVUcUgUBCkitu8V6ditHVOVdqzl2EQ1ZVGTbdK0V 7cqn8vWzoU5Q/bF9Y/Y0cRU1xwkys5dJ+Dt6pBDWifcNQml8Gh2JVmPSoQzo7en0grswkxrUGYJ7 0hSxxAGr7ZMwYcHIzprpi7TENEE1xtiYxixRlCfPBsUUrwHD7uGIwATrbnODJcVrPpVn3hxiGloe m/S+z3CtuzUSMo83N4DPH+F0evwR3P4A2k+75838OKQAAAAASUVORK5CYII= In-Reply-To: (Stefan Monnier's message of "Fri, 30 May 2014 12:20:49 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (CentOS 6.5) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:89789 Archived-At: On 2014-05-30 12:20 -0400, Stefan Monnier wrote: > Indeed. So I guess the better fix is to use gv-define-setter, indeed. > BTW, IIRC these setter definitions come straight from the old CL code, > so this bug has been with us for a while. Indeed, though the return value of (setf (window-buffer ...) ...) is a regression. The fix is trivial. Do you mind installing it in emacs-24? === modified file 'lisp/emacs-lisp/gv.el' --- lisp/emacs-lisp/gv.el 2014-02-21 19:01:19 +0000 +++ lisp/emacs-lisp/gv.el 2014-05-31 02:50:44 +0000 @@ -340,13 +340,16 @@ (gv-define-simple-setter process-filter set-process-filter) (gv-define-simple-setter process-sentinel set-process-sentinel) (gv-define-simple-setter process-get process-put) -(gv-define-simple-setter window-buffer set-window-buffer) -(gv-define-simple-setter window-display-table set-window-display-table 'fix) -(gv-define-simple-setter window-dedicated-p set-window-dedicated-p) -(gv-define-simple-setter window-hscroll set-window-hscroll) (gv-define-simple-setter window-parameter set-window-parameter) -(gv-define-simple-setter window-point set-window-point) -(gv-define-simple-setter window-start set-window-start) +(gv-define-setter window-buffer (v &optional w) + `(progn (set-window-buffer ,w ,v) ,v)) +(gv-define-setter window-display-table (v &optional w) + `(progn (set-window-display-table ,w ,v) ,v)) +(gv-define-setter window-dedicated-p (v &optional w) + `(set-window-dedicated-p ,w ,v)) +(gv-define-setter window-hscroll (v &optional w) `(set-window-hscroll ,w ,v)) +(gv-define-setter window-point (v &optional w) `(set-window-point ,w ,v)) +(gv-define-setter window-start (v &optional w) `(set-window-start ,w ,v)) (gv-define-setter buffer-local-value (val var buf) (macroexp-let2 nil v val