unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Liu <sdl.web@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 18652@debbugs.gnu.org
Subject: bug#18652: 25.0.50; [PATCH] Add fresh-line
Date: Wed, 08 Oct 2014 16:45:24 +0800	[thread overview]
Message-ID: <m3egujne57.fsf@gmail.com> (raw)
In-Reply-To: <83zjd7jawz.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 08 Oct 2014 10:08:44 +0300")

Thanks for your input.

On 2014-10-08 10:08 +0300, Eli Zaretskii wrote:
> I can't say I care much for this name.  How about add-newline, or
> ensure-newline or some such?

The name is taken from CL's fresh-line but that doesn't mean it is best
suited. add-newline sounds like an alias to terpri, so it is the least
favourable. `ensure-newline' is acceptable to me. But if we choose
ensure-newline I'd like to add an alias to it in cl-lib.el.

>> +@cindex fresh line in print
>> +This function outputs a newline to @var{stream} unless already at the
>> +beginning of a line. Return @code{t} if a newline is printed. Signal
>
> "At beginning of a line" needs explanation, I think.

Any suggestion on how to improve it?

> Also, our convention is to have 2 spaces between sentences.
>
> Finally, the style in the manual is to say "function returns" or "it
> returns" and "signals", instead of "return" and "signal".
>
> Thanks.

Indeed.

=== modified file 'doc/lispref/streams.texi'
--- doc/lispref/streams.texi	2014-03-18 01:19:03 +0000
+++ doc/lispref/streams.texi	2014-10-08 08:45:10 +0000
@@ -621,6 +621,14 @@
 for ``terminate print''.
 @end defun
 
+@defun fresh-line &optional stream
+@cindex fresh line in print
+This function outputs a newline to @var{stream} if it is not already
+at the beginning of a line.  It returns @code{t} if a newline is
+printed.  It can not take a function as @var{STREAM} and an error is
+signaled in this case.
+@end defun
+
 @defun write-char character &optional stream
 This function outputs @var{character} to @var{stream}.  It returns
 @var{character}.





  reply	other threads:[~2014-10-08  8:45 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-07 13:03 bug#18652: 25.0.50; [PATCH] Add fresh-line Leo Liu
2014-10-07 13:21 ` Andreas Schwab
2014-10-07 13:43   ` Leo Liu
2014-10-07 13:47     ` Andreas Schwab
2014-10-07 14:15 ` Stefan Monnier
2014-10-07 15:13   ` Leo Liu
2014-10-07 20:45     ` Stefan Monnier
2014-10-08  1:54       ` Leo Liu
2014-10-08  5:08         ` Leo Liu
2014-10-08  7:08           ` Eli Zaretskii
2014-10-08  8:45             ` Leo Liu [this message]
2014-10-08 10:26               ` Eli Zaretskii
2014-10-08 14:02             ` Stefan Monnier
2014-10-08 16:17               ` Leo Liu
2014-10-08 18:26                 ` Stefan Monnier
2014-10-08 22:24                   ` Leo Liu
2014-10-09  1:15                     ` Glenn Morris
2014-10-09  1:57                       ` Leo Liu
2014-10-09  2:02                         ` Glenn Morris
2014-10-09  6:46                           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3egujne57.fsf@gmail.com \
    --to=sdl.web@gmail.com \
    --cc=18652@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).