From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.bugs Subject: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 Date: Tue, 12 Jun 2018 21:39:37 -0400 Message-ID: References: <87po132y9k.fsf@gmail.com> <87h8me3hyw.fsf@gmail.com> <87zi0611m6.fsf@gmail.com> <87vaat1ndq.fsf@gmail.com> <83po0w3p62.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1528853890 17459 195.159.176.226 (13 Jun 2018 01:38:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 13 Jun 2018 01:38:10 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) Cc: 31742@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 13 03:38:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSujb-0004Ol-MI for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Jun 2018 03:38:03 +0200 Original-Received: from localhost ([::1]:59223 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSulh-0007xD-2W for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Jun 2018 21:40:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41967) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSula-0007v1-VD for bug-gnu-emacs@gnu.org; Tue, 12 Jun 2018 21:40:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSulX-0000uH-22 for bug-gnu-emacs@gnu.org; Tue, 12 Jun 2018 21:40:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37679) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fSulW-0000uB-UA for bug-gnu-emacs@gnu.org; Tue, 12 Jun 2018 21:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fSulW-0001vS-MT for bug-gnu-emacs@gnu.org; Tue, 12 Jun 2018 21:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thomas Fitzsimmons Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Jun 2018 01:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31742 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31742-submit@debbugs.gnu.org id=B31742.15288539877376 (code B ref 31742); Wed, 13 Jun 2018 01:40:02 +0000 Original-Received: (at 31742) by debbugs.gnu.org; 13 Jun 2018 01:39:47 +0000 Original-Received: from localhost ([127.0.0.1]:45576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSulG-0001uu-QN for submit@debbugs.gnu.org; Tue, 12 Jun 2018 21:39:47 -0400 Original-Received: from mail-it0-f47.google.com ([209.85.214.47]:40391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSulF-0001ui-Aw for 31742@debbugs.gnu.org; Tue, 12 Jun 2018 21:39:45 -0400 Original-Received: by mail-it0-f47.google.com with SMTP id 188-v6so1806123ita.5 for <31742@debbugs.gnu.org>; Tue, 12 Jun 2018 18:39:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=O7TsLALJXfyvVtz/oEHJrXbVXhAjvxFUarSvscEYs10=; b=E01IUdz9npGEpDqtFWKc4ISjg54o6cSkRsJfRCBw9+2aNW/cDBoshfh2LTDFNSbYLz s9Sp+c6yeJETy/H4mv31I5Kjlut48WFLyXRLl9PXndhE3i9gjH6+Xb47DWOjHTeP3zGL Cp+Lx4LVUMzljd8DgTdxqvsomm94i5r4HZBnKIIkUQP5HmJ5KtK8yvANZ9QIyZPTd5PY qNQFOJSFQ9HMgv9kAkPsfGJrjsKneny2z4BfanHeoIuWnzOKFgjmR1KV7gI3yhuNEeLS Y8AX3ZinOSllO9XqfT3y+rOVO+wqfzHk+lUdU/Yjzu5BIjJ+x/5So1RN3uhFyrJ1KSi+ dpHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=O7TsLALJXfyvVtz/oEHJrXbVXhAjvxFUarSvscEYs10=; b=VEut8RuvEjzbpMesaTMahoC+du0tt+ChbS1pkXgI32vVAvE1PQOBXtnHj3TsQAyiYQ 82ahB+OHF7Gbz1cgYn2BUQZXF2rVztLG7teHFMHBMNTpJ2nmqn62yHZIon8qULxnjt4+ dYo5Vb8cjojBBUacWpAKj9ZFhl7aANlXmtoiVemem+072ZhNhxbDj6JOxUoZmug/4ecS ivacsDaVB9H2WLKZu3fnokNVpgs9v2iXnVVNmosVYSCWiW1dgTUoGZihqjwq+5g0uuxr ZYTzMIFfDzt080MyaK1yxSJRUvlI+23heJ/dhP6lfQzOdKPF/vOjNAHi3M1qPiENwwM9 quUQ== X-Gm-Message-State: APt69E3u+3KzqxQI9Mq7Fgv+oTKl0/wWL63NIpKywSgTqklxmFjOlNpw KpsZDfYtwZKK+6ioQWuFtqd1I65y X-Google-Smtp-Source: ADUXVKIkHbgie3byMybuuTP96Wq2SDk37m8LIdVa5NIGfT5euiJKVQDH9VbFvZ/8ZGU1Y8pTTCV8jA== X-Received: by 2002:a24:4e8f:: with SMTP id r137-v6mr3025224ita.9.1528853979518; Tue, 12 Jun 2018 18:39:39 -0700 (PDT) Original-Received: from hp-dv5t (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id 16-v6sm1076733itk.17.2018.06.12.18.39.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Jun 2018 18:39:38 -0700 (PDT) In-Reply-To: <83po0w3p62.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 12 Jun 2018 20:11:49 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147352 Archived-At: Eli Zaretskii writes: >> From: Thomas Fitzsimmons >> Date: Mon, 11 Jun 2018 21:55:48 -0400 >> Cc: Noam Postavsky , 31742-done@debbugs.gnu.org >> >> I added the comment, bumped the soap-client version to 3.1.4 and pushed >> the patch to master so that GNU ELPA will be regenerated tonight. I >> also backported the patch to the emacs-26 branch since it fixes a >> functional regression. > > Thanks, but please in the future always ask before pushing stuff to > the release branch. Not every regression fix should go to emacs-26, > only those which we consider "safe enough". OK, will do, sorry about that. > Also, if a change should be both on master and on emacs-26, push only > to the latter, and it will be later merged to master together with > other changes in emacs-26. We only backport from master if initially > we didn't intend for a change to be on emacs-26; otherwise we merge in > the other direction. (This is all explained in CONTRIBUTE under > "Branches".) Yes, I knew about the preferred emacs-26 -> master merge direction, but in this case I wanted to get the soap-client change out to GNU ELPA ASAP so that users could unbreak their Emacs 25 byte-code. A GNU ELPA rebuild of soap-client requires a push to master. I guess I should have undertaken a full gitmerge run myself after having had the patch reviewed for emacs-26 on emacs-devel; I considered doing so, but I thought the master -> emacs-26-backport approach would be less risky. But in the future I'll attempt the gitmerge route in cases like this. Thomas