From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: 33665@debbugs.gnu.org
Subject: bug#33665: 27.0.50; Variables not set up in Gnus when hooks are run
Date: Fri, 07 Dec 2018 19:04:07 +0100 [thread overview]
Message-ID: <m3efattdrc.fsf@gnus.org> (raw)
In-Reply-To: <875zw5xn9a.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Fri, 07 Dec 2018 09:25:21 -0800")
Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> It looks like gnus-newsgroup-name (and friends?) are no longer set when
>> the summary mode hooks are run, so hooks that rely on that are now
>> broken.
>
> Yes, since `gnus-summary-mode' is now a real mode, it clears local
> variables before running the hook. The right place for that sort of hook
> is now `gnus-summary-prepared-hook'. I tried to change all the relevant
> hooks I could within the codebase, but I guess gnus-mdrtn.el isn't
> publicly available? I can change the Moderation section of the manual to
> update the installation instructions.
No, you can't break third-party software that way. You have to set the
variables the hooks expect to exist before calling the hook.
>> It also looks like summary mode line highlights no longer works.
I think that was a false alarm.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2018-12-07 18:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 16:37 bug#33665: 27.0.50; Variables not set up in Gnus when hooks are run Lars Ingebrigtsen
2018-12-07 17:25 ` Eric Abrahamsen
2018-12-07 17:52 ` Eric Abrahamsen
2018-12-07 18:04 ` Lars Ingebrigtsen [this message]
2018-12-07 18:36 ` Eric Abrahamsen
2018-12-12 14:36 ` Lars Ingebrigtsen
2018-12-12 19:52 ` Eric Abrahamsen
2018-12-19 21:57 ` Lars Ingebrigtsen
2018-12-19 22:14 ` Eric Abrahamsen
2018-12-19 22:17 ` Lars Ingebrigtsen
2018-12-19 22:30 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3efattdrc.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=33665@debbugs.gnu.org \
--cc=eric@ericabrahamsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).