From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#32920: Patch: Add variable json-pretty-print-max-indentation-level to allow more flexibility when pretty-printing json Date: Sun, 23 Jun 2019 23:25:03 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="187404"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 32920@debbugs.gnu.org To: Jose Arroyo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 23 23:26:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfA02-000mdL-TT for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Jun 2019 23:26:11 +0200 Original-Received: from localhost ([::1]:46798 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfA01-00035v-JD for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Jun 2019 17:26:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60711) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hf9zv-00034e-EP for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 17:26:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hf9zu-0007LA-D8 for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 17:26:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41452) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hf9zu-0007Kw-95 for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 17:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hf9zu-0006ko-4J for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 17:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Jun 2019 21:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32920 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32920-submit@debbugs.gnu.org id=B32920.156132511025860 (code B ref 32920); Sun, 23 Jun 2019 21:26:02 +0000 Original-Received: (at 32920) by debbugs.gnu.org; 23 Jun 2019 21:25:10 +0000 Original-Received: from localhost ([127.0.0.1]:54993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf9z4-0006j1-44 for submit@debbugs.gnu.org; Sun, 23 Jun 2019 17:25:10 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:47378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf9z2-0006iq-5a for 32920@debbugs.gnu.org; Sun, 23 Jun 2019 17:25:08 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hf9yx-0002Ht-OU; Sun, 23 Jun 2019 23:25:06 +0200 In-Reply-To: (Jose Arroyo's message of "Wed, 3 Oct 2018 17:08:47 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161174 Archived-At: Jose Arroyo writes: > For example, if we have the following json > {"firstKey": {"46": "0"},"secondKey": {"46": [[[[0,0],0],0],0]},"thirdKey": > {"46": 0}} > > The current json-pretty-print outputs: > { > "firstKey": { > "46": "0" > }, > "secondKey": { > "46": [ > [ > [ > [ > 0, > 0 > ], > 0 > ], > 0 > ], > 0 > ] > }, > "thirdKey": { > "46": 0 > } > } That is, indeed, really bad pretty printing of the arrays. But I think the approach you take in the patch isn't ideal, either: If you have nested hash maps, then you want to have them nicely indented and broken up into shapes like the one above. > Whereas my/json-flatten-object-one-level would output: > { > "firstKey": {"46": "0"}, > "secondKey": {"46": [[[[0,0],0],0],0]}, > "thirdKey": {"46": 0} > } I think a better solution here would be to just handle [] arrays in a totally different way than the current pretty-printer, and instead keep them on one line. Well, at least more on one line than today... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no