From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#23794: Emacs 25.0.94: Patch to make sort-lines respect visible lines (fairly urgent) Date: Tue, 25 Jun 2019 15:08:28 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="233268"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 23794@debbugs.gnu.org, rswgnu@gmail.com To: Robert Weiner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 25 15:24:04 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hflQZ-000yWs-Rw for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 15:24:03 +0200 Original-Received: from localhost ([::1]:60136 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hflQY-0003oc-QK for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 09:24:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51272) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hflC4-0001oh-0H for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 09:09:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hflC2-0000IN-0l for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 09:09:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45372) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hflC1-0000ID-T8 for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 09:09:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hflC1-00021l-NA for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 09:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2019 13:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23794 X-GNU-PR-Package: emacs Original-Received: via spool by 23794-submit@debbugs.gnu.org id=B23794.15614681167746 (code B ref 23794); Tue, 25 Jun 2019 13:09:01 +0000 Original-Received: (at 23794) by debbugs.gnu.org; 25 Jun 2019 13:08:36 +0000 Original-Received: from localhost ([127.0.0.1]:58913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hflBb-00020q-6v for submit@debbugs.gnu.org; Tue, 25 Jun 2019 09:08:36 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:48844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hflBZ-00020h-3g for 23794@debbugs.gnu.org; Tue, 25 Jun 2019 09:08:33 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hflBU-0008Tf-OO; Tue, 25 Jun 2019 15:08:31 +0200 In-Reply-To: (Robert Weiner's message of "Sat, 18 Jun 2016 11:47:08 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161350 Archived-At: Robert Weiner writes: > sort-lines calls forward-line rather than forward-visible line, so if > you have emacs outline entries that are collapsed/hidden to single lines > each and you try to sort them, their bodies and subtrees are sorted > separately because forward-visible-line is not used. > > This patch fixes this problem and also unifies the calling convention of > forward-visible-line with that of forward-line (allowing it to take an > optional argument) leading to a cleaner calling convention. This was three years ago, and from what I can tell, nobody has changed sort-lines to be aware of invisible lines... I can see the case for allowing the caller to control this, but none of the patches proposed look acceptable to me (for instance, one made sort.el check for outline mode explicitly, which seems backwards). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no