From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#4816: change of coding system without inquiry Date: Thu, 27 Jun 2019 19:49:33 +0200 Message-ID: References: <4AE77C59.5060106@informatik.uni-muenchen.de> <4AEAE7F8.6010609@informatik.uni-muenchen.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="158385"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: eisinger@informatik.uni-muenchen.de, 4816@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 27 19:51:29 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hgYYT-000f2b-13 for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Jun 2019 19:51:29 +0200 Original-Received: from localhost ([::1]:53336 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgYYS-0007QY-1H for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Jun 2019 13:51:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38834) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgYX9-0006GT-Fl for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2019 13:50:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgYX6-0006Ef-Tl for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2019 13:50:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54222) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hgYX4-0006DE-8R for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2019 13:50:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hgYX4-0004NY-3a for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2019 13:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jun 2019 17:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4816 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 4816-submit@debbugs.gnu.org id=B4816.156165778116781 (code B ref 4816); Thu, 27 Jun 2019 17:50:02 +0000 Original-Received: (at 4816) by debbugs.gnu.org; 27 Jun 2019 17:49:41 +0000 Original-Received: from localhost ([127.0.0.1]:39530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgYWj-0004Mb-1L for submit@debbugs.gnu.org; Thu, 27 Jun 2019 13:49:41 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:46196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgYWg-0004MQ-8Q for 4816@debbugs.gnu.org; Thu, 27 Jun 2019 13:49:39 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hgYWb-0008Gv-Tv; Thu, 27 Jun 2019 19:49:36 +0200 In-Reply-To: (Stefan Monnier's message of "Fri, 30 Oct 2009 11:02:49 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161628 Archived-At: (Bug report about Latin-1 files becoming UTF-8.) Stefan Monnier writes: > + (unless (or (local-variable-p 'buffer-file-coding-system) > + (eq coding-system buffer-file-coding-system) > + ;; We'd rather only bother the user if the coding-system > + ;; change would cause the file's content to change, so we'd > + ;; want to check whether the new coding-system is a superset > + ;; of the previous one. > + (memq buffer-file-coding-system '(nil undecided us-ascii)) > + (y-or-n-p (format "Change encoding from %s to %s? " > + buffer-file-coding-system coding-system))) > + (setq coding-system nil)) Eli Zaretskii writes: > FWIW, in the past users explicitly expressed annoyance by these > questions. The request was to use the "native" encoding silently. By > introducing back this question, we are restoring that annoyance. Perhaps it's time to make a decision now -- to not add a change like this? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no